Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Replaceable Monitoring Cluster Definition #26431

Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
56ca8a6
Add Replacable Monitoring Cluster Definition
p0fi May 8, 2023
10e6de1
Add Cluster Definition to Relevant Lists
p0fi May 8, 2023
4fd9277
Enable New Clusters in Darvin and Android Clients
p0fi May 8, 2023
868c69f
Add Clusters to Cluster List
p0fi May 8, 2023
b311e83
Add Generated Code
p0fi May 8, 2023
6f4f529
Fix Code Formatting for Java Files
p0fi May 8, 2023
a54a1ac
Add Cluster Definition to CI Tests
p0fi May 8, 2023
88cf0f0
Add Missing Cluster in Cluster List
p0fi May 8, 2023
ba5a4a3
Merge branch 'master' into 26223-add-replaceable-monitoring-cluster-d…
p0fi May 8, 2023
7da3390
Fix Java Code Gen
p0fi May 8, 2023
dc0b9c0
Revert Parameter Re-Ordering
p0fi May 9, 2023
d2b6588
Add Cluster Definition to CI Tests
p0fi May 9, 2023
40333d8
Merge branch 'master' into 26223-add-replaceable-monitoring-cluster-d…
p0fi May 9, 2023
06767d6
Revert Re-Ordering
p0fi May 9, 2023
1e6aad9
Add New Cluster
p0fi May 9, 2023
dbed4cb
Merge branch 'master' into 26223-add-replaceable-monitoring-cluster-d…
p0fi May 9, 2023
faa1d5c
Revert Re-Ordering
p0fi May 9, 2023
8282bcc
Add New Cluster
p0fi May 9, 2023
59238e6
Re-Add Changes
p0fi May 9, 2023
04a340a
Revert Re-Sorting
p0fi May 9, 2023
6e23463
Revert Re-Ordering
p0fi May 9, 2023
1ddd92a
Re-Add Changes
p0fi May 9, 2023
9ac725a
Add Expected Generated Files
p0fi May 10, 2023
0ccbd6e
Merge branch 'master' into 26223-add-replaceable-monitoring-cluster-d…
p0fi May 10, 2023
5344322
Merge branch 'project-chip:master' into 26223-add-replaceable-monitor…
May 10, 2023
f579eb7
Merge branch 'master' into 26223-add-replaceable-monitoring-cluster-d…
May 10, 2023
0e0f212
Merge branch 'master' into 26223-add-replaceable-monitoring-cluster-d…
May 11, 2023
108f94f
Update Generated Code
p0fi May 11, 2023
c8dd170
Update Feature Map Name
p0fi May 11, 2023
f2fec0a
Move Line to Nearly Correct Position 😅
p0fi May 11, 2023
f887299
Fix Attribute Definitions
p0fi May 11, 2023
5a757b0
Update Cluster Defines
p0fi May 11, 2023
57dcd4d
Merge branch 'master' into 26223-add-replaceable-monitoring-cluster-d…
p0fi May 11, 2023
1b3ccd5
Fix ZAP File
p0fi May 11, 2023
f82cdf4
Merge branch 'master' of github.com:project-chip/connectedhomeip into…
p0fi May 12, 2023
4a0892a
Merge branch 'project-chip:master' into 26223-add-replaceable-monitor…
May 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests.yaml
p0fi marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ jobs:
src/app/zap-templates/zcl/data-model/draft/electrical-measurement-cluster.xml \
src/app/zap-templates/zcl/data-model/draft/input-output-value-clusters.xml \
src/app/zap-templates/zcl/data-model/draft/onoff-switch-configuration-cluster.xml \
src/app/zap-templates/zcl/data-model/chip/replacable-monitoring-cluster.xml \
"
- name: Build Apps
timeout-minutes: 60
Expand Down
1 change: 1 addition & 0 deletions scripts/rules.matterlint
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ load "../src/app/zap-templates/zcl/data-model/draft/barrier-control-cluster.xml"
load "../src/app/zap-templates/zcl/data-model/draft/electrical-measurement-cluster.xml";
load "../src/app/zap-templates/zcl/data-model/draft/input-output-value-clusters.xml";
load "../src/app/zap-templates/zcl/data-model/draft/onoff-switch-configuration-cluster.xml";
load "../src/app/zap-templates/zcl/data-model/chip/replacable-monitoring-cluster.xml";

all endpoints {
// These attributes follow a different code path and do not have to be
Expand Down
1 change: 1 addition & 0 deletions src/app/zap-templates/zcl/data-model/all.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
<xi:include href="chip/pump-configuration-and-control-cluster.xml" />
<xi:include href="chip/pwm-cluster.xml" />
<xi:include href="chip/relative-humidity-measurement-cluster.xml" />
<xi:include href="chip/replacable-monitoring-cluster.xml.xml" />
andy31415 marked this conversation as resolved.
Show resolved Hide resolved
<xi:include href="chip/scene.xml" />
<xi:include href="chip/software-diagnostics-cluster.xml" />
<xi:include href="chip/switch-cluster.xml" />
Expand Down

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/app/zap-templates/zcl/zcl-with-test-extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
"wake-on-lan-cluster.xml",
"wifi-network-diagnostics-cluster.xml",
"window-covering.xml",
"replacable-monitoring-cluster.xml",
p0fi marked this conversation as resolved.
Show resolved Hide resolved
"matter-devices.xml",
"types/color-control.xml",
"types/door-lock.xml",
Expand Down
1 change: 1 addition & 0 deletions src/app/zap-templates/zcl/zcl.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"pump-configuration-and-control-cluster.xml",
"pwm-cluster.xml",
"relative-humidity-measurement-cluster.xml",
"replacable-monitoring-cluster.xml",
"scene.xml",
"software-diagnostics-cluster.xml",
"switch-cluster.xml",
Expand Down
12 changes: 12 additions & 0 deletions src/app/zap_cluster_list.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"ACCESS_CONTROL_CLUSTER": [],
"ACCOUNT_LOGIN_CLUSTER": [],
"ACTIONS_CLUSTER": [],
"ACTIVATED_CARBON_FILTER_MONITORING": [],
"ADMINISTRATOR_COMMISSIONING_CLUSTER": [],
"ALARM_CLUSTER": [],
"APPLICATION_BASIC_CLUSTER": [],
Expand All @@ -15,6 +16,7 @@
"BINDING_CLUSTER": [],
"BOOLEAN_STATE_CLUSTER": [],
"BRIDGED_DEVICE_BASIC_INFORMATION_CLUSTER": [],
"CERAMIC_FILTER_MONITORING": [],
"CHANNEL_CLUSTER": [],
"CLIENT_MONITORING_CLUSTER": [],
"COLOR_CONTROL_CLUSTER": [],
Expand All @@ -25,18 +27,23 @@
"DIAGNOSTIC_LOGS_CLUSTER": [],
"DOOR_LOCK_CLUSTER": [],
"ELECTRICAL_MEASUREMENT_CLUSTER": [],
"ELECTROSTATIC_FILTER_MONITORING": [],
"ETHERNET_NETWORK_DIAGNOSTICS_CLUSTER": [],
"FAN_CONTROL_CLUSTER": [],
"FAULT_INJECTION_CLUSTER": [],
"FIXED_LABEL_CLUSTER": [],
"FLOW_MEASUREMENT_CLUSTER": [],
"FUEL_TANK_MONITORING": [],
"GENERAL_COMMISSIONING_CLUSTER": [],
"GENERAL_DIAGNOSTICS_CLUSTER": [],
"GROUP_KEY_MANAGEMENT_CLUSTER": [],
"GROUPS_CLUSTER": [],
"HEPA_FILTER_MONITORING": [],
"IAS_ZONE_CLUSTER": [],
"IDENTIFY_CLUSTER": [],
"ILLUMINANCE_MEASUREMENT_CLUSTER": [],
"INK_CARTRIDGE_MONITORING": [],
"IONIZING_FILTER_MONITORING": [],
"KEYPAD_INPUT_CLUSTER": [],
"LEVEL_CONTROL_CLUSTER": [],
"LOCALIZATION_CONFIGURATION_CLUSTER": [],
Expand All @@ -52,6 +59,7 @@
"OTA_BOOTLOAD_CLUSTER": [],
"OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER": [],
"OTA_SOFTWARE_UPDATE_REQUESTOR_CLUSTER": [],
"OZONE_FILTER_MONITORING": [],
"POLL_CONTROL_CLUSTER": [],
"POWER_CONFIG_CLUSTER": [],
"POWER_PROFILE_CLUSTER": [],
Expand All @@ -77,13 +85,17 @@
"TIME_CLUSTER": [],
"TIME_FORMAT_LOCALIZATION_CLUSTER": [],
"TIME_SYNCHRONIZATION_CLUSTER": [],
"TONER_CARTRIDGE_MONITORING": [],
"TRUSTED_ROOT_CERTIFICATES_CLUSTER": [],
"UNIT_LOCALIZATION_CLUSTER": [],
"UNIT_TESTING_CLUSTER": [],
"USER_LABEL_CLUSTER": [],
"UV_FILTER_MONITORING": [],
"WAKE_ON_LAN_CLUSTER": [],
"WATER_TANK_MONITORING": [],
"WIFI_NETWORK_DIAGNOSTICS_CLUSTER": [],
"WINDOW_COVERING_CLUSTER": [],
"ZEOLITE_FILTER_MONITORING": [],
"ZLL_COMMISSIONING_CLUSTER": []
},
"ServerDirectories": {
Expand Down
24 changes: 24 additions & 0 deletions src/controller/data_model/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,30 @@ if (current_os == "android" || build_java_matter_controller) {
"jni/ElectricalMeasurementClient-InvokeSubscribeImpl.cpp",
"jni/UnitTestingClient-ReadImpl.cpp",
"jni/UnitTestingClient-InvokeSubscribeImpl.cpp",
"jni/IonizingFilterMonitoringClient-ReadImpl.cpp",
"jni/IonizingFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/ZeoliteFilterMonitoringClient-ReadImpl.cpp",
"jni/ZeoliteFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/HepaFilterMonitoringClient-ReadImpl.cpp",
"jni/HepaFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/ElectrostaticFilterMonitoringClient-ReadImpl.cpp",
"jni/ElectrostaticFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/WaterTankMonitoringClient-ReadImpl.cpp",
"jni/WaterTankMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/OzoneFilterMonitoringClient-ReadImpl.cpp",
"jni/OzoneFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/InkCartridgeMonitoringClient-ReadImpl.cpp",
"jni/InkCartridgeMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/CeramicFilterMonitoringClient-ReadImpl.cpp",
"jni/CeramicFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/ActivatedCarbonFilterMonitoringClient-ReadImpl.cpp",
"jni/ActivatedCarbonFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/FuelTankMonitoringClient-ReadImpl.cpp",
"jni/FuelTankMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/UvFilterMonitoringClient-ReadImpl.cpp",
"jni/UvFilterMonitoringClient-InvokeSubscribeImpl.cpp",
"jni/TonerCartridgeMonitoringClient-ReadImpl.cpp",
"jni/TonerCartridgeMonitoringClient-InvokeSubscribeImpl.cpp",

# Disable CM cluster table tests until update is done
# https://github.com/project-chip/connectedhomeip/issues/24425
Expand Down
Loading