Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple cluster codes for enums in xmls #26476

Merged

Conversation

andy31415
Copy link
Contributor

#26431 was trying to use the same enum across multiple clusters and it turns out our linter does not support this.

Make the xml parser support this and add unit tests for the support.

@github-actions
Copy link

PR #26476: Size comparison from 4f081a5 to c7f391d

Full report (1 build for cc32xx)
platform target config section 4f081a5 c7f391d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674626 19674626 0 0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

@github-actions
Copy link

PR #26476: Size comparison from 4f081a5 to 1496fd7

Increases (5 builds for bl602, cc32xx, linux, qpg)
platform target config section 4f081a5 1496fd7 change % change
bl602 lighting-app bl602 (read/write) 1354990 1354998 8 0.0
.text 1035976 1035978 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19674626 19674627 1 0.0
linux chip-tool-ipv6only arm64 (read only) 12258652 12259548 896 0.0
.rodata 570096 570208 112 0.0
.text 9915812 9916596 784 0.0
qpg lighting-app qpg6105+debug (read/write) 1169616 1169624 8 0.0
.text 616716 616724 8 0.0
lock-app qpg6105+debug (read/write) 1139484 1139492 8 0.0
.text 586584 586592 8 0.0
Decreases (1 build for bl702)
platform target config section 4f081a5 1496fd7 change % change
bl702 lighting-app bl702+rpc .debug_info 45848902 45848901 -1 -0.0
.text 1038096 1038094 -2 -0.0
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
platform target config section 4f081a5 1496fd7 change % change
bl602 lighting-app bl602 (read/write) 1354990 1354998 8 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035976 1035978 2 0.0
bl602+rpc (read/write) 1401266 1401266 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067332 1067332 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185759 1185759 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1550204 1550204 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488804 488804 0 0.0
.debug_info 40943088 40943088 0 0.0
.debug_line 5301455 5301455 0 0.0
.debug_loc 3424613 3424613 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708223 3708223 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106304 106304 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580786 580786 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 965470 965470 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1273555 1273555 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1706954 1706954 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516776 516776 0 0.0
.debug_info 45848902 45848901 -1 -0.0
.debug_line 5716360 5716360 0 0.0
.debug_loc 3626917 3626917 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133328 4133328 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641456 641456 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1038096 1038094 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674626 19674627 1 0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12258652 12259548 896 0.0
(read/write) 746696 746696 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 570096 570208 112 0.0
.text 9915812 9916596 784 0.0
thermostat-no-ble arm64 (read only) 2528308 2528308 0 0.0
(read/write) 145816 145816 0 0.0
.bss 56392 56392 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 78048 78048 0 0.0
.dynamic 560 560 0 0.0
.got 5472 5472 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 130136 130136 0 0.0
.text 2133440 2133440 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495056 2495056 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457740 1457740 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1176352 1176352 0 0.0
bss 155563 155563 0 0.0
rodata 132752 132752 0 0.0
text 807276 807276 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123444 1123444 0 0.0
bss 154757 154757 0 0.0
rodata 109748 109748 0 0.0
text 778212 778212 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1436080 1436080 0 0.0
bss 135303 135303 0 0.0
rodata 228768 228768 0 0.0
text 777936 777936 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1169616 1169624 8 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 616716 616724 8 0.0
lock-app qpg6105+debug (read/write) 1139484 1139492 8 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586584 586592 8 0.0

@andy31415 andy31415 merged commit fc1b0b9 into project-chip:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants