-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ColorControl] Split (Enhanced)Hue and Saturation transitions #25345
Merged
jmartinez-silabs
merged 8 commits into
project-chip:master
from
jmartinez-silabs:split_CC_transitions
Mar 9, 2023
Merged
[ColorControl] Split (Enhanced)Hue and Saturation transitions #25345
jmartinez-silabs
merged 8 commits into
project-chip:master
from
jmartinez-silabs:split_CC_transitions
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 27, 2023 16:44
jmartinez-silabs
force-pushed
the
split_CC_transitions
branch
from
February 28, 2023 14:23
0c417bc
to
1f89e1b
Compare
PR #25345: Size comparison from 4dd9eda to 1f89e1b Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jepenven-silabs
approved these changes
Feb 28, 2023
… doesn't stop the transition of the other. Some code clean up and changes in computeNewColor16uValue functions lead to some minor changes for XY and Temp transition functions
…ansitions. Fix typos in comments
…e the rate is ignored
…is done. Update some return status to correct error codes
jmartinez-silabs
force-pushed
the
split_CC_transitions
branch
from
March 7, 2023 21:43
e33bb96
to
82f5581
Compare
PR #25345: Size comparison from c69e90d to ee681e4 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 8, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…t-chip#25345) * Split (Enhanced)Hue and Saturation transition so a command changing 1 doesn't stop the transition of the other. Some code clean up and changes in computeNewColor16uValue functions lead to some minor changes for XY and Temp transition functions * reset hue or saturation transtition state on moveHue or moveSaturation stop commands * Restyled by clang-format * Make sure RemainingTime is set to the longest time between two HSV transitions. Fix typos in comments * A moveXYZ rate of 0 is a invalid command except for MoveMode Stop were the rate is ignored * Restyled by clang-format * Add check for command parameters or move them before any other logic is done. Update some return status to correct error codes * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
…t-chip#25345) * Split (Enhanced)Hue and Saturation transition so a command changing 1 doesn't stop the transition of the other. Some code clean up and changes in computeNewColor16uValue functions lead to some minor changes for XY and Temp transition functions * reset hue or saturation transtition state on moveHue or moveSaturation stop commands * Restyled by clang-format * Make sure RemainingTime is set to the longest time between two HSV transitions. Fix typos in comments * A moveXYZ rate of 0 is a invalid command except for MoveMode Stop were the rate is ignored * Restyled by clang-format * Add check for command parameters or move them before any other logic is done. Update some return status to correct error codes * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25040
Hue and Saturation are part of the same color schema (HSV). Previously, a command changing only the hue would stop any active saturation transition and vice versa.
This PR reworks the use of the ColorHueTransitionState and SaturationTransitionState so each transition can continue unaffected by a command only targeted to change one of the two.
Examples
The following commands affect both at the same time:
Per spec
move-hue
,enhanced-move-hue
andmove-saturation
stop (moveMode
) will stop both transitions.https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/ColorControl.adoc#1184-effect-on-receipt
Some code clean up and changes in computeNewColor16uValue functions lead to some minor changes for XY and Temperature transition functions without affecting the behaviour.
Tested with chip-tool manually and with Test_TC_CC_X_Y (all of them) on EFR32 lighting-app
CI will also validate with the test suite.