Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [ColorControl] Step commands with StepMode = 0 should return an error #25589

Closed
jmartinez-silabs opened this issue Mar 9, 2023 · 0 comments · Fixed by #25592
Closed
Assignees

Comments

@jmartinez-silabs
Copy link
Member

Reproduction steps

Part of the following PR #25345 fixed a few error codes returned and also the timing at which they were returned (as early as possible)

It was pointed out that a StepMode Stop is implemented with similar behaviour to MoveMode Stop and that there is, however, no StepMode Stop in the spec.
#25345 (comment)

StepMode=0 is a reserved value with no current definition. Any step command with a StepMode of 0 should return INVALID_COMMAND

To reproduce the issue send
./chip-tool colorcontrol step-hue 0 200 200 1 1 <node_id> <endpoint>
the command will return a success. It should return a failure

Bug prevalence

Always

GitHub hash of the SDK that was being used

a2f83a9

Platform

core

Platform Version(s)

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant