Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColorControl] Step mode Stop doesn't exist. return error on a stepmode = 0 #25592

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

jmartinez-silabs
Copy link
Member

Fixes #25589
There is a StepMode STOP behaviour implemented in color control step commands but this isn't defined by the spec.

remove that code and return INVALID_COMMAND if a stepmode value != to 1 or 3 is received

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25592: Size comparison from 82da16f to 64c4787

Increases (1 build for cc32xx)
platform target config section 82da16f 64c4787 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267469 20267470 1 0.0
Full report (1 build for cc32xx)
platform target config section 82da16f 64c4787 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267470 1 0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@yufengwangca yufengwangca merged commit 52b1e62 into project-chip:master Mar 10, 2023
@jmartinez-silabs jmartinez-silabs deleted the fix/cc_step_cmd branch March 10, 2023 12:38
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [ColorControl] Step commands with StepMode = 0 should return an error
3 participants