Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate transitions for hue and saturation in color control #25040

Closed
bzbarsky-apple opened this issue Feb 14, 2023 · 2 comments · Fixed by #25345
Closed

Use separate transitions for hue and saturation in color control #25040

bzbarsky-apple opened this issue Feb 14, 2023 · 2 comments · Fixed by #25345
Assignees
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation

Comments

@bzbarsky-apple
Copy link
Contributor

Right now, a move on the hue will terminate an in-progress move on the saturation, and vice versa.

This is pretty unfortunate, from a client's point of view, and has no basis in the spec as far as I can tell. We should probably consider just doing separate transitions for the two (but allow the MoveToHueAndSaturation/etc commands to combine into a single transition).

One possible approach: we could support doing up to two transitions per endpoint, where each transition is transitioning hue, or saturation, or both. When a new transition wants to start, there are three cases:

  1. It wants to transition both; cancel any existing transitions.
  2. It wants to transition hue only. Cancel any existing hue-only transition, convert any existing hue-and-saturation transition to saturation-only.
  3. It wants to transition saturation only. Cancel any existing saturation-only transition, convert any existing hue-and-saturation transition to hue-only.

@jmartinez-silabs thoughts?

@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation app-clusters Application cluster work labels Feb 14, 2023
@jmartinez-silabs
Copy link
Member

@bzbarsky-apple I agree, separating the two gives a better user experience and more flexibility and I don't see any cons either. It is fairly straightforward to implement.

Note that hue and enhanced hue will be grouped together has the same transition.

@bzbarsky-apple
Copy link
Contributor Author

Yep, there's only one hue to transition, so enhanced hue and hue have to use the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants