DoorLock: Fix incorrect CredentialIndex on LockOperation events initated remotely (#24985) #24986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #24986: Size comparison from 5ad70f6 to 6e894d6 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Feb 10, 2023
| @@ -1743,7 +1743,7 @@ bool DoorLockServer::findUserIndexByCredential(chip::EndpointId endpointId, Cred | |||
| if (credentialInfo.credentialData.data_equal(credentialData)) | |||
| { | |||
| userIndex = i; | |||
| credentialIndex = i; | |||
| credentialIndex = credential.CredentialIndex; | |||
There was a problem hiding this comment.
Nice catch, but can we please add a YAML test for this?
There was a problem hiding this comment.
YAML test has been updated.
There was a problem hiding this comment.
No, it hasn't. What was updated was:
- One of the certification tests. Those should not get updated without corresponding test plan changes.
- Not one of the tests that actually runs anything automated. What should have been done is either updating src/app/tests/suites/DL_UsersAndCredentials.yaml or adding a new test.
There was a problem hiding this comment.
Filed #24992 to track this....
|
PR #24986: Size comparison from 5ad70f6 to 17bb586 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
yufengwangca
approved these changes
Feb 11, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ted remotely (project-chip#24985) (project-chip#24986) * DoorLock: Fix incorrect CredentialIndex on LockOperation events initiated remotely (project-chip#24985) * Update YAML tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LockOperation events produced in response to a Lock or Unlock operation initiated via Matter (Remote) include the incorrect credentialIndex in the events.
Fixes #24985