Address review comments from PR 24986

[bzbarsky-apple]

Review comments there were not addressed before it was merged. See #24986 (comment)

Specific actions:

1. Undo the changes to the certification tests that were not accompanied by test plan changes.
2. Add the test that was asked for in the review comments.

@jrhees-cae @yufengwangca

[bzbarsky-apple]

Of course ideally the test plans would in fact be modified so they catch this issue and then the test would be one of the certification tests.... @cjandhyala

[cjandhyala]

@jrhees-cae Could you update the test plans, if the expected outcome in a TC is modified , we must execute the TC in a TE or SVE.

[jrhees-cae]

@cjandhyala I looked at the test plan document related to this test case (DRLK-10) and there aren't any needed changes. The test plan does not specifically call out what UserIndex or CredentialIndex to use for the test (the only thing I changed was the credentialIndex used during the steps).

[cjandhyala]

@jrhees-cae Ok, I see verification steps are updated to verify certain expected values, since the expected outcome is changed in some of the steps in the script, will need to run this script in a TE/SVE.

I see the script is updated to verify the below values.

1. CredentialIndex: 1 is changed to CredentialIndex: 2
2. verify "UserIndex and Credentials are set to null"

Also I see that expected outcome in one of the step is 'DataIndex is set to 4' but in the actual verification that value is not verified. Is that fine ?

[jrhees-cae]

Yes that is fine. It does not need to be verified.

…

On Tue, Feb 14, 2023, 4:52 PM cjandhyala ***@***.***> wrote: @jrhees-cae <https://github.com/jrhees-cae> Ok, I see verification steps are updated to verify certain expected values, since the expected outcome is changed in some of the steps in the script, will need to run this script in a TE/SVE. I see the script is updated to verify the below values. 1. CredentialIndex: 1 is changed to CredentialIndex: 2 2. verify "UserIndex and Credentials are set to null" Also I see that expected outcome in one of the step is 'DataIndex is set to 4' but in the actual verification that value is not verified. Is that fine ? — Reply to this email directly, view it on GitHub <#24992 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOU6QVX5UFMKXKNMBT6GJHTWXQLCTANCNFSM6AAAAAAUYNNMVE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bzbarsky-apple]

Fixed by #25030