Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests in DL_LockUnlock yaml to validate Lock/Unlock credentials and userIndex (#24992) #25030

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Add tests in DL_LockUnlock yaml to validate Lock/Unlock credentials and userIndex (#24992) #25030

merged 3 commits into from
Feb 14, 2023

Conversation

jrhees-cae
Copy link
Contributor

Add tests in DL_LockUnlock yaml to:

  • verify correct CredentialIndex on LockOperation events
  • verify NULL UserIndex and Credentials on LockOperation errors when using invalid PINCodes

Fixes #24992

@jrhees-cae
Add tests in DL_LockUnlock yaml: (project-chip#24992)
30760d1 
- verify correct CredentialIndex on LockOperation events
- verify NULL UserIndex and Credentials on LockOperation errors when using invalid PINCodes
Fixes project-chip#24992
bzbarsky-apple
bzbarsky-apple reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bzbarsky-apple
Copy link
Contributor

@jrhees-cae Note restyled failure.

@github-actions
Copy link

PR #25030: Size comparison from e7528bc to 334bf12

Decreases (1 build for cc32xx)
platform target config section e7528bc 334bf12 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180782 20180781 -1 -0.0
Full report (1 build for cc32xx)
platform target config section e7528bc 334bf12 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180782 20180781 -1 -0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@github-actions
Copy link

PR #25030: Size comparison from e7528bc to 697a18f

Increases (1 build for cc32xx)
platform target config section e7528bc 697a18f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180782 20180783 1 0.0
.debug_line 2649926 2649933 7 0.0
Full report (1 build for cc32xx)
platform target config section e7528bc 697a18f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180782 20180783 1 0.0
.debug_line 2649926 2649933 7 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking testing improvements.

@woody-apple woody-apple enabled auto-merge (squash) February 14, 2023 16:56
@woody-apple woody-apple merged commit d3d7df9 into project-chip:master Feb 14, 2023
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 22, 2023
Closed
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@jrhees-cae @restyled-commits
Add tests in DL_LockUnlock yaml to validate Lock/Unlock credentials a…
5e969c4 
…nd userIndex (project-chip#24992) (project-chip#25030)

* Add tests in DL_LockUnlock yaml: (project-chip#24992)
- verify correct CredentialIndex on LockOperation events
- verify NULL UserIndex and Credentials on LockOperation errors when using invalid PINCodes
Fixes project-chip#24992

* Restyled by prettier-yaml

* Exclude DL_LockUnlock yaml test from Darwin (waiting on readEvent support)

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@kcoppock kcoppock Awaiting requested review from kcoppock

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin examples fast track review - pending tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address review comments from PR 24986
4 participants
@jrhees-cae @bzbarsky-apple @woody-apple @restyled-commits