-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong datamodel in Level Cluster #23656
Fixed wrong datamodel in Level Cluster #23656
Conversation
f459b99
to
981ea28
Compare
0a4b0fb
to
c6a4626
Compare
PR #23656: Size comparison from 8c09eae to c6a4626 Increases (17 builds for bl602, bl702, cc13x2_26x2, k32w, linux, nrfconnect, qpg, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (26 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
c6a4626
to
c698ad4
Compare
PR #23656: Size comparison from 8c09eae to c698ad4 Increases above 0.2%:
Increases (26 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for cc13x2_26x2, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
c698ad4
to
e159092
Compare
PR #23656: Size comparison from 8c09eae to e159092 Increases above 0.2%:
Increases (27 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@jsloth - this needs conflict resolution (zap regen) |
e159092
to
babf649
Compare
PR #23656: Size comparison from 3fa2104 to babf649 Increases above 0.2%:
Increases (21 builds for bl602, bl702, k32w, linux, nrfconnect, qpg, telink)
Decreases (1 build for telink)
Full report (30 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
babf649
to
37ff461
Compare
PR #23656: Size comparison from b568009 to 37ff461 Increases above 0.2%:
Increases (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc13x2_26x2, esp32, k32w)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Build failure seems unrelated to my changes. |
37ff461
to
27f1302
Compare
PR #23656: Size comparison from 95d337c to 27f1302 Increases above 0.2%:
Increases (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for cc13x2_26x2, esp32)
Full report (46 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Added: Cluster code to LevelControlOptions Bitmap Fixed: LevelControlOptions was defined wrong as Enum, Changed it to a Bitmap Changed/Fixed: Level Cluster Attribute 15 (OPTIONS) datatype from BITMAP8 to LevelControlOptions (Bitmap8) type Changed/Fixed: Level Command datatype for 'OptionsMask' and 'OptionsOverride' from BITMAP8 to LevelControlOptions
27f1302
to
0d0da5c
Compare
PR #23656: Size comparison from 54d8dd0 to 0d0da5c Increases above 0.2%:
Increases (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I created #23686 to fix that timeout the Darwin job is hitting.... |
Added: Cluster code to LevelControlOptions Bitmap
Fixed: LevelControlOptions was defined wrong as Enum, Changed it to a Bitmap
Changed/Fixed: Level Cluster Attribute 15 (OPTIONS) datatype from BITMAP8 to LevelControlOptions (Bitmap8) type
Changed/Fixed: Level Command datatype for 'OptionsMask' and 'OptionsOverride' from BITMAP8 to LevelControlOptions