Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Occupancy Sensing cluster datamodel (XML) use anonymoous bitmap and enum types in attributes #24342

Closed
jsloth opened this issue Jan 10, 2023 · 2 comments · Fixed by #24363

Comments

@jsloth
Copy link
Contributor

jsloth commented Jan 10, 2023

The data-model (XML) for Occupancy Sensing use anonymous BITMAP and ENUM types in attributes:

<attribute side="server" code="0x0000" define="OCCUPANCY" type="BITMAP8" min="0x00" max="0x01" writable="false" reportable="true" optional="false">occupancy</attribute>
<attribute side="server" code="0x0001" define="OCCUPANCY_SENSOR_TYPE" type="ENUM8" min="0x00" max="0xFE" writable="false" optional="false">occupancy sensor type</attribute>
<attribute side="server" code="0x0002" define="OCCUPANCY_SENSOR_TYPE_BITMAP" type="BITMAP8" min="0x00" max="0x07" writable="false" optional="false">occupancy sensor type bitmap</attribute>

Should use following types instead:

<bitmap name="Occupancy" type="BITMAP8">

<enum name="OccupancySensorType" type="ENUM8">

<bitmap name="OccupancySensorTypeBitmap" type="BITMAP8">

This issue is similar to #24075 and #23656

@bzbarsky-apple
Copy link
Contributor

This needs to be fixed in the spec, then the fix can be followed in the SDK. That way the names will get feedback before being shipped as API to consumers.

@bzbarsky-apple
Copy link
Contributor

@jsloth Please raise spec issues as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants