Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] ColorControl cluster datamodel (XML) use anonymous bitmap types in commands #24075

Closed
jsloth opened this issue Dec 14, 2022 · 2 comments
Closed
Labels
data model spec Mismatch between spec and implementation stale Stale issue or PR

Comments

@jsloth
Copy link
Contributor

jsloth commented Dec 14, 2022

The data-model (XML) for Color Control use anonymous BITMAP8 types for OptionsMask and OptionsOverride in all commands.

The ColorControlOptions bitmap type, which is declared wrong in the types.xml (as enum, should be bitmap instead):

<enum name="ColorControlOptions" type="BITMAP8">

should be used in following commands:

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

<arg name="OptionsMask" type="BITMAP8"/>
<arg name="OptionsOverride" type="BITMAP8"/>

A similar issue is fixed in LevelControl #23656, and the solution to this issue may be similar.

@stale
Copy link

stale bot commented Jun 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale
Copy link

stale bot commented Aug 11, 2023

This stale issue has been automatically closed. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data model spec Mismatch between spec and implementation stale Stale issue or PR
Projects
Development

No branches or pull requests

3 participants