Fixed wrong datamodel on Occupancy Sensing Cluster #24363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha and
emargolis
|
That sounds like an excellent plan. (And I approved the spec PR already.) |
jsloth
force-pushed
the
bugfix/occupancy_sensing_typefix
branch
from
a28869c to
592af9d
Compare
github-actions
bot
removed
documentation
pullapprove
bot
requested review from
amitnj,
CodeChronos928,
jmeg-sfy,
kkasperczyk-no and
pjzander-signify
|
I have updated the PR based on the recent spec changes, that was merged yesterday. |
|
PR #24363: Size comparison from a6d2883 to 592af9d Increases (1 build for k32w)
Full report (3 builds for k32w)
|
bzbarsky-apple
approved these changes
Feb 16, 2023
src/app/clusters/occupancy-sensor-server/occupancy-sensor-server.cpp
Outdated
Show resolved
Hide resolved
|
@jsloth Note the infineon build error. |
jsloth
force-pushed
the
bugfix/occupancy_sensing_typefix
branch
from
592af9d to
920f9f1
Compare
Updated occupancy-sensor-server code to comply with changes Updated examples/lighting-app/infineon/cyw30739/src/ButtonHandler.cpp
jsloth
force-pushed
the
bugfix/occupancy_sensing_typefix
branch
from
920f9f1 to
37efbde
Compare
|
If this this PR is acceptable, I would kindly ask if it can be merged soon, as we are depending on it for an upcoming release🙂 |
jmartinez-silabs
approved these changes
Feb 16, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Feb 16, 2023
…itmaps. These were added in project-chip#24363
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this pull request
Mar 15, 2023
…itmaps. (#25117) These were added in project-chip/connectedhomeip#24363
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this pull request
Mar 15, 2023
…itmaps. (#25117) These were added in project-chip/connectedhomeip#24363
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Updated Occupancy Cluster XML according to spec * Zap generated files * Updated code to comply with changes Updated occupancy-sensor-server code to comply with changes Updated examples/lighting-app/infineon/cyw30739/src/ButtonHandler.cpp
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…itmaps. (project-chip#25117) These were added in project-chip#24363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #24342 Occupancy Sensing Cluster using anonymous bitmap and enum types, now it uses the correctly defined types (according to spec)