Remove un-named callbacks and raw integers from Darwin framework API. #23364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22551
branch
from
fb91aa6 to
ffb836c
Compare
|
PR #23364: Size comparison from 3b81f3f to ffb836c Increases (4 builds for esp32, psoc6, telink)
Decreases (4 builds for esp32, k32w, psoc6, qpg)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22551
branch
from
ffb836c to
5cdade6
Compare
|
PR #23364: Size comparison from 51a5082 to 5cdade6 Increases (8 builds for bl602, bl702, esp32, telink)
Decreases (3 builds for esp32, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22551
branch
from
5cdade6 to
8f5fb03
Compare
|
PR #23364: Size comparison from 51a5082 to 8f5fb03 Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22551
branch
from
8f5fb03 to
3cd3121
Compare
|
PR #23364: Size comparison from d65a207 to 3cd3121 Increases (6 builds for bl602, bl702, esp32, k32w, psoc6, telink)
Decreases (5 builds for bl702, esp32, k32w, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Oct 27, 2022
ksperling-apple
approved these changes
Oct 28, 2022
anush-apple
approved these changes
Oct 28, 2022
|
PR #23364: Size comparison from d65a207 to 47f8e99 Increases above 0.2%:
Increases (11 builds for bl602, bl702, esp32, k32w, nrfconnect, psoc6, qpg)
Decreases (2 builds for bl702, esp32)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible.
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22551
branch
from
47f8e99 to
cfa17ab
Compare
|
PR #23364: Size comparison from e2e4926 to cfa17ab Increases (3 builds for bl702, esp32, k32w)
Decreases (4 builds for psoc6, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
|
Fast-tracking platform-specific change with platform owner approval. |
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23364) Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible. * Address review comments.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23364) Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes.
This is a re-landing of PR #22551 but modified to preserve the old APIs.
The header changes not accompanied by backwards-compat shims are OK for the following reasons: