Skip to content

Commit

Permalink
[python tests] decode shell output as UTF-8 (#26783)
Browse files Browse the repository at this point in the history
If tests are run on a platform which is returning special characters
(e.g. date with months which contain an umlaut) runnig the test fails:

```
  File "/home/sag/projects/project-chip/connectedhomeip/./scripts/tests/run_python_test.py", line 95, in main
    print(subprocess.check_output(["ls -l"], shell=True).decode('us-ascii'))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1553: ordinal not in range(128)
```

Decode the output using UTF-8 by default.
  • Loading branch information
agners authored and pull[bot] committed Aug 10, 2023
1 parent 854375c commit 2392828
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/tests/run_java_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def main(app: str, app_args: str, tool_path: str, tool_cluster: str, tool_args:
raise Exception("Failed to remove /tmp/chip* for factory reset.")

print("Contents of test directory: %s" % os.getcwd())
print(subprocess.check_output(["ls -l"], shell=True).decode('us-ascii'))
print(subprocess.check_output(["ls -l"], shell=True).decode('utf-8'))

# Remove native app KVS if that was used
kvs_match = re.search(r"--KVS (?P<kvs_path>[^ ]+)", app_args)
Expand Down
2 changes: 1 addition & 1 deletion scripts/tests/run_python_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def main(app: str, factoryreset: bool, app_args: str, script: str, script_args:
raise Exception("Failed to remove /tmp/chip* for factory reset.")

print("Contents of test directory: %s" % os.getcwd())
print(subprocess.check_output(["ls -l"], shell=True).decode('us-ascii'))
print(subprocess.check_output(["ls -l"], shell=True).decode('utf-8'))

# Remove native app KVS if that was used
kvs_match = re.search(r"--KVS (?P<kvs_path>[^ ]+)", app_args)
Expand Down

0 comments on commit 2392828

Please sign in to comment.