Remove un-named callbacks and raw integers from Darwin framework API. #22551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. Fixes project-chip#18020 Addresses part of project-chip#22420
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
vivien-apple
approved these changes
Sep 12, 2022
src/darwin/Framework/Matter.xcodeproj/xcshareddata/xcschemes/Matter Framework Tests.xcscheme
Show resolved
Hide resolved
|
PR #22551: Size comparison from e4c075f to 4fe1aac Increases (2 builds for cc13x2_26x2, psoc6)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Fast tracking platform fix with owner approval. |
andy31415
approved these changes
Sep 12, 2022
|
PR #22551: Size comparison from e4c075f to 2b384a8 Increases (2 builds for cc13x2_26x2, esp32)
Decreases (9 builds for bl602, cc13x2_26x2, k32w, nrfconnect, psoc6, qpg, telink)
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…project-chip#22551) * Remove un-named callbacks and raw integers from Darwin framework API. Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. Fixes project-chip#18020 Addresses part of project-chip#22420 * Address review comment.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 27, 2022
…project-chip#22551) Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 27, 2022
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 27, 2022
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 27, 2022
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 27, 2022
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 27, 2022
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 28, 2022
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible.
bzbarsky-apple
added a commit
that referenced
this pull request
Oct 28, 2022
…#23364) Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR #22551 but modified to preserve the old APIs, plus PR #22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible. * Address review comments.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23364) Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible. * Address review comments.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23364) Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes. This is a re-landing of PR project-chip#22551 but modified to preserve the old APIs, plus PR project-chip#22843 (the parts that had not relanded yet). The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * The change to MTRAttributeCacheContainer.h is both source and binary compatible. * MTRAttributeCacheContainer_Internal.h is not public API. * The change to MTRBaseDevice's subscribeAttributeWithEndpointId is both source and binary compatible. * The change to MTRBaseDevice's deregisterReportHandlersWithClientQueue is both source and binary compatible. * The change to sharedControllerWithId in MTRDeviceController+XPC.h is both source and binary compatible. * The change to getAnyDeviceControllerWithCompletion in MTRDeviceController+XPC.h is both source and binary compatible. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDevice_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTROTAProviderDelegate.h are both source and binary compatible. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to typedefs for all the callbacks and using NSNumber for numbers, except in MTRDeviceController (and the XPC version), which will need some more complicated changes.
Addresses part of #22420
Review notes:
MTRClustersObjc_internal.hwas unused, and was not actually being generated, in spite of living in zap-generated.Issue Being Resolved
Change overview
See above.