-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some 1.0-only backwards-compat hacks from chip-tool. #23094
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-remove-1.0-hacks
Oct 11, 2022
Merged
Remove some 1.0-only backwards-compat hacks from chip-tool. #23094
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-remove-1.0-hacks
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
October 10, 2022 15:36
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
October 10, 2022 15:36
PR #23094: Size comparison from f6d585a to 504d855 Increases (5 builds for cc13x2_26x2, psoc6, qpg, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
chip-tool-remove-1.0-hacks
branch
from
October 10, 2022 17:33
504d855
to
49409e6
Compare
msandstedt
approved these changes
Oct 10, 2022
PR #23094: Size comparison from 3b96652 to 49409e6 Increases (5 builds for bl602, bl702, telink)
Decreases (2 builds for linux, qpg)
Full report (14 builds for bl602, bl702, k32w, linux, qpg, telink)
|
These were just there to avoid changing some command lines from SVE2 to 1.0, but at this point those should be updated as needed. Fixes project-chip#22507 Fixes project-chip#22341
bzbarsky-apple
force-pushed
the
chip-tool-remove-1.0-hacks
branch
from
October 10, 2022 22:32
49409e6
to
4e023c9
Compare
PR #23094: Size comparison from 119cdf5 to 4e023c9 Increases (6 builds for bl602, bl702, cc13x2_26x2, esp32, telink)
Decreases (4 builds for cc13x2_26x2, linux, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 11, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Oct 12, 2022
…chip#23094) These were just there to avoid changing some command lines from SVE2 to 1.0, but at this point those should be updated as needed. Fixes project-chip#22507 Fixes project-chip#22341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were just there to avoid changing some command lines from SVE2 to 1.0, but at this point those should be updated as needed.
Fixes #22507
Fixes #22341