Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After 1.0, remove the color-temperature hack in chip-tool #22341

Closed
bzbarsky-apple opened this issue Sep 1, 2022 · 0 comments · Fixed by #23094
Closed

After 1.0, remove the color-temperature hack in chip-tool #22341

bzbarsky-apple opened this issue Sep 1, 2022 · 0 comments · Fixed by #23094
Assignees
@bzbarsky-apple
Labels
v1.1

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

ColorTemperatureMireds was mis-named as ColorTemperature for a while. #22237 fixed that, but added a hack in chip-tool to keep the old name around too for attribute read and subscribe, to avoid breaking cert verification steps.

Proposed Solution

After 1.0, remove the hack.
@bzbarsky-apple bzbarsky-apple self-assigned this Sep 2, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 10, 2022
@bzbarsky-apple
Remove some 1.0-only backwards-compat hacks from chip-tool.
504d855 
These were just there to avoid changing some command lines from SVE2
to 1.0, but at this point those should be updated as needed.

Fixes project-chip#22507
Fixes project-chip#22341
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 10, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 10, 2022
@bzbarsky-apple
Remove some 1.0-only backwards-compat hacks from chip-tool.
49409e6 
These were just there to avoid changing some command lines from SVE2
to 1.0, but at this point those should be updated as needed.

Fixes project-chip#22507
Fixes project-chip#22341
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 10, 2022
@bzbarsky-apple
Remove some 1.0-only backwards-compat hacks from chip-tool.
4e023c9 
These were just there to avoid changing some command lines from SVE2
to 1.0, but at this point those should be updated as needed.

Fixes project-chip#22507
Fixes project-chip#22341
andy31415 pushed a commit that referenced this issue Oct 11, 2022
@bzbarsky-apple
Remove some 1.0-only backwards-compat hacks from chip-tool. (#23094)
f366165 
These were just there to avoid changing some command lines from SVE2
to 1.0, but at this point those should be updated as needed.

Fixes #22507
Fixes #22341
selissia pushed a commit to selissia/connectedhomeip that referenced this issue Oct 12, 2022
@bzbarsky-apple @selissia
Remove some 1.0-only backwards-compat hacks from chip-tool. (project-…
bc7c18e 
…chip#23094)

These were just there to avoid changing some command lines from SVE2
to 1.0, but at this point those should be updated as needed.

Fixes project-chip#22507
Fixes project-chip#22341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
v1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove some 1.0-only backwards-compat hacks from chip-tool. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple