Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] Fix Matter framework delegates to pass the delegating object as the first arg to their methods #22682

Merged
merged 1 commit into from
Sep 16, 2022
Merged

[Darwin] Fix Matter framework delegates to pass the delegating object as the first arg to their methods #22682

merged 1 commit into from
Sep 16, 2022

Conversation

jtung-apple
Copy link
Contributor

Issue Being Resolved

Change overview

Changed MTRDeviceAttestationDelegate and MTRDeviceControllerDelegate to pass the delegating object as the first argument, as is common for delegate callbacks.

@woody-apple woody-apple enabled auto-merge (squash) September 15, 2022 19:35
@github-actions
Copy link

github-actions bot commented Sep 15, 2022 •
edited
Loading

PR #22682: Size comparison from bae0bc7 to e68f585

Increases (4 builds for bl602, bl702, cyw30739, telink)
platform target config section bae0bc7 e68f585 change % change
bl602 lighting-app bl602 .text 1067650 1067654 4 0.0
bl702 lighting-app bl702 .debug_info 37894051 3789405 1 0.0
.text 957198 957200 2 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543498 543506 8 0.0
.app_xip_area 425180 425188 8 0.0
telink lighting-app tlsr9518adk80d text 592870 592872 2 0.0
Decreases (4 builds for bl602, bl702, nrfconnect, psoc6)
platform target config section bae0bc7 e68f585 change % change
bl602 lighting-app bl602+rpc (read/write) 1458410 1458402 -8 -0.0
.text 1099258 1099254 -4 -0.0
bl702 lighting-app bl702+rpc .debug_info 41800622 41800621 -1 -0.0
.text 1030902 1030900 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160863 1160847 -16 -0.0
text 803252 803248 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26552195 26552194 -1 -0.0
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section bae0bc7 e68f585 change % change
bl602 lighting-app bl602 (read/write) 1412934 1412934 0 0.0
.bss 121585 121585 0 0.0
.data 9824 9824 0 0.0
.text 1067650 1067654 4 0.0
bl602+rpc (read/write) 1458410 1458402 -8 -0.0
.bss 129017 129017 0 0.0
.data 10208 10208 0 0.0
.text 1099258 1099254 -4 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188443 1188443 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506733 1506733 0 0.0
.debug_aranges 133072 133072 0 0.0
.debug_frame 486352 486352 0 0.0
.debug_info 37894051 3789405 1 0.0
.debug_line 5253364 5253364 0 0.0
.debug_loc 3363571 3363571 0 0.0
.debug_ranges 360232 360232 0 0.0
.debug_str 3455343 3455343 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116504 116504 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957198 957200 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284371 1284371 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644312 1644312 0 0.0
.debug_aranges 140576 140576 0 0.0
.debug_frame 511728 511728 0 0.0
.debug_info 41800622 41800621 -1 -0.0
.debug_line 5627903 5627903 0 0.0
.debug_loc 3556239 3556239 0 0.0
.debug_ranges 382688 382688 0 0.0
.debug_str 3851310 3851310 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030902 1030900 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676515 676515 0 0.0
(read/write) 174900 174900 0 0.0
.bss 74308 74308 0 0.0
.data 3380 3380 0 0.0
.rodata 89595 89595 0 0.0
.text 586608 586608 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640771 640771 0 0.0
(read/write) 157876 157876 0 0.0
.bss 73580 73580 0 0.0
.data 3380 3380 0 0.0
.rodata 78747 78747 0 0.0
.text 561704 561704 0 0.0
lock-ftd LP_CC2652R7 (read only) 678063 678063 0 0.0
(read/write) 163672 163672 0 0.0
.bss 71516 71516 0 0.0
.data 3304 3304 0 0.0
.rodata 77295 77295 0 0.0
.text 600288 600288 0 0.0
lock-mtd LP_CC2652R7 (read only) 661891 661891 0 0.0
(read/write) 175532 175532 0 0.0
.bss 67204 67204 0 0.0
.data 3304 3304 0 0.0
.rodata 103131 103131 0 0.0
.text 558280 558280 0 0.0
pump-app LP_CC2652R7 (read only) 687299 687299 0 0.0
(read/write) 155140 155140 0 0.0
.bss 71452 71452 0 0.0
.data 3296 3296 0 0.0
.rodata 90563 90563 0 0.0
.text 596252 596252 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671783 0 0.0
(read/write) 170768 170768 0 0.0
.bss 71564 71564 0 0.0
.data 3292 3292 0 0.0
.rodata 86119 86119 0 0.0
.text 585184 585184 0 0.0
shell LP_CC2652R7 (read only) 667518 667518 0 0.0
(read/write) 179408 179408 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 86302 86302 0 0.0
.text 580900 580900 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587458 587458 0 0.0
.app_xip_area 464116 464116 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594514 594514 0 0.0
.app_xip_area 465844 465844 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543498 543506 8 0.0
.app_xip_area 425180 425188 8 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110784 1110784 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 972360 972360 0 0.0
BRD4161A+rpc (read/write) 973620 973620 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 820504 820504 0 0.0
BRD4161A+rs911x (read/write) 1004032 1004032 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832780 832780 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151492 1151492 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 997152 997152 0 0.0
window-app BRD4161A (read/write) 1102832 1102832 0 0.0
.bss 137780 137780 0 0.0
.data 2096 2096 0 0.0
.text 962936 962936 0 0.0
k32w light k32w0+release (read/write) 650004 650004 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574496 574496 0 0.0
lock k32w0+release (read/write) 706960 706960 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630996 630996 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10348916 10348916 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503220 503220 0 0.0
.text 8191748 8191748 0 0.0
thermostat-no-ble arm64 (read only) 2368828 2368828 0 0.0
(read/write) 142545 142545 0 0.0
.bss 55249 55249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 76704 76704 0 0.0
.dynamic 560 560 0 0.0
.got 5096 5096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141748 141748 0 0.0
.text 1987984 1987984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455808 2455808 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418452 1418452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182191 1182191 0 0.0
bss 143633 143633 0 0.0
rodata 144224 144224 0 0.0
text 815384 815384 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160863 1160847 -16 -0.0
bss 142860 142860 0 0.0
rodata 135816 135816 0 0.0
text 803252 803248 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841968 841968 0 0.0
(read/write) 1744324 1744324 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229321 1229321 0 0.0
.debug_aranges 111784 111784 0 0.0
.debug_frame 373216 373216 0 0.0
.debug_info 26815347 26815347 0 0.0
.debug_line 3669159 3669159 0 0.0
.debug_loc 3582858 3582858 0 0.0
.debug_ranges 340664 340664 0 0.0
.debug_str 3438974 3438974 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569356 569356 0 0.0
.symtab 421168 421168 0 0.0
.text 1544560 1544560 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842704 842704 0 0.0
(read/write) 1686964 1686964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221120 1221120 0 0.0
.debug_aranges 111256 111256 0 0.0
.debug_frame 376296 376296 0 0.0
.debug_info 26552195 26552194 -1 -0.0
.debug_line 3689875 3689875 0 0.0
.debug_loc 3570495 3570495 0 0.0
.debug_ranges 339280 339280 0 0.0
.debug_str 3427987 3427987 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533445 533445 0 0.0
.symtab 407600 407600 0 0.0
.text 1487936 1487936 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850896 850896 0 0.0
(read/write) 1605540 1605540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055176 1055176 0 0.0
.debug_aranges 103464 103464 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22017630 22017630 0 0.0
.debug_line 3259887 3259887 0 0.0
.debug_loc 3268799 3268799 0 0.0
.debug_ranges 304608 304608 0 0.0
.debug_str 3233519 3233519 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469822 469822 0 0.0
.symtab 376048 376048 0 0.0
.text 1414704 1414704 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845864 845864 0 0.0
(read/write) 1643148 1643148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062595 1062595 0 0.0
.debug_aranges 104136 104136 0 0.0
.debug_frame 349448 349448 0 0.0
.debug_info 22396951 22396951 0 0.0
.debug_line 3268581 3268581 0 0.0
.debug_loc 3308657 3308657 0 0.0
.debug_ranges 307952 307952 0 0.0
.debug_str 3260974 3260974 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476025 476025 0 0.0
.symtab 379232 379232 0 0.0
.text 1447280 1447280 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130924 1130924 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 578020 578020 0 0.0
lock-app qpg6105+debug (read/write) 1101888 1101888 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548988 548988 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813868 813868 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574710 574710 0 0.0
lighting-app tlsr9518adk80d (read/write) 835824 835824 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592870 592872 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843916 843916 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 599112 599112 0 0.0

@jtung-apple jtung-apple force-pushed the issue-22607-darwin-delegate-api-review branch from e68f585 to 68d2880 Compare September 16, 2022 00:20
@github-actions
Copy link

github-actions bot commented Sep 16, 2022 •
edited
Loading

PR #22682: Size comparison from e62b0f1 to 68d2880

Increases (8 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section e62b0f1 68d2880 change % change
bl602 lighting-app bl602 .text 1067236 1067240 4 0.0
bl602+rpc (read/write) 1457986 1457994 8 0.0
.text 1098840 1098844 4 0.0
bl702 lighting-app bl702 .debug_info 37891397 37891398 1 0.0
.text 956782 956784 2 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 640635 640643 8 0.0
.text 561568 561576 8 0.0
esp32 all-clusters-app c3devkit (read/write) 1788038 1788046 8 0.0
.flash.rodata 257608 257616 8 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22013489 22013490 1 0.0
telink light-switch-app tlsr9518adk80d text 574570 574572 2 0.0
ota-requestor-app tlsr9518adk80d text 598974 598976 2 0.0
Decreases (2 builds for cyw30739, efr32)
platform target config section e62b0f1 68d2880 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543314 543306 -8 -0.0
.app_xip_area 424996 424988 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read/write) 973452 973436 -16 -0.0
.text 820336 820320 -16 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section e62b0f1 68d2880 change % change
bl602 lighting-app bl602 (read/write) 1412518 1412518 0 0.0
.bss 121585 121585 0 0.0
.data 9824 9824 0 0.0
.text 1067236 1067240 4 0.0
bl602+rpc (read/write) 1457986 1457994 8 0.0
.bss 129017 129017 0 0.0
.data 10208 10208 0 0.0
.text 1098840 1098844 4 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188027 1188027 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506733 1506733 0 0.0
.debug_aranges 133072 133072 0 0.0
.debug_frame 486352 486352 0 0.0
.debug_info 37891397 37891398 1 0.0
.debug_line 5251788 5251788 0 0.0
.debug_loc 3361735 3361735 0 0.0
.debug_ranges 359696 359696 0 0.0
.debug_str 3455343 3455343 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116504 116504 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956782 956784 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283955 1283955 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644312 1644312 0 0.0
.debug_aranges 140576 140576 0 0.0
.debug_frame 511728 511728 0 0.0
.debug_info 41797968 41797968 0 0.0
.debug_line 5626327 5626327 0 0.0
.debug_loc 3554403 3554403 0 0.0
.debug_ranges 382152 382152 0 0.0
.debug_str 3851310 3851310 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030486 1030486 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676387 676387 0 0.0
(read/write) 175028 175028 0 0.0
.bss 74308 74308 0 0.0
.data 3380 3380 0 0.0
.rodata 89595 89595 0 0.0
.text 586480 586480 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640635 640643 8 0.0
(read/write) 157876 157876 0 0.0
.bss 73580 73580 0 0.0
.data 3380 3380 0 0.0
.rodata 78747 78747 0 0.0
.text 561568 561576 8 0.0
lock-ftd LP_CC2652R7 (read only) 677935 677935 0 0.0
(read/write) 163800 163800 0 0.0
.bss 71516 71516 0 0.0
.data 3304 3304 0 0.0
.rodata 77295 77295 0 0.0
.text 600160 600160 0 0.0
lock-mtd LP_CC2652R7 (read only) 661763 661763 0 0.0
(read/write) 175660 175660 0 0.0
.bss 67204 67204 0 0.0
.data 3304 3304 0 0.0
.rodata 103131 103131 0 0.0
.text 558152 558152 0 0.0
pump-app LP_CC2652R7 (read only) 687107 687107 0 0.0
(read/write) 155332 155332 0 0.0
.bss 71452 71452 0 0.0
.data 3296 3296 0 0.0
.rodata 90515 90515 0 0.0
.text 596108 596108 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671599 671599 0 0.0
(read/write) 170952 170952 0 0.0
.bss 71564 71564 0 0.0
.data 3292 3292 0 0.0
.rodata 86071 86071 0 0.0
.text 585048 585048 0 0.0
shell LP_CC2652R7 (read only) 667390 667390 0 0.0
(read/write) 179536 179536 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 86302 86302 0 0.0
.text 580772 580772 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587330 587330 0 0.0
.app_xip_area 463988 463988 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594378 594378 0 0.0
.app_xip_area 465708 465708 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543314 543306 -8 -0.0
.app_xip_area 424996 424988 -8 -0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110304 1110304 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 971880 971880 0 0.0
BRD4161A+rpc (read/write) 973452 973436 -16 -0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 820336 820320 -16 -0.0
BRD4161A+rs911x (read/write) 1003552 1003552 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832300 832300 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151316 1151316 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996976 996976 0 0.0
window-app BRD4161A (read/write) 1102352 1102352 0 0.0
.bss 137780 137780 0 0.0
.data 2096 2096 0 0.0
.text 962456 962456 0 0.0
esp32 all-clusters-app c3devkit (read only) 1222904 1222904 0 0.0
(read/write) 1788038 1788046 8 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257608 257616 8 0.0
.flash.text 1222904 1222904 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1232935 1232935 0 0.0
(read/write) 563932 563932 0 0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314664 314664 0 0.0
.flash.text 1227551 1227551 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 649876 649876 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574368 574368 0 0.0
lock k32w0+release (read/write) 706832 706832 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630868 630868 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10352644 10352644 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503876 503876 0 0.0
.text 8194820 8194820 0 0.0
thermostat-no-ble arm64 (read only) 2368348 2368348 0 0.0
(read/write) 142545 142545 0 0.0
.bss 55249 55249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 76704 76704 0 0.0
.dynamic 560 560 0 0.0
.got 5096 5096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141716 141716 0 0.0
.text 1987536 1987536 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455640 2455640 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418284 1418284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182003 1182003 0 0.0
bss 143633 143633 0 0.0
rodata 144180 144180 0 0.0
text 815244 815244 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160671 1160671 0 0.0
bss 142860 142860 0 0.0
rodata 135768 135768 0 0.0
text 803112 803112 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841968 841968 0 0.0
(read/write) 1743844 1743844 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229321 1229321 0 0.0
.debug_aranges 111784 111784 0 0.0
.debug_frame 373216 373216 0 0.0
.debug_info 26811206 26811206 0 0.0
.debug_line 3667611 3667611 0 0.0
.debug_loc 3579706 3579706 0 0.0
.debug_ranges 339888 339888 0 0.0
.debug_str 3438974 3438974 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569356 569356 0 0.0
.symtab 421168 421168 0 0.0
.text 1544080 1544080 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842704 842704 0 0.0
(read/write) 1686484 1686484 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221120 1221120 0 0.0
.debug_aranges 111256 111256 0 0.0
.debug_frame 376296 376296 0 0.0
.debug_info 26548054 26548054 0 0.0
.debug_line 3688327 3688327 0 0.0
.debug_loc 3567343 3567343 0 0.0
.debug_ranges 338504 338504 0 0.0
.debug_str 3427987 3427987 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533445 533445 0 0.0
.symtab 407600 407600 0 0.0
.text 1487456 1487456 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850896 850896 0 0.0
(read/write) 1605060 1605060 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055176 1055176 0 0.0
.debug_aranges 103464 103464 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22013489 22013490 1 0.0
.debug_line 3258339 3258339 0 0.0
.debug_loc 3265647 3265647 0 0.0
.debug_ranges 303832 303832 0 0.0
.debug_str 3233519 3233519 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469822 469822 0 0.0
.symtab 376048 376048 0 0.0
.text 1414224 1414224 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845864 845864 0 0.0
(read/write) 1642668 1642668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062595 1062595 0 0.0
.debug_aranges 104136 104136 0 0.0
.debug_frame 349448 349448 0 0.0
.debug_info 22392810 22392810 0 0.0
.debug_line 3267033 3267033 0 0.0
.debug_loc 3305505 3305505 0 0.0
.debug_ranges 307176 307176 0 0.0
.debug_str 3260974 3260974 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476025 476025 0 0.0
.symtab 379232 379232 0 0.0
.text 1446800 1446800 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130796 1130796 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577892 577892 0 0.0
lock-app qpg6105+debug (read/write) 1101760 1101760 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548860 548860 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813676 813676 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574570 574572 2 0.0
lighting-app tlsr9518adk80d (read/write) 835632 835632 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592732 592732 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843732 843732 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598974 598976 2 0.0

@woody-apple woody-apple merged commit e3160eb into project-chip:master Sep 16, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@jtung-apple @isiu-apple
[Darwin] Fix Matter framework delegates to pass the delegating object…
43d055e 
… as the first arg to their methods (project-chip#22682)
@vivien-apple vivien-apple mentioned this pull request Sep 16, 2022
Merged
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 14, 2022
Merged
bzbarsky-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 17, 2022
@jtung-apple @bzbarsky-apple
[Darwin] Fix Matter framework delegates to pass the delegating object…
8c3b9bc 
… as the first arg to their methods

This is a re-landing of PR project-chip#22682 and PR project-chip#22690 but with backwards
compat shims in place.

The changes to MTRDeviceControllerDelegate are OK because this
protocol is newly introduced and has not shipped yet.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 17, 2022
Merged
bzbarsky-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 17, 2022
@jtung-apple @bzbarsky-apple
[Darwin] Fix Matter framework delegates to pass the delegating object…
cacaac6 
… as the first arg to their methods

This is a re-landing of PR project-chip#22682 and PR project-chip#22690 but with backwards
compat shims in place.

The changes to MTRDeviceControllerDelegate are OK because this
protocol is newly introduced and has not shipped yet.
bzbarsky-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 18, 2022
@jtung-apple @bzbarsky-apple
[Darwin] Fix Matter framework delegates to pass the delegating object…
5aedb25 
… as the first arg to their methods

This is a re-landing of PR project-chip#22682 and PR project-chip#22690 but with backwards
compat shims in place.

The changes to MTRDeviceControllerDelegate are OK because this
protocol is newly introduced and has not shipped yet.
bzbarsky-apple added a commit that referenced this pull request Nov 18, 2022
@bzbarsky-apple @jtung-apple
[Darwin] Fix Matter framework delegates to pass the delegating object…
3198f01 
… as the first arg to their methods (#23665)

* [Darwin] Fix Matter framework delegates to pass the delegating object as the first arg to their methods

This is a re-landing of PR #22682 and PR #22690 but with backwards
compat shims in place.

The changes to MTRDeviceControllerDelegate are OK because this
protocol is newly introduced and has not shipped yet.

* Address review comment.

Co-authored-by: Jeff Tung <[email protected]>
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @jtung-apple @adbridge
[Darwin] Fix Matter framework delegates to pass the delegating object…
70b31f0 
… as the first arg to their methods (project-chip#23665)

* [Darwin] Fix Matter framework delegates to pass the delegating object as the first arg to their methods

This is a re-landing of PR project-chip#22682 and PR project-chip#22690 but with backwards
compat shims in place.

The changes to MTRDeviceControllerDelegate are OK because this
protocol is newly introduced and has not shipped yet.

* Address review comment.

Co-authored-by: Jeff Tung <[email protected]>
@vivien-apple vivien-apple mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

Assignees
No one assigned
Labels
darwin examples fast track
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] Fix Matter framework delegates to pass the delegating object as the first arg to their methods
3 participants
@jtung-apple @andy31415 @woody-apple