-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus #23587
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22633
Nov 16, 2022
Merged
[Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus #23587
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22633
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te and MTRPairingStatus to MTRCommissioningStatus This is a re-landing of PR project-chip#22633 but with changes made for backwards compat. * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus * Add backwards compat shims for the old APIs.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
November 11, 2022 21:19
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
November 11, 2022 21:19
pullapprove
bot
added
review - pending
darwin
examples
and removed
examples
darwin
labels
Nov 11, 2022
PR #23587: Size comparison from 008df4d to 6896a09 Increases (2 builds for esp32, telink)
Decreases (8 builds for bl602, bl702, esp32, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23587: Size comparison from 008df4d to 1007a66 Increases (2 builds for telink)
Decreases (12 builds for bl602, bl702, esp32, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22633
branch
from
November 15, 2022 02:02
1007a66
to
d6c12c6
Compare
PR #23587: Size comparison from 9a41c9c to d6c12c6 Increases (2 builds for esp32, psoc6)
Decreases (5 builds for bl602, bl702, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Nov 16, 2022
pullapprove
bot
requested review from
erjiaqing,
mlepage-google and
yufengwangca
and removed request for
kghost,
kpschoedel and
erjiaqing
November 16, 2022 15:48
Fast-tracking platform-specific change with platform owner review. |
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…te and MTRPairingStatus to MTRCommissioningStatus (project-chip#23587) * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus This is a re-landing of PR project-chip#22633 but with changes made for backwards compat. * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus * Add backwards compat shims for the old APIs. * Address review comments. Co-authored-by: Vivien Nicolas <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…te and MTRPairingStatus to MTRCommissioningStatus (project-chip#23587) * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus This is a re-landing of PR project-chip#22633 but with changes made for backwards compat. * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus * Add backwards compat shims for the old APIs. * Address review comments. Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-landing of PR #22633 but with changes made for backwards compat.
[Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate
[Darwin] Rename MTRPairingStatus to MTRCommissioningStatus
Add backwards compat shims for the old APIs.