[Platform] Apply API review fixes for MTRDevicePairingDelegate

[bzbarsky-apple]

Reproduction steps

1. Change signatures of callback methods to take controller as first argument (and maybe generally change all delegates to take object they are hanging off of as their first argument). Example API here:

    // (PASE established)
    - (void)deviceController:(MTRDeviceController *)deviceController
        establishedCommissioningSessionForNewNodeID:(NSNumber *)newNodeID;
    - (void)deviceController:(MTRDeviceController *)deviceController
        failedToEstablishCommissioningSessionForNewNodeID:(NSNumber *)newNodeID
        error:(NSError *)error;
    // Device Commissioning
    - (void)deviceController:(MTRDeviceController *)deviceController
        commissionedNodeWithID:(NSNumber *)nodeID;
    - (void)deviceController:(MTRDeviceController *)deviceController
        failedToCommissionNodeWithID:(NSNumber *)nodeID;
        error:(NSError * _Nullable)error;
   

2. Remove the "pairing deleted" notification, which does not seem to actually exist anyway.

May have a bit of overlap with #22531 but the conflicts should not be too bad. Otherwise, this looks independent of the other API change bits going on.

Part of #22420

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[vivien-apple]

Looking again it seems that has been fixed by the combination of #22638 and #22682.

[bzbarsky-apple]

@vivien-apple the current naming does not read as nicely as the API proposal above, and we don't have separate notifications for commissioning success/failure, but that might just not be worth the churn at this point, I agree.