Correctly clean up VectorBool optional arguments in chip-tool. #22414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not actually resetting the Optional (and in fact were operating on totally the wrong type, and it's not clear why this was not crashing all the time). Fixes project-chip#22406
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda and
mrjerryjohns
pullapprove
bot
requested review from
msandstedt,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Sep 6, 2022
|
PR #22414: Size comparison from 58fd10a to 116bc82 Increases (7 builds for cc13x2_26x2, linux, psoc6, qpg)
Decreases (3 builds for cc13x2_26x2, k32w, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Sep 6, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
We were not actually resetting the Optional (and in fact were operating on totally the wrong type, and it's not clear why this was not crashing all the time). Fixes #22406
andy31415
added a commit
that referenced
this pull request
Sep 8, 2022
… (#22438) We were not actually resetting the Optional (and in fact were operating on totally the wrong type, and it's not clear why this was not crashing all the time). Fixes #22406 Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ct-chip#22414) We were not actually resetting the Optional (and in fact were operating on totally the wrong type, and it's not clear why this was not crashing all the time). Fixes project-chip#22406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not actually resetting the Optional (and in fact were operating on
totally the wrong type, and it's not clear why this was not crashing all the
time).
Fixes #22406
Problem
End up with a "vector of booleans" argument that points to empty vector, when the expectation is no vector at all or a nonempty one.
Change overview
Fix cleanup of command args when a command is done to handle this type of argument correctly.
Testing
Used test steps in #22406 to verify the fix.
We should probably take this on the sve2 branch @woody-apple @andy31415