Remove a leak when quit() is used in interactive mode, the buffer hol… (

#22371) * Remove a leak when quit() is used in interactive mode, the buffer holding the command not beeing freed * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]>
project-chip · Sep 6, 2022 · 58fd10a · 58fd10a
1 parent 2025691
commit 58fd10a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/examples/chip-tool/commands/interactive/InteractiveCommands.cpp b/examples/chip-tool/commands/interactive/InteractiveCommands.cpp
@@ -81,6 +81,12 @@ CHIP_ERROR InteractiveStartCommand::RunCommand()
         }
     }
 
+    if (command != nullptr)
+    {
+        free(command);
+        command = nullptr;
+    }
+
     SetCommandExitStatus(CHIP_NO_ERROR);
     return CHIP_NO_ERROR;
 }

diff --git a/examples/darwin-framework-tool/commands/interactive/InteractiveCommands.mm b/examples/darwin-framework-tool/commands/interactive/InteractiveCommands.mm
@@ -127,6 +127,11 @@ el_status_t StopFunction()
         }
     }
 
+    if (command != nullptr) {
+        free(command);
+        command = nullptr;
+    }
+
     SetCommandExitStatus(CHIP_NO_ERROR);
     return CHIP_NO_ERROR;
 }