Update build steps for Build On Linux #22135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Build on Linux (fake, gcc_release, clang, simulated)` periodically times out, like for https://github.com/project-chip/connectedhomeip/runs/7996944701?check_suite_focus=true Fixes project-chip#22134
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
mrjerryjohns
approved these changes
Aug 24, 2022
|
PR #22135: Size comparison from 591b386 to ae4679b Increases (4 builds for cc13x2_26x2, psoc6)
Decreases (3 builds for cc13x2_26x2, cyw30739, telink)
Full report (36 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
…nd test, fix clang-tidy
|
PR #22135: Size comparison from 591b386 to b0a5fb7 Increases (7 builds for cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
approved these changes
Aug 25, 2022
andy31415
force-pushed
the
smaller_build_tests_linux
branch
from
e8d91d3 to
c9d65c7
Compare
|
PR #22135: Size comparison from 40d5dab to b843f0b Increases (9 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (5 builds for bl602, cc13x2_26x2, psoc6)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, telink)
|
|
force-merged because it seems infineon check never finishes. All other tests were green. |
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Update build steps for Build On Linux `Build on Linux (fake, gcc_release, clang, simulated)` periodically times out, like for https://github.com/project-chip/connectedhomeip/runs/7996944701?check_suite_focus=true Fixes project-chip#22134 * Move clang tidy validation to use one of the builds in sanitizer builds * Ensure build output is known and cleaned after each sanitizer build and test, fix clang-tidy * Exclude lwip from clang-tidy validation * do NOT upload objdir for linux ... it is way too big * Fix typo * Another typo fix - remove invalid quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on Linux (fake, gcc_release, clang, simulated)periodicallytimes out, like for
https://github.com/project-chip/connectedhomeip/runs/7996944701?check_suite_focus=true
Fixes #22134
Change overview
The "run tests" step already compiles and runs clang builds several times, so I removed the clang build & test step from
the main compile job. Moved the clang-tidy to run based on the output of one of the sanitizer builds.
Increased the timeout by 30 minute in case the job will take longer still in the future.
Commented out the uploading of the entire
/outdirectory as an artifcat as it seems to take very long (took >50min when clang-tidy failed)Testing
CI will validate
1.0 Justification: fixes failing CI builds