-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better debug logs on response #19595
Conversation
…s to get a formatted FullQName
This partially reverts commit 15639cf. # Conflicts: # build_overrides/pigweed_environment.gni
PR #19595: Size comparison from f36569f to 6e21b64 Increases (3 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (16 builds for cc13x2_26x2, cyw30739, k32w, nrfconnect, telink)
|
…id circular deps in /responders
Thanks for all the tips, moved QNameString to its own file now so it can be reused |
PR #19595: Size comparison from 2517dd5 to c35c534 Increases (23 builds for efr32, esp32, linux, mbed, p6, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Fast tracking given this has had enough time for review (> 3 days) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
* Output information about what's being broadcast * Expose/promote QNameString in Logging to allow other logging locations to get a formatted FullQName * Revert inadvertent build_overrides/pigweed_environment.gni This partially reverts commit 15639cf. # Conflicts: # build_overrides/pigweed_environment.gni * Update BUILD.gn deps for QNameString & move it to its own file to avoid circular deps in /responders * Remove unnecessary StringBuilder addition as QNameString is now in its own file * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
* Output information about what's being broadcast * Expose/promote QNameString in Logging to allow other logging locations to get a formatted FullQName * Revert inadvertent build_overrides/pigweed_environment.gni This partially reverts commit 15639cf. # Conflicts: # build_overrides/pigweed_environment.gni * Update BUILD.gn deps for QNameString & move it to its own file to avoid circular deps in /responders * Remove unnecessary StringBuilder addition as QNameString is now in its own file * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Marcos B <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* Output information about what's being broadcast * Expose/promote QNameString in Logging to allow other logging locations to get a formatted FullQName * Revert inadvertent build_overrides/pigweed_environment.gni This partially reverts commit 15639cf. # Conflicts: # build_overrides/pigweed_environment.gni * Update BUILD.gn deps for QNameString & move it to its own file to avoid circular deps in /responders * Remove unnecessary StringBuilder addition as QNameString is now in its own file * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Makes debugging response issues a little bit easier