Error reporting cleanup (#6979)

* Code cleanup: better error report for on receive errors, destination node id logging is a progress not an error

* Include fabric ID in progress message for secure transport. We may want to eventually maye this "Detail" in case logging is too verbose

* Take into account that node ids in packet headers are optional

* Restyle fixes and swap back error to progress

* Review comments and merge fix

* revert unwanted changes

* Updated the chip error logging conditional

src/messaging/ExchangeMgr.cpp

@@ -142,7 +142,12 @@ CHIP_ERROR ExchangeManager::UnregisterUnsolicitedMessageHandlerForType(Protocols
 
 void ExchangeManager::OnReceiveError(CHIP_ERROR error, const Transport::PeerAddress & source, SecureSessionMgr * msgLayer)
 {
-    ChipLogError(ExchangeManager, "Accept FAILED, err = %s", ErrorStr(error));
+#if CHIP_ERROR_LOGGING
+    char srcAddressStr[Transport::PeerAddress::kMaxToStringSize];
+    source.ToString(srcAddressStr);
+
+    ChipLogError(ExchangeManager, "Error receiving message from %s: %s", srcAddressStr, ErrorStr(error));
+#endif // CHIP_ERROR_LOGGING
 }
 
 CHIP_ERROR ExchangeManager::RegisterUMH(Protocols::Id protocolId, int16_t msgType, ExchangeDelegate * delegate)

src/transport/SecureSessionMgr.cpp

@@ -393,12 +393,14 @@ void SecureSessionMgr::SecureMessageDispatch(const PacketHeader & packetHeader,
 
     if (packetHeader.GetDestinationNodeId().HasValue())
     {
-        ChipLogError(Inet, "Secure transport received message destined to node ID (0x" ChipLogFormatX64 ")",
-                     ChipLogValueX64(packetHeader.GetDestinationNodeId().Value()));
+        ChipLogProgress(Inet, "Secure transport received message destined to fabric %d, node 0x" ChipLogFormatX64 ". Key ID %d",
+                        static_cast<int>(state->GetAdminId()), ChipLogValueX64(packetHeader.GetDestinationNodeId().Value()),
+                        packetHeader.GetEncryptionKeyID());
     }
     else
     {
-        ChipLogError(Inet, "Secure transport received message without node ID with key ID (%d)", packetHeader.GetEncryptionKeyID());
+        ChipLogProgress(Inet, "Secure transport received message for fabric %d without node ID. Key ID %d",
+                        static_cast<int>(state->GetAdminId()), packetHeader.GetEncryptionKeyID());
     }
 
     mPeerConnections.MarkConnectionActive(state);