-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overrides rendezvousInformation with the value that came from the com… #19417
Merged
tcarmelveilleux
merged 1 commit into
project-chip:master
from
yufengwangca:pr/linux/capability
Jun 10, 2022
Merged
Overrides rendezvousInformation with the value that came from the com… #19417
tcarmelveilleux
merged 1 commit into
project-chip:master
from
yufengwangca:pr/linux/capability
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
June 9, 2022 22:42
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 9, 2022 22:42
woody-apple
approved these changes
Jun 10, 2022
PR #19417: Size comparison from 668938e to 11140a9 Increases (10 builds for cc13x2_26x2, linux)
Decreases (3 builds for cc13x2_26x2, cyw30739, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 10, 2022
tcarmelveilleux
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mand line
Problem
What is being fixed? Examples:
'--capabilities' option for Linux apps does nothing, and always use the value which is based on some build-time defines.
Fixes --capabilities option for Linux apps does nothing #18995
Change overview
Overrides rendezvousInformation with the value that came from the command line
Testing
How was this tested? (at least one bullet point required)
./chip-all-clusters-app --capabilities 3