Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--capabilities option for Linux apps does nothing #18995

Closed
bzbarsky-apple opened this issue May 31, 2022 · 1 comment · Fixed by #19417
Closed

--capabilities option for Linux apps does nothing #18995

bzbarsky-apple opened this issue May 31, 2022 · 1 comment · Fixed by #19417

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

In ChipLinuxAppInit we parse command line args like so:

    err = ParseArguments(argc, argv, customOptions);

which for --capabilities will do:

    case kDeviceOption_Capabilities:
        LinuxDeviceOptions::GetInstance().payload.rendezvousInformation.SetRaw(static_cast<uint8_t>(atoi(aValue)));
        break;

Then back in ChipLinuxAppInit we do:

    err = GetPayloadContents(LinuxDeviceOptions::GetInstance().payload, rendezvousFlags);

where rendezvousFlags is based on some build-time defines, and that does:

    aPayload.rendezvousInformation = aRendezvousFlags;

which overrides the value that came from the command line.

Proposed Solution

What is the actual intended behavior of this command-line option? Is it meant to change the behavior of the application, or just the pairing codes that get printed?

@yufengwangca

@sowmyassp
Copy link

This issue fails 3 test-cases of Device discovery that is TC-DD-3.11, TC-DD-3.12, TC-DD-3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants