-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded/ambiguous CompressedFabricId usages #18459
Merged
tcarmelveilleux
merged 9 commits into
project-chip:master
from
tcarmelveilleux:remove-compressed-fabric-id-fabric-removal
May 17, 2022
Merged
Remove unneeded/ambiguous CompressedFabricId usages #18459
tcarmelveilleux
merged 9 commits into
project-chip:master
from
tcarmelveilleux:remove-compressed-fabric-id-fabric-removal
May 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the SDK, FabricIndex is the only unambiguous identifier. Many methods that emanated from FabricTableDelegate::OnFabricDeletedFromStorage(chip::CompressedFabricId, chip::FabricIndex) perpetuated use of the compressed fabric ID, because at the bottom, we have CASESessionManager::ReleaseSessionsForFabric(CompressedFabricId) - Replace CASESessionManager::ReleaseSessionsForFabric argument from CompressedFabricId to FabricIndex. - Rework FabricTableDelegate to remove need to pass any CompressedFabricId. - Replace all downstream usages of CompressedFabricId with FabricIndex and FabricTable reference. - Make FabricTableDelegate calls symmetrical in arguments - Make FabricTableDelegate an inner class of FabricTable to remove a friend relationship - Clarify when adding a FabricTableDelegate causes its deletion due to ownership changes - Add session resumption state clearing on fabric removal Fixes project-chip#18435 Issue project-chip#18436
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
May 15, 2022 01:25
PR #18459: Size comparison from 25e241e to 0f7645b Increases (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, linux)
Full report (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
May 16, 2022
andy31415
reviewed
May 16, 2022
andy31415
reviewed
May 16, 2022
andy31415
reviewed
May 16, 2022
andy31415
reviewed
May 16, 2022
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
andy31415
reviewed
May 16, 2022
andy31415
approved these changes
May 16, 2022
msandstedt
reviewed
May 16, 2022
msandstedt
approved these changes
May 16, 2022
…-fabric-id-fabric-removal
PR #18459: Size comparison from 0ddaa8b to fd3ff5b Increases (31 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 16, 2022
PR #18459: Size comparison from 0ddaa8b to 68007d0 Increases (18 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6, telink)
Decreases (18 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6, telink)
Full report (18 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6, telink)
|
PR #18459: Size comparison from 0ddaa8b to a0f1e99 Increases above 0.2%:
Increases (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (29 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18459: Size comparison from 0ddaa8b to 57bf342 Increases above 0.2%:
Increases (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (29 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Within the SDK, FabricIndex is the only unambiguous identifier.
Many methods that emanated from
FabricTableDelegate::OnFabricDeletedFromStorage(chip::CompressedFabricId, chip::FabricIndex)
perpetuated use of the compressed fabric ID, because at the bottom, we have
CASESessionManager::ReleaseSessionsForFabric(CompressedFabricId)
Fixes #18435
Issue #18436
Change overview
CompressedFabricId to FabricIndex.
CompressedFabricId.
and FabricTable reference.
a friend relationship
to ownership changes
Testing