Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASESessionManager::ReleaseSessionForFabric and BindingManager::FabricRemoved assume the compressed fabric id is a unique id #15808

Closed
bzbarsky-apple opened this issue Mar 3, 2022 · 1 comment
Closed

CASESessionManager::ReleaseSessionForFabric and BindingManager::FabricRemoved assume the compressed fabric id is a unique id #15808

bzbarsky-apple opened this issue Mar 3, 2022 · 1 comment

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Mar 3, 2022 •
edited
Loading

Problem

We're removing state using the compressed fabric ID as a key. The issue is that we are really keying on PeerId, and all that has to work with is a CompressedFabricId.

Proposed Solution

Figure out a key that would actually be unique.
@bzbarsky-apple bzbarsky-apple changed the title CASESessionManagerReleaseSessionForFabric and BindingManager::FabricRemoved CASESessionManager::ReleaseSessionForFabric and BindingManager::FabricRemoved assume the compressed fabric id is a unique id Mar 3, 2022
@bzbarsky-apple
Copy link
Contributor Author

Fixed in #18459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bzbarsky-apple