ReleaseSessionsForFabric
takes CompressFabricIndex which is ambiguous
#18435
Labels
ReleaseSessionsForFabric
takes CompressFabricIndex which is ambiguous
#18435
Problem
Within the SDK,
FabricIndex
is the only unambiguous identifier.Many methods that emanated from
FabricTableDelegate::OnFabricDeletedFromStorage(chip::CompressedFabricId compressedFabricId, chip::FabricIndex fabricIndex)
perpetuated use of the compressed fabric ID, because at the bottom, we haveCASESessionManager::ReleaseSessionsForFabric(CompressedFabricId compressedFabricId);
This makes the whole process more confusing and overall muddies the water about what CompressedFabricId is for. Furthermore, CompressedFabricId is not unambiguous and this could lead to some unintended behavior.
Now that secure sessions hold their fabric index, we should be able to remove CompressedFabricId from the signatures.
Proposed Solution
FabricTableDelegate::OnFabricDeletedFromStorage()
CASESessionManager::ReleaseSessionsForFabric(FabricIndex)
CASESessionManager::ReleaseSessionsForFabric(CompressedFabricId)
The text was updated successfully, but these errors were encountered: