-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort Sources attribute in power source configuration cluster based on order of the power source cluster #17840
Merged
andy31415
merged 18 commits into
project-chip:master
from
fessehaeve:pull-request/fix-power-source-configuration-cluster
May 5, 2022
Merged
Sort Sources attribute in power source configuration cluster based on order of the power source cluster #17840
andy31415
merged 18 commits into
project-chip:master
from
fessehaeve:pull-request/fix-power-source-configuration-cluster
May 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda and
mrjerryjohns
April 28, 2022 10:37
PR #17840: Size comparison from 46c7f14 to 061db81 Increases above 0.2%:
Increases (12 builds for cc13x2_26x2, cyw30739, efr32, k32w, mbed, nrfconnect, p6)
Decreases (15 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, p6, telink)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17840: Size comparison from 46c7f14 to 177a2ed Increases above 0.2%:
Increases (14 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6)
Decreases (15 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, p6, telink)
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
fessehaeve
force-pushed
the
pull-request/fix-power-source-configuration-cluster
branch
from
May 4, 2022 10:18
177a2ed
to
d90a14e
Compare
PR #17840: Size comparison from 0a9e871 to ecf885d Increases above 0.2%:
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
fessehaeve
force-pushed
the
pull-request/fix-power-source-configuration-cluster
branch
from
May 4, 2022 16:48
1e75735
to
255bae1
Compare
PR #17840: Size comparison from 28295b6 to 255bae1 Increases above 0.2%:
Increases (15 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (4 builds for cc13x2_26x2, linux)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 4, 2022
src/app/clusters/power-source-configuration-server/power-source-configuration-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/power-source-configuration-server/power-source-configuration-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/power-source-configuration-server/power-source-configuration-server.cpp
Outdated
Show resolved
Hide resolved
Damian-Nordic
approved these changes
May 5, 2022
ghost
approved these changes
May 5, 2022
jmeg-sfy
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Sort sources list
Testing
Testing was done on all-clusters-app by adding more power source server cluster on endpoints.