[TC-GC-1.1]General commissioning cluster---Value mismatch for FeatureMap attribute

[Rajashreekalmane]

Problem

As per test plan [TC-GC-1.1] FeatureMap attribute showing value mismatch error when executed, DUT should
responds with feature map value 0 but currently DUT responding feature map value has 6.

• expected behavior:-FeatureMap attribute value should be bit 0.

• actual behavior:- DUT responds has bit 6

• steps to reproduce:-./chip-tool generalcommissioning read feature-map 1 0

- system configuration:-
Chip-Tool: RPI
DUT: RPI
Platform : IP and Wifi
Commit-ID:4d50b1084284018c4a628f919b0d2e01ea2a39f8
Dut: all-cluster-app

PFA log
TC-GC-1.1.txt

TestPlan reference:-
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/General_Commissioning.adoc#tc-gc-1-1-global-attributes-dut-commissionee

[bzbarsky-apple]

@Rajashreekalmane This is using all-clusters-app as the DUT?

[bzbarsky-apple]

It looks like this changed in #17840. @fessehaeve could you please take a look? Is this just a bad merge on the ZAP file, so the feature map default for the wrong cluster ended up getting changed?

[Rajashreekalmane]

@bzbarsky-apple Yes I am using DUT as all-clusters-app.

[fessehaeve]

It looks like this changed in #17840. @fessehaeve could you please take a look? Is this just a bad merge on the ZAP file, so the feature map default for the wrong cluster ended up getting changed?

@bzbarsky-apple It must be a bad merge since I did nothing related to General commissioning cluster. The feature-map value was already 6 in the previous state a9656d5 from @yufengwangca .

[bzbarsky-apple]

Good catch. @yufengwangca Do you recall why it's 6 there?

[cecille]

Here the DUT is the commissionee - should the test not be expecting the feature map to match the features supported by the device? General commissioning cluster has 4 features (not sure what the first feature is for). Value 6 corresponds to bits 1 and 2, which are wifi and thread. This is expected on the all clusters app. IMO the test is wrong here - it should be expecting a value that relates to the features of the device under test.

[bzbarsky-apple]

The General Commissioning cluster has no features defined at all in the spec, so its FeatureMap should always be 0 and the test is correct....

[cecille]

Ah, you're correct. It did until https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/4956. So that's where the 6 came from. It was a spec change without a corresponding SDK change.

[bzbarsky-apple]

Ah, great catch. I'll just put up a PR, then.