Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix general commissioning feature map value for all-clusters-app. #18526

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix general commissioning feature map value for all-clusters-app. #18526

merged 1 commit into from
May 19, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Spec changed and now there are no features defined.

Fixes #18028

Problem

See above.

Change overview

Set feature map to 0.

Testing

Looked at generated code.

@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

PR #18526: Size comparison from 9acc5cb to 5ad36e8

Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9acc5cb 5ad36e8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692151 692151 0 0.0
(read/write) 159384 159384 0 0.0
.bss 74516 74516 0 0.0
.data 3412 3412 0 0.0
.rodata 103823 103823 0 0.0
.text 587848 587848 0 0.0
lock-ftd LP_CC2652R7 (read only) 676863 676863 0 0.0
(read/write) 165776 165776 0 0.0
.bss 72676 72676 0 0.0
.data 3236 3236 0 0.0
.rodata 94967 94967 0 0.0
.text 581412 581412 0 0.0
lock-mtd LP_CC2652R7 (read only) 625695 625695 0 0.0
(read/write) 145508 145508 0 0.0
.bss 68412 68412 0 0.0
.data 3236 3236 0 0.0
.rodata 94855 94855 0 0.0
.text 530348 530348 0 0.0
pump-app LP_CC2652R7 (read only) 660387 660387 0 0.0
(read/write) 183532 183532 0 0.0
.bss 72932 72932 0 0.0
.data 3268 3268 0 0.0
.rodata 80467 80467 0 0.0
.text 579440 579440 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653555 653555 0 0.0
(read/write) 190172 190172 0 0.0
.bss 72996 72996 0 0.0
.data 3232 3232 0 0.0
.rodata 83571 83571 0 0.0
.text 569504 569504 0 0.0
shell LP_CC2652R7 (read only) 686538 686538 0 0.0
(read/write) 160820 160820 0 0.0
.bss 77140 77140 0 0.0
.data 3416 3416 0 0.0
.rodata 101370 101370 0 0.0
.text 584684 584684 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624766 624766 0 0.0
.app_xip_area 528396 528396 0 0.0
.bss 79012 79012 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627826 627826 0 0.0
.app_xip_area 532912 532912 0 0.0
.bss 77588 77588 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572266 572266 0 0.0
.app_xip_area 467636 467636 0 0.0
.bss 87008 87008 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915068 915068 0 0.0
(read/write) 133220 133220 0 0.0
.bss 131160 131160 0 0.0
.data 2060 2060 0 0.0
.text 915060 915060 0 0.0
BRD4161A+rpc (read only) 949304 949304 0 0.0
(read/write) 149904 149904 0 0.0
.bss 147640 147640 0 0.0
.data 2264 2264 0 0.0
.text 949296 949296 0 0.0
BRD4161A+rs911x (read only) 784416 784416 0 0.0
(read/write) 128444 128444 0 0.0
.bss 126372 126372 0 0.0
.data 2068 2068 0 0.0
.text 784408 784408 0 0.0
lock-app BRD4161A+wf200 (read only) 945156 945156 0 0.0
(read/write) 122924 122924 0 0.0
.bss 120900 120900 0 0.0
.data 2024 2024 0 0.0
.text 945148 945148 0 0.0
window-app BRD4161A (read only) 895188 895188 0 0.0
(read/write) 133280 133280 0 0.0
.bss 131232 131232 0 0.0
.data 2048 2048 0 0.0
.text 895180 895180 0 0.0
esp32 all-clusters-app c3devkit (read only) 998376 998376 0 0.0
(read/write) 1477026 1477026 0 0.0
.dram0.bss 67128 67128 0 0.0
.dram0.data 14576 14576 0 0.0
.flash.rodata 209888 209888 0 0.0
.flash.text 998376 998376 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1053635 1053635 0 0.0
(read/write) 479024 479024 0 0.0
.dram0.bss 72656 72656 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 240188 240188 0 0.0
.flash.text 1048251 1048251 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682516 682516 0 0.0
.bss 80200 80200 0 0.0
.data 2016 2016 0 0.0
.text 598596 598596 0 0.0
lock k32w061+release (read/write) 729012 729012 0 0.0
.bss 80632 80632 0 0.0
.data 1976 1976 0 0.0
.text 644700 644700 0 0.0
linux all-clusters-app debug (read only) 2738905 2738905 0 0.0
(read/write) 174624 174624 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82488 82488 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 238877 238877 0 0.0
.text 2323938 2323938 0 0.0
bridge-app debug+rpc (read only) 2021385 2021385 0 0.0
(read/write) 146552 146552 0 0.0
.bss 71744 71744 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65288 65288 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167401 167401 0 0.0
.text 1696002 1696002 0 0.0
chip-tool debug (read only) 9282453 9282453 0 0.0
(read/write) 578864 578864 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 548608 548608 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 479061 479061 0 0.0
.text 7474613 7474613 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9058756 9058756 0 0.0
(read/write) 644993 644993 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583864 583864 0 0.0
.dynamic 560 560 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445124 445124 0 0.0
.text 7149732 7149732 0 0.0
lighting-app debug+rpc (read only) 2315209 2315209 0 0.0
(read/write) 152000 152000 0 0.0
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186473 186473 0 0.0
.text 1961522 1961522 0 0.0
lock-app debug (read only) 2228937 2228937 0 0.0
(read/write) 146680 146680 0 0.0
.bss 72224 72224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 197049 197049 0 0.0
.text 1870994 1870994 0 0.0
ota-provider-app debug (read only) 2049873 2049873 0 0.0
(read/write) 139728 139728 0 0.0
.bss 71680 71680 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177267 177267 0 0.0
.text 1714210 1714210 0 0.0
ota-requestor-app debug (read only) 2079201 2079201 0 0.0
(read/write) 142568 142568 0 0.0
.bss 72352 72352 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173468 173468 0 0.0
.text 1745874 1745874 0 0.0
shell debug (read only) 2555289 2555289 0 0.0
(read/write) 198552 198552 0 0.0
.bss 114632 114632 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76776 76776 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 220050 220050 0 0.0
.text 2172530 2172530 0 0.0
thermostat-no-ble arm64 (read only) 2343780 2343780 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86465 86465 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147108 147108 0 0.0
.text 1966848 1966848 0 0.0
tv-app debug (read only) 2841185 2841185 0 0.0
(read/write) 277472 277472 0 0.0
.bss 189592 189592 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219345 219345 0 0.0
.text 2438562 2438562 0 0.0
tv-casting-app debug (read only) 5403545 5403545 0 0.0
(read/write) 223776 223776 0 0.0
.bss 77240 77240 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337921 337921 0 0.0
.text 4705314 4705314 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418784 2418784 0 0.0
.bss 201588 201588 0 0.0
.data 5872 5872 0 0.0
.text 1381428 1381428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180243 1180243 0 0.0
bss 138356 138356 0 0.0
rodata 152956 152956 0 0.0
text 810168 810168 0 0.0
p6 all-clusters-app default (read/write) 2532168 2532168 0 0.0
.bss 135096 135096 0 0.0
.data 2808 2808 0 0.0
.text 1490432 1490432 0 0.0
light-app default (read/write) 2418776 2418776 0 0.0
.bss 128416 128416 0 0.0
.data 2608 2608 0 0.0
.text 1377040 1377040 0 0.0
lock-app default (read/write) 2429424 2429424 0 0.0
.bss 128232 128232 0 0.0
.data 2568 2568 0 0.0
.text 1387688 1387688 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782124 782124 0 0.0
bss 70592 70592 0 0.0
noinit 40416 40416 0 0.0
text 553036 553036 0 0.0
lighting-app tlsr9518adk80d (read/write) 802216 802216 0 0.0
bss 70848 70848 0 0.0
noinit 40416 40416 0 0.0
text 569802 569802 0 0.0

@bzbarsky-apple
Fix general commissioning feature map value for all-clusters-app.
05e23ae 
Spec changed and now there are no features defined.

Fixes project-chip#18028
@bzbarsky-apple bzbarsky-apple force-pushed the fix-general-commissioning-feature-map branch from 5ad36e8 to 05e23ae Compare May 19, 2022 12:24
@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited
Loading

PR #18526: Size comparison from 6b82aee to 05e23ae

Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6b82aee 05e23ae change % change
cyw30739 light cyw930739m2evb_01 (read/write) 625394 625394 0 0.0
.app_xip_area 529008 529008 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628350 628350 0 0.0
.app_xip_area 533420 533420 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570998 570998 0 0.0
.app_xip_area 466352 466352 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917508 917508 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 917500 917500 0 0.0
BRD4161A+rpc (read only) 951680 951680 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 951672 951672 0 0.0
BRD4161A+rs911x (read only) 790956 790956 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 790948 790948 0 0.0
lock-app BRD4161A+wf200 (read only) 946964 946964 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 946956 946956 0 0.0
window-app BRD4161A (read only) 897620 897620 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897612 897612 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000910 1000910 0 0.0
(read/write) 1477898 1477898 0 0.0
.dram0.bss 68208 68208 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209640 209640 0 0.0
.flash.text 1000910 1000910 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1056031 1056031 0 0.0
(read/write) 479884 479884 0 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 239960 239960 0 0.0
.flash.text 1050647 1050647 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682864 682864 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 598920 598920 0 0.0
lock k32w061+release (read/write) 729408 729408 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 645072 645072 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9078212 9078212 0 0.0
(read/write) 646209 646209 0 0.0
.bss 42209 42209 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583944 583944 0 0.0
.dynamic 560 560 0 0.0
.got 15016 15016 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 444948 444948 0 0.0
.text 7169060 7169060 0 0.0
thermostat-no-ble arm64 (read only) 2351788 2351788 0 0.0
(read/write) 176289 176289 0 0.0
.bss 87585 87585 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147068 147068 0 0.0
.text 1975808 1975808 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420536 2420536 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383180 1383180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180823 1180823 0 0.0
bss 138380 138380 0 0.0
rodata 152848 152848 0 0.0
text 810732 810732 0 0.0
p6 all-clusters-app default (read/write) 2538776 2538776 0 0.0
.bss 136176 136176 0 0.0
.data 2808 2808 0 0.0
.text 1497040 1497040 0 0.0
light-app default (read/write) 2425344 2425344 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383608 1383608 0 0.0
lock-app default (read/write) 2436032 2436032 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394296 1394296 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782596 782596 0 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 553494 553494 0 0.0
lighting-app tlsr9518adk80d (read/write) 802676 802676 0 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 570260 570260 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 81ed47c into project-chip:master May 19, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-general-commissioning-feature-map branch May 19, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bauerschwan bauerschwan bauerschwan approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TC-GC-1.1]General commissioning cluster---Value mismatch for FeatureMap attribute
6 participants
@bzbarsky-apple @tcarmelveilleux @lazarkov @mrjerryjohns @bauerschwan @jmartinez-silabs