-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linux] Move door-lock-app to lock-app #17396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex and
hawk248
April 14, 2022 14:07
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
April 14, 2022 14:07
PR #17396: Size comparison from c2e0357 to 13f8f7b Increases above 0.2%:
Increases (8 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6)
Decreases (1 build for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17396: Size comparison from 2e94d8b to 7239a10 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, cyw30739, k32w, mbed, p6)
Decreases (1 build for cc13x2_26x2)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17396: Size comparison from a689c84 to e0567bd Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, cyw30739, k32w, mbed, p6)
Decreases (2 builds for cc13x2_26x2, linux)
Full report (29 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17396: Size comparison from 737b702 to c6827bd Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, cyw30739, k32w, mbed, p6)
Decreases (2 builds for cc13x2_26x2, linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17396: Size comparison from 737b702 to d759773 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, cyw30739, k32w, mbed, p6)
Decreases (2 builds for cc13x2_26x2, linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 18, 2022
andy31415
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have lock-app examples implemented for 10 different platforms. They are based on OnOff cluster for historical reasons, i.e. DoorLock cluster was not available when they were created.
Recently door-lock-app was added for Linux and platform developers started creating platform ports of the application.
This will create quite a lot of unnecessary work and it would be much easier to switch the existing apps to using DoorLock cluster.
Change overview
Move door-lock-app/linux to lock-app/linux.
Remove door-lock-app directory.
3 commits are inherited from: #17291.
Testing
CI tested