Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the NRF lock implementation to use the Door Lock State #17291

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Update the NRF lock implementation to use the Door Lock State #17291

merged 4 commits into from
Apr 14, 2022

Conversation

krypton36
Copy link
Contributor

Problem

Change overview

  • Update the NRF lock implementation to use the Door Lock State attribute for lock state machine.

Testing

  • Generated code
  • Compiled
  • Ran chip-tool lock and unlock commands
  • Tested Subscribe
  • Tested Button 2

@krypton36 krypton36 force-pushed the MoveNRCLockAppToDoorLockApp branch from 72908de to 9f6850f Compare April 12, 2022 19:36
@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

PR #17291: Size comparison from 2e33dec to 9f6850f

Increases above 0.2%:

platform target config section 2e33dec 9f6850f change % change
linux door-lock-app debug (read only) 2107313 2122065 14752 0.7
(read/write) 119504 119864 360 0.3
.data.rel.ro 64408 64696 288 0.4
.init_array 680 720 40 5.9
.rodata 186697 190569 3872 2.1
.text 1764914 1775458 10544 0.6
Increases (1 build for linux)
platform target config section 2e33dec 9f6850f change % change
linux door-lock-app debug (read only) 2107313 2122065 14752 0.7
(read/write) 119504 119864 360 0.3
.bss 48064 48096 32 0.1
.data.rel.ro 64408 64696 288 0.4
.init_array 680 720 40 5.9
.rodata 186697 190569 3872 2.1
.text 1764914 1775458 10544 0.6
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2e33dec 9f6850f change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639911 639911 0 0.0
(read/write) 151212 151212 0 0.0
.bss 74144 74144 0 0.0
.data 3212 3212 0 0.0
.rodata 80143 80143 0 0.0
.text 559276 559276 0 0.0
lock-mtd LP_CC2652R7 (read only) 588655 588655 0 0.0
(read/write) 146932 146932 0 0.0
.bss 69864 69864 0 0.0
.data 3212 3212 0 0.0
.rodata 80023 80023 0 0.0
.text 508140 508140 0 0.0
pump-app LP_CC2652R7 (read only) 647995 647995 0 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75331 75331 0 0.0
.text 572176 572176 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641967 641967 0 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 78967 78967 0 0.0
.text 562512 562512 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618514 618514 0 0.0
.app_xip_area 525224 525224 0 0.0
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576126 576126 0 0.0
.app_xip_area 484372 484372 0 0.0
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564642 564642 0 0.0
.app_xip_area 463260 463260 0 0.0
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907004 907004 0 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 906996 906996 0 0.0
BRD4161A+rpc (read only) 941372 941372 0 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 941364 941364 0 0.0
window-app BRD4161A (read only) 843996 843996 0 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 843988 843988 0 0.0
esp32 all-clusters-app c3devkit (read only) 979666 979666 0 0.0
(read/write) 1397514 1397514 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201552 201552 0 0.0
.flash.text 979666 979666 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035255 1035255 0 0.0
(read/write) 465252 465252 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231120 231120 0 0.0
.flash.text 1029871 1029871 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 686728 686728 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 600764 600764 0 0.0
lock k32w061+release (read/write) 691360 691360 0 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 604860 604860 0 0.0
linux all-clusters-app debug (read only) 2696353 2696353 0 0.0
(read/write) 149120 149120 0 0.0
.bss 60192 60192 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 80984 80984 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 232421 232421 0 0.0
.text 2289938 2289938 0 0.0
bridge-app debug+rpc (read only) 1835933 1835933 0 0.0
(read/write) 91752 91752 0 0.0
.bss 44472 44472 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39280 39280 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1569029 1569029 0 0.0
chip-tool debug (read only) 10676501 10676501 0 0.0
(read/write) 371832 371832 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341728 341728 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 537973 537973 0 0.0
.text 9309221 9309221 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 1027722 1027722 0 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388816 388816 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512228 512228 0 0.0
.text 8661732 8661732 0 0.0
door-lock-app debug (read only) 2107313 2122065 14752 0.7
(read/write) 119504 119864 360 0.3
.bss 48064 48096 32 0.1
.data 1472 1472 0 0.0
.data.rel.ro 64408 64696 288 0.4
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 720 40 5.9
.rodata 186697 190569 3872 2.1
.text 1764914 1775458 10544 0.6
lighting-app debug+rpc (read only) 2312137 2312137 0 0.0
(read/write) 127824 127824 0 0.0
.bss 50272 50272 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69896 69896 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182633 182633 0 0.0
.text 1963666 1963666 0 0.0
ota-provider-app debug (read only) 2044465 2044465 0 0.0
(read/write) 114944 114944 0 0.0
.bss 47968 47968 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59624 59624 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172451 172451 0 0.0
.text 1715826 1715826 0 0.0
ota-requestor-app debug (read only) 2074873 2074873 0 0.0
(read/write) 118264 118264 0 0.0
.bss 48928 48928 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61864 61864 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169356 169356 0 0.0
.text 1747458 1747458 0 0.0
shell debug (read only) 2524145 2524145 0 0.0
(read/write) 149968 149968 0 0.0
.bss 67624 67624 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214674 214674 0 0.0
.text 2148306 2148306 0 0.0
thermostat-no-ble arm64 (read only) 2352700 2352700 0 0.0
(read/write) 150993 150993 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144668 144668 0 0.0
.text 1979456 1979456 0 0.0
tv-app debug (read only) 2795649 2795649 0 0.0
(read/write) 250680 250680 0 0.0
.bss 164104 164104 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75912 75912 0 0.0
.dynamic 592 592 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213259 213259 0 0.0
.text 2401090 2401090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155895 1155895 0 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 794976 794976 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1142083 1142083 0 0.0
bss 139200 139200 0 0.0
rodata 121812 121812 0 0.0
text 802436 802436 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1106319 1106319 0 0.0
bss 139436 139436 0 0.0
rodata 112936 112936 0 0.0
text 774848 774848 0 0.0
nrf52840dongle_nrf52840 (read/write) 1050987 1050987 0 0.0
bss 146448 146448 0 0.0
rodata 91964 91964 0 0.0
text 731656 731656 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1050810 1050810 0 0.0
bss 136264 136264 0 0.0
rodata 114984 114984 0 0.0
text 717600 717600 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1062143 1062143 0 0.0
bss 129152 129152 0 0.0
rodata 117280 117280 0 0.0
text 737148 737148 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1043879 1043879 0 0.0
bss 128872 128872 0 0.0
rodata 113288 113288 0 0.0
text 723172 723172 0 0.0
p6 all-clusters-app default (read/write) 2514688 2514688 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1472952 1472952 0 0.0
light-app default (read/write) 2415160 2415160 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373424 1373424 0 0.0
lock-app default (read/write) 2378712 2378712 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1336976 1336976 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800992 800992 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 569690 569690 0 0.0

@kkasperczyk-no
Copy link
Contributor

@krypton36 thank you for contribution to nrfconnect example! We already planned to do such change for lock-app example, but it is very nice to see the help from you.

I think there was discussion on software development Slack channel with @tcarmelveilleux, @LuDuda and @bzbarsky-apple about lock-app vs door-lock-app and the conclusion was that door-lock should not be added as a new example at all, but we should align existing lock-app to the door lock device type requirements. Would you mind trying to modify lock-app example with your changes instead of creating new nrfconnect implementation of door-lock-app?

@krypton36 krypton36 force-pushed the MoveNRCLockAppToDoorLockApp branch from 9f6850f to 9fe9b47 Compare April 13, 2022 14:51
@krypton36
Copy link
Contributor Author

@krypton36 thank you for contribution to nrfconnect example! We already planned to do such change for lock-app example, but it is very nice to see the help from you.

I think there was discussion on software development Slack channel with @tcarmelveilleux, @LuDuda and @bzbarsky-apple about lock-app vs door-lock-app and the conclusion was that door-lock should not be added as a new example at all, but we should align existing lock-app to the door lock device type requirements. Would you mind trying to modify lock-app example with your changes instead of creating new nrfconnect implementation of door-lock-app?

@kkasperczyk-no Ok. Thank for providing the feedback. Updated the PR and Retested.

@krypton36 krypton36 force-pushed the MoveNRCLockAppToDoorLockApp branch from 9fe9b47 to efe45c6 Compare April 13, 2022 14:59
@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17291: Size comparison from 184bda1 to efe45c6

Increases above 0.2%:

platform target config section 184bda1 efe45c6 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640435 677003 36568 5.7
(read/write) 151212 167140 15928 10.5
.rodata 80227 98875 18648 23.2
.text 559716 577644 17928 3.2
lock-mtd LP_CC2652R7 (read only) 589171 625747 36576 6.2
.rodata 80107 98755 18648 23.3
.text 508572 526500 17928 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576646 613294 36648 6.4
.app_xip_area 484892 521508 36616 7.6
k32w lock k32w061+release (read/write) 691892 728476 36584 5.3
.text 605392 641944 36552 6.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2368516 2408988 40472 1.7
.text 1331116 1371588 40472 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049991 1087119 37128 3.5
rodata 115192 133984 18792 16.3
text 726120 744444 18324 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952718 989846 37128 3.9
rodata 107996 126788 18792 17.4
text 636392 654704 18312 2.9
p6 lock-app default (read/write) 2379160 2419056 39896 1.7
.text 1337424 1377320 39896 3.0
Increases (8 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6)
platform target config section 184bda1 efe45c6 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640435 677003 36568 5.7
(read/write) 151212 167140 15928 10.5
.bss 74144 74184 40 0.1
.rodata 80227 98875 18648 23.2
.text 559716 577644 17928 3.2
lock-mtd LP_CC2652R7 (read only) 589171 625747 36576 6.2
(read/write) 146932 146972 40 0.0
.bss 69864 69904 40 0.1
.rodata 80107 98755 18648 23.3
.text 508572 526500 17928 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576646 613294 36648 6.4
.app_xip_area 484892 521508 36616 7.6
.bss 74452 74484 32 0.0
k32w lock k32w061+release (read/write) 691892 728476 36584 5.3
.bss 78704 78736 32 0.0
.text 605392 641944 36552 6.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2368516 2408988 40472 1.7
.bss 185236 185260 24 0.0
.text 1331116 1371588 40472 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049991 1087119 37128 3.5
bss 130208 130236 28 0.0
rodata 115192 133984 18792 16.3
text 726120 744444 18324 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952718 989846 37128 3.9
bss 126440 126472 32 0.0
rodata 107996 126788 18792 17.4
text 636392 654704 18312 2.9
p6 lock-app default (read/write) 2379160 2419056 39896 1.7
.bss 111880 111912 32 0.0
.text 1337424 1377320 39896 3.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 184bda1 efe45c6 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640435 677003 36568 5.7
(read/write) 151212 167140 15928 10.5
.bss 74144 74184 40 0.1
.data 3212 3212 0 0.0
.rodata 80227 98875 18648 23.2
.text 559716 577644 17928 3.2
lock-mtd LP_CC2652R7 (read only) 589171 625747 36576 6.2
(read/write) 146932 146972 40 0.0
.bss 69864 69904 40 0.1
.data 3212 3212 0 0.0
.rodata 80107 98755 18648 23.3
.text 508572 526500 17928 3.5
pump-app LP_CC2652R7 (read only) 648527 648527 0 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75415 75415 0 0.0
.text 572624 572624 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642499 642499 0 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 79051 79051 0 0.0
.text 562960 562960 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 619042 619042 0 0.0
.app_xip_area 525752 525752 0 0.0
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576646 613294 36648 6.4
.app_xip_area 484892 521508 36616 7.6
.bss 74452 74484 32 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565170 565170 0 0.0
.app_xip_area 463788 463788 0 0.0
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907716 907716 0 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 907708 907708 0 0.0
BRD4161A+rpc (read only) 942084 942084 0 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 942076 942076 0 0.0
window-app BRD4161A (read only) 844708 844708 0 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 844700 844700 0 0.0
k32w light k32w061+release (read/write) 687260 687260 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 601296 601296 0 0.0
lock k32w061+release (read/write) 691892 728476 36584 5.3
.bss 78704 78736 32 0.0
.data 1996 1996 0 0.0
.text 605392 641944 36552 6.0
linux all-clusters-app debug (read only) 2697969 2697969 0 0.0
(read/write) 149216 149216 0 0.0
.bss 60192 60192 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 81080 81080 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 232421 232421 0 0.0
.text 2291554 2291554 0 0.0
bridge-app debug+rpc (read only) 1837581 1837581 0 0.0
(read/write) 91856 91856 0 0.0
.bss 44480 44480 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39376 39376 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148505 148505 0 0.0
.text 1570645 1570645 0 0.0
chip-tool debug (read only) 10683941 10683941 0 0.0
(read/write) 371832 371832 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341728 341728 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538965 538965 0 0.0
.text 9315669 9315669 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10283492 10283492 0 0.0
(read/write) 492273 492273 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388840 388840 0 0.0
.dynamic 560 560 0 0.0
.got 57440 57440 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 513028 513028 0 0.0
.text 8667044 8667044 0 0.0
door-lock-app debug (read only) 2108929 2108929 0 0.0
(read/write) 119600 119600 0 0.0
.bss 48064 48064 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64504 64504 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186697 186697 0 0.0
.text 1766530 1766530 0 0.0
lighting-app debug+rpc (read only) 2313769 2313769 0 0.0
(read/write) 127920 127920 0 0.0
.bss 50272 50272 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182665 182665 0 0.0
.text 1965266 1965266 0 0.0
ota-provider-app debug (read only) 2046145 2046145 0 0.0
(read/write) 115040 115040 0 0.0
.bss 47968 47968 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172515 172515 0 0.0
.text 1717442 1717442 0 0.0
ota-requestor-app debug (read only) 2076521 2076521 0 0.0
(read/write) 118392 118392 0 0.0
.bss 48960 48960 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61960 61960 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169388 169388 0 0.0
.text 1749074 1749074 0 0.0
shell debug (read only) 2525825 2525825 0 0.0
(read/write) 150064 150064 0 0.0
.bss 67624 67624 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75464 75464 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214738 214738 0 0.0
.text 2149922 2149922 0 0.0
thermostat-no-ble arm64 (read only) 2353620 2353620 0 0.0
(read/write) 151121 151121 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78752 78752 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144548 144548 0 0.0
.text 1980496 1980496 0 0.0
tv-app debug (read only) 2797265 2797265 0 0.0
(read/write) 250784 250784 0 0.0
.bss 164112 164112 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 76008 76008 0 0.0
.dynamic 592 592 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213259 213259 0 0.0
.text 2402706 2402706 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368516 2408988 40472 1.7
.bss 185236 185260 24 0.0
.data 5840 5840 0 0.0
.text 1331116 1371588 40472 3.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163459 1163459 0 0.0
bss 136528 136528 0 0.0
rodata 147364 147364 0 0.0
text 800940 800940 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1149615 1149615 0 0.0
bss 140264 140264 0 0.0
rodata 122408 122408 0 0.0
text 808372 808372 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1113927 1113927 0 0.0
bss 140500 140500 0 0.0
rodata 113520 113520 0 0.0
text 780876 780876 0 0.0
nrf52840dongle_nrf52840 (read/write) 1058111 1058111 0 0.0
bss 147472 147472 0 0.0
rodata 92464 92464 0 0.0
text 737272 737272 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1052074 1052074 0 0.0
bss 136464 136464 0 0.0
rodata 115160 115160 0 0.0
text 718492 718492 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1049991 1087119 37128 3.5
bss 130208 130236 28 0.0
rodata 115192 133984 18792 16.3
text 726120 744444 18324 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952718 989846 37128 3.9
bss 126440 126472 32 0.0
rodata 107996 126788 18792 17.4
text 636392 654704 18312 2.9
pump-app nrf52840dk_nrf52840 (read/write) 1069827 1069827 0 0.0
bss 130216 130216 0 0.0
rodata 117876 117876 0 0.0
text 743112 743112 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1051563 1051563 0 0.0
bss 129936 129936 0 0.0
rodata 113884 113884 0 0.0
text 729136 729136 0 0.0
p6 all-clusters-app default (read/write) 2515120 2515120 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1473384 1473384 0 0.0
light-app default (read/write) 2415592 2415592 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373856 1373856 0 0.0
lock-app default (read/write) 2379160 2419056 39896 1.7
.bss 111880 111912 32 0.0
.data 2536 2536 0 0.0
.text 1337424 1377320 39896 3.0
telink lighting-app tlsr9518adk80d (read/write) 801516 801516 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 570132 570132 0 0.0

Damian-Nordic
Damian-Nordic reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. I have a few questions though.

examples/lock-app/nrfconnect/README.md Outdated Show resolved Hide resolved
examples/lock-app/nrfconnect/main/AppTask.cpp Outdated Show resolved Hide resolved
examples/lock-app/nrfconnect/main/ZclCallbacks.cpp Outdated Show resolved Hide resolved
@krypton36 krypton36 force-pushed the MoveNRCLockAppToDoorLockApp branch from efe45c6 to fbbd79e Compare April 13, 2022 20:45
@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17291: Size comparison from e70cc69 to fbbd79e

Increases above 0.2%:

platform target config section e70cc69 fbbd79e change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640303 676855 36552 5.7
(read/write) 151220 167296 16076 10.6
.rodata 80127 98775 18648 23.3
.text 559684 577596 17912 3.2
lock-mtd LP_CC2652R7 (read only) 589039 625599 36560 6.2
.rodata 80007 98655 18648 23.3
.text 508540 526452 17912 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576542 613198 36656 6.4
.app_xip_area 484780 521404 36624 7.6
k32w lock k32w061+release (read/write) 691800 728400 36600 5.3
.text 605292 641860 36568 6.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2369476 2409948 40472 1.7
.text 1332076 1372548 40472 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049895 1086859 36964 3.5
rodata 115096 133868 18772 16.3
text 726108 744312 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952606 989598 36992 3.9
rodata 107900 126668 18768 17.4
text 636380 654572 18192 2.9
p6 lock-app default (read/write) 2379224 2419136 39912 1.7
.text 1337488 1377400 39912 3.0
Increases (8 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6)
platform target config section e70cc69 fbbd79e change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640303 676855 36552 5.7
(read/write) 151220 167296 16076 10.6
.bss 74152 74192 40 0.1
.rodata 80127 98775 18648 23.3
.text 559684 577596 17912 3.2
lock-mtd LP_CC2652R7 (read only) 589039 625599 36560 6.2
(read/write) 146940 146980 40 0.0
.bss 69872 69912 40 0.1
.rodata 80007 98655 18648 23.3
.text 508540 526452 17912 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576542 613198 36656 6.4
.app_xip_area 484780 521404 36624 7.6
.bss 74460 74492 32 0.0
k32w lock k32w061+release (read/write) 691800 728400 36600 5.3
.bss 78712 78744 32 0.0
.text 605292 641860 36568 6.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2369476 2409948 40472 1.7
.bss 185244 185268 24 0.0
.text 1332076 1372548 40472 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049895 1086859 36964 3.5
bss 130216 130244 28 0.0
rodata 115096 133868 18772 16.3
text 726108 744312 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952606 989598 36992 3.9
bss 126448 126480 32 0.0
rodata 107900 126668 18768 17.4
text 636380 654572 18192 2.9
p6 lock-app default (read/write) 2379224 2419136 39912 1.7
.bss 111888 111920 32 0.0
.text 1337488 1377400 39912 3.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e70cc69 fbbd79e change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640303 676855 36552 5.7
(read/write) 151220 167296 16076 10.6
.bss 74152 74192 40 0.1
.data 3212 3212 0 0.0
.rodata 80127 98775 18648 23.3
.text 559684 577596 17912 3.2
lock-mtd LP_CC2652R7 (read only) 589039 625599 36560 6.2
(read/write) 146940 146980 40 0.0
.bss 69872 69912 40 0.1
.data 3212 3212 0 0.0
.rodata 80007 98655 18648 23.3
.text 508540 526452 17912 3.5
pump-app LP_CC2652R7 (read only) 648403 648403 0 0.0
(read/write) 152516 152516 0 0.0
.bss 74648 74648 0 0.0
.data 3244 3244 0 0.0
.rodata 75363 75363 0 0.0
.text 572552 572552 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642351 642351 0 0.0
(read/write) 152184 152184 0 0.0
.bss 74352 74352 0 0.0
.data 3208 3208 0 0.0
.rodata 78951 78951 0 0.0
.text 562912 562912 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618950 618950 0 0.0
.app_xip_area 525652 525652 0 0.0
.bss 75964 75964 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576542 613198 36656 6.4
.app_xip_area 484780 521404 36624 7.6
.bss 74460 74492 32 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565146 565146 0 0.0
.app_xip_area 463756 463756 0 0.0
.bss 83792 83792 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907972 907972 0 0.0
(read/write) 133152 133152 0 0.0
.bss 131112 131112 0 0.0
.data 2040 2040 0 0.0
.text 907964 907964 0 0.0
BRD4161A+rpc (read only) 942348 942348 0 0.0
(read/write) 149836 149836 0 0.0
.bss 147592 147592 0 0.0
.data 2244 2244 0 0.0
.text 942340 942340 0 0.0
window-app BRD4161A (read only) 844628 844628 0 0.0
(read/write) 131156 131156 0 0.0
.bss 129208 129208 0 0.0
.data 1948 1948 0 0.0
.text 844620 844620 0 0.0
k32w light k32w061+release (read/write) 687212 687212 0 0.0
.bss 78136 78136 0 0.0
.data 2036 2036 0 0.0
.text 601240 601240 0 0.0
lock k32w061+release (read/write) 691800 728400 36600 5.3
.bss 78712 78744 32 0.0
.data 1996 1996 0 0.0
.text 605292 641860 36568 6.0
linux all-clusters-app debug (read only) 2697873 2697873 0 0.0
(read/write) 149248 149248 0 0.0
.bss 60224 60224 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 81080 81080 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 232421 232421 0 0.0
.text 2291458 2291458 0 0.0
bridge-app debug+rpc (read only) 1837597 1837597 0 0.0
(read/write) 91856 91856 0 0.0
.bss 44480 44480 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39376 39376 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148505 148505 0 0.0
.text 1570661 1570661 0 0.0
chip-tool debug (read only) 10684389 10684389 0 0.0
(read/write) 371832 371832 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341728 341728 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 539093 539093 0 0.0
.text 9315989 9315989 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10283860 10283860 0 0.0
(read/write) 492273 492273 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388840 388840 0 0.0
.dynamic 560 560 0 0.0
.got 57440 57440 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 513140 513140 0 0.0
.text 8667300 8667300 0 0.0
door-lock-app debug (read only) 2108849 2108849 0 0.0
(read/write) 119600 119600 0 0.0
.bss 48064 48064 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64504 64504 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186697 186697 0 0.0
.text 1766450 1766450 0 0.0
lighting-app debug+rpc (read only) 2313385 2313385 0 0.0
(read/write) 127952 127952 0 0.0
.bss 50304 50304 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182601 182601 0 0.0
.text 1964946 1964946 0 0.0
ota-provider-app debug (read only) 2046009 2046009 0 0.0
(read/write) 115296 115296 0 0.0
.bss 48224 48224 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172547 172547 0 0.0
.text 1717250 1717250 0 0.0
ota-requestor-app debug (read only) 2076441 2076441 0 0.0
(read/write) 118392 118392 0 0.0
.bss 48960 48960 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61960 61960 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169388 169388 0 0.0
.text 1748994 1748994 0 0.0
shell debug (read only) 2525745 2525745 0 0.0
(read/write) 150064 150064 0 0.0
.bss 67624 67624 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75464 75464 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214738 214738 0 0.0
.text 2149842 2149842 0 0.0
thermostat-no-ble arm64 (read only) 2353508 2353508 0 0.0
(read/write) 151137 151137 0 0.0
.bss 63169 63169 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78752 78752 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144548 144548 0 0.0
.text 1980384 1980384 0 0.0
tv-app debug (read only) 2797569 2797569 0 0.0
(read/write) 250784 250784 0 0.0
.bss 164112 164112 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 76008 76008 0 0.0
.dynamic 592 592 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213323 213323 0 0.0
.text 2402946 2402946 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2369476 2409948 40472 1.7
.bss 185244 185268 24 0.0
.data 5840 5840 0 0.0
.text 1332076 1372548 40472 3.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163347 1163347 0 0.0
bss 136536 136536 0 0.0
rodata 147268 147268 0 0.0
text 800924 800924 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1149543 1149543 0 0.0
bss 140272 140272 0 0.0
rodata 122352 122352 0 0.0
text 808356 808356 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1113839 1113839 0 0.0
bss 140508 140508 0 0.0
rodata 113464 113464 0 0.0
text 780836 780836 0 0.0
nrf52840dongle_nrf52840 (read/write) 1058043 1058043 0 0.0
bss 147480 147480 0 0.0
rodata 92412 92412 0 0.0
text 737260 737260 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1052006 1052006 0 0.0
bss 136472 136472 0 0.0
rodata 115108 115108 0 0.0
text 718476 718476 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1049895 1086859 36964 3.5
bss 130216 130244 28 0.0
rodata 115096 133868 18772 16.3
text 726108 744312 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952606 989598 36992 3.9
bss 126448 126480 32 0.0
rodata 107900 126668 18768 17.4
text 636380 654572 18192 2.9
pump-app nrf52840dk_nrf52840 (read/write) 1069715 1069715 0 0.0
bss 130224 130224 0 0.0
rodata 117780 117780 0 0.0
text 743100 743100 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1051467 1051467 0 0.0
bss 129944 129944 0 0.0
rodata 113788 113788 0 0.0
text 729124 729124 0 0.0
p6 all-clusters-app default (read/write) 2515200 2515200 0 0.0
.bss 118648 118648 0 0.0
.data 2768 2768 0 0.0
.text 1473464 1473464 0 0.0
light-app default (read/write) 2415656 2415656 0 0.0
.bss 112144 112144 0 0.0
.data 2576 2576 0 0.0
.text 1373920 1373920 0 0.0
lock-app default (read/write) 2379224 2419136 39912 1.7
.bss 111888 111920 32 0.0
.data 2536 2536 0 0.0
.text 1337488 1377400 39912 3.0
telink lighting-app tlsr9518adk80d (read/write) 801368 801368 0 0.0
bss 69996 69996 0 0.0
noinit 40416 40416 0 0.0
text 570074 570074 0 0.0

@github-actions
Copy link

PR #17291: Size comparison from e70cc69 to 1ff685f

Increases above 0.2%:

platform target config section e70cc69 1ff685f change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2369476 2409364 39888 1.7
.text 1332076 1371964 39888 3.0
Increases (1 build for mbed)
platform target config section e70cc69 1ff685f change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2369476 2409364 39888 1.7
.bss 185244 185268 24 0.0
.text 1332076 1371964 39888 3.0
Full report (1 build for mbed)
platform target config section e70cc69 1ff685f change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2369476 2409364 39888 1.7
.bss 185244 185268 24 0.0
.data 5840 5840 0 0.0
.text 1332076 1371964 39888 3.0

@Damian-Nordic Damian-Nordic force-pushed the MoveNRCLockAppToDoorLockApp branch from 1ff685f to 4dd1dad Compare April 14, 2022 10:53
@Damian-Nordic
Copy link
Contributor

@krypton36 I rebased your change and did some CI fixes as I need to push another change that depends on yours :)

@github-actions
Copy link

github-actions bot commented Apr 14, 2022 •
edited
Loading

PR #17291: Size comparison from 01e54b2 to 4dd1dad

Increases above 0.2%:

platform target config section 01e54b2 4dd1dad change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639823 676375 36552 5.7
(read/write) 151220 167776 16556 10.9
.rodata 79951 98599 18648 23.3
.text 559380 577292 17912 3.2
lock-mtd LP_CC2652R7 (read only) 588567 625127 36560 6.2
.rodata 79831 98479 18648 23.4
.text 508244 526156 17912 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576058 612714 36656 6.4
.app_xip_area 484296 520920 36624 7.6
k32w lock k32w061+release (read/write) 688204 724804 36600 5.3
.text 601924 638492 36568 6.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2368820 2409364 40544 1.7
.text 1331420 1371964 40544 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049415 1086395 36980 3.5
rodata 114920 133692 18772 16.3
text 725808 744012 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952126 989118 36992 3.9
rodata 107724 126492 18768 17.4
text 636072 654264 18192 2.9
p6 lock-app default (read/write) 2378648 2418560 39912 1.7
.text 1336912 1376824 39912 3.0
Increases (8 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6)
platform target config section 01e54b2 4dd1dad change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639823 676375 36552 5.7
(read/write) 151220 167776 16556 10.9
.bss 74152 74192 40 0.1
.rodata 79951 98599 18648 23.3
.text 559380 577292 17912 3.2
lock-mtd LP_CC2652R7 (read only) 588567 625127 36560 6.2
(read/write) 146940 146980 40 0.0
.bss 69872 69912 40 0.1
.rodata 79831 98479 18648 23.4
.text 508244 526156 17912 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576058 612714 36656 6.4
.app_xip_area 484296 520920 36624 7.6
.bss 74460 74492 32 0.0
k32w lock k32w061+release (read/write) 688204 724804 36600 5.3
.bss 78528 78560 32 0.0
.text 601924 638492 36568 6.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2368820 2409364 40544 1.7
.bss 185244 185268 24 0.0
.text 1331420 1371964 40544 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049415 1086395 36980 3.5
bss 130216 130244 28 0.0
rodata 114920 133692 18772 16.3
text 725808 744012 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952126 989118 36992 3.9
bss 126448 126480 32 0.0
rodata 107724 126492 18768 17.4
text 636072 654264 18192 2.9
p6 lock-app default (read/write) 2378648 2418560 39912 1.7
.bss 111888 111920 32 0.0
.text 1336912 1376824 39912 3.0
Full report (29 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 01e54b2 4dd1dad change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 683351 683351 0 0.0
(read/write) 169840 169840 0 0.0
.bss 76176 76176 0 0.0
.data 3380 3380 0 0.0
.rodata 102975 102975 0 0.0
.text 579896 579896 0 0.0
lock-ftd LP_CC2652R7 (read only) 639823 676375 36552 5.7
(read/write) 151220 167776 16556 10.9
.bss 74152 74192 40 0.1
.data 3212 3212 0 0.0
.rodata 79951 98599 18648 23.3
.text 559380 577292 17912 3.2
lock-mtd LP_CC2652R7 (read only) 588567 625127 36560 6.2
(read/write) 146940 146980 40 0.0
.bss 69872 69912 40 0.1
.data 3212 3212 0 0.0
.rodata 79831 98479 18648 23.4
.text 508244 526156 17912 3.5
pump-app LP_CC2652R7 (read only) 648571 648571 0 0.0
(read/write) 152516 152516 0 0.0
.bss 74648 74648 0 0.0
.data 3244 3244 0 0.0
.rodata 75435 75435 0 0.0
.text 572648 572648 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641871 641871 0 0.0
(read/write) 152184 152184 0 0.0
.bss 74352 74352 0 0.0
.data 3208 3208 0 0.0
.rodata 78767 78767 0 0.0
.text 562616 562616 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618458 618458 0 0.0
.app_xip_area 525160 525160 0 0.0
.bss 75964 75964 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576058 612714 36656 6.4
.app_xip_area 484296 520920 36624 7.6
.bss 74460 74492 32 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565234 565234 0 0.0
.app_xip_area 463844 463844 0 0.0
.bss 83792 83792 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907396 907396 0 0.0
(read/write) 133152 133152 0 0.0
.bss 131112 131112 0 0.0
.data 2040 2040 0 0.0
.text 907388 907388 0 0.0
BRD4161A+rpc (read only) 941772 941772 0 0.0
(read/write) 149836 149836 0 0.0
.bss 147592 147592 0 0.0
.data 2244 2244 0 0.0
.text 941764 941764 0 0.0
window-app BRD4161A (read only) 844052 844052 0 0.0
(read/write) 131156 131156 0 0.0
.bss 129208 129208 0 0.0
.data 1948 1948 0 0.0
.text 844044 844044 0 0.0
k32w light k32w061+release (read/write) 683976 683976 0 0.0
.bss 77952 77952 0 0.0
.data 1992 1992 0 0.0
.text 598232 598232 0 0.0
lock k32w061+release (read/write) 688204 724804 36600 5.3
.bss 78528 78560 32 0.0
.data 1952 1952 0 0.0
.text 601924 638492 36568 6.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10343140 10343140 0 0.0
(read/write) 492273 492273 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388840 388840 0 0.0
.dynamic 560 560 0 0.0
.got 57440 57440 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 513204 513204 0 0.0
.text 8726516 8726516 0 0.0
thermostat-no-ble arm64 (read only) 2353652 2353652 0 0.0
(read/write) 151137 151137 0 0.0
.bss 63169 63169 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78752 78752 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144612 144612 0 0.0
.text 1980384 1980384 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368820 2409364 40544 1.7
.bss 185244 185268 24 0.0
.data 5840 5840 0 0.0
.text 1331420 1371964 40544 3.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1162867 1162867 0 0.0
bss 136536 136536 0 0.0
rodata 147092 147092 0 0.0
text 800624 800624 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1149079 1149079 0 0.0
bss 140272 140272 0 0.0
rodata 122176 122176 0 0.0
text 808056 808056 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1113359 1113359 0 0.0
bss 140508 140508 0 0.0
rodata 113288 113288 0 0.0
text 780528 780528 0 0.0
nrf52840dongle_nrf52840 (read/write) 1057563 1057563 0 0.0
bss 147480 147480 0 0.0
rodata 92236 92236 0 0.0
text 736960 736960 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1051526 1051526 0 0.0
bss 136472 136472 0 0.0
rodata 114932 114932 0 0.0
text 718168 718168 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1049415 1086395 36980 3.5
bss 130216 130244 28 0.0
rodata 114920 133692 18772 16.3
text 725808 744012 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952126 989118 36992 3.9
bss 126448 126480 32 0.0
rodata 107724 126492 18768 17.4
text 636072 654264 18192 2.9
pump-app nrf52840dk_nrf52840 (read/write) 1069235 1069235 0 0.0
bss 130224 130224 0 0.0
rodata 117604 117604 0 0.0
text 742800 742800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1050987 1050987 0 0.0
bss 129944 129944 0 0.0
rodata 113612 113612 0 0.0
text 728824 728824 0 0.0
p6 all-clusters-app default (read/write) 2514624 2514624 0 0.0
.bss 118648 118648 0 0.0
.data 2768 2768 0 0.0
.text 1472888 1472888 0 0.0
light-app default (read/write) 2415080 2415080 0 0.0
.bss 112144 112144 0 0.0
.data 2576 2576 0 0.0
.text 1373344 1373344 0 0.0
lock-app default (read/write) 2378648 2418560 39912 1.7
.bss 111888 111920 32 0.0
.data 2536 2536 0 0.0
.text 1336912 1376824 39912 3.0
telink lighting-app tlsr9518adk80d (read/write) 800852 800852 0 0.0
bss 69996 69996 0 0.0
noinit 40416 40416 0 0.0
text 569742 569742 0 0.0

@Damian-Nordic Damian-Nordic force-pushed the MoveNRCLockAppToDoorLockApp branch from 4dd1dad to 88edb1c Compare April 14, 2022 13:49
@Damian-Nordic Damian-Nordic mentioned this pull request Apr 14, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 14, 2022 •
edited
Loading

PR #17291: Size comparison from ea4c3dd to 88edb1c

Increases above 0.2%:

platform target config section ea4c3dd 88edb1c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639823 676375 36552 5.7
(read/write) 151220 167776 16556 10.9
.rodata 79951 98599 18648 23.3
.text 559380 577292 17912 3.2
lock-mtd LP_CC2652R7 (read only) 588567 625127 36560 6.2
.rodata 79831 98479 18648 23.4
.text 508244 526156 17912 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576058 612714 36656 6.4
.app_xip_area 484296 520920 36624 7.6
k32w lock k32w061+release (read/write) 688204 724804 36600 5.3
.text 601924 638492 36568 6.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2368820 2409364 40544 1.7
.text 1331420 1371964 40544 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049415 1086395 36980 3.5
rodata 114920 133692 18772 16.3
text 725808 744012 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952126 989118 36992 3.9
rodata 107724 126492 18768 17.4
text 636072 654264 18192 2.9
p6 lock-app default (read/write) 2378648 2418560 39912 1.7
.text 1336912 1376824 39912 3.0
Increases (8 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, p6)
platform target config section ea4c3dd 88edb1c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639823 676375 36552 5.7
(read/write) 151220 167776 16556 10.9
.bss 74152 74192 40 0.1
.rodata 79951 98599 18648 23.3
.text 559380 577292 17912 3.2
lock-mtd LP_CC2652R7 (read only) 588567 625127 36560 6.2
(read/write) 146940 146980 40 0.0
.bss 69872 69912 40 0.1
.rodata 79831 98479 18648 23.4
.text 508244 526156 17912 3.5
cyw30739 lock cyw930739m2evb_01 (read/write) 576058 612714 36656 6.4
.app_xip_area 484296 520920 36624 7.6
.bss 74460 74492 32 0.0
k32w lock k32w061+release (read/write) 688204 724804 36600 5.3
.bss 78528 78560 32 0.0
.text 601924 638492 36568 6.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2368820 2409364 40544 1.7
.bss 185244 185268 24 0.0
.text 1331420 1371964 40544 3.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1049415 1086395 36980 3.5
bss 130216 130244 28 0.0
rodata 114920 133692 18772 16.3
text 725808 744012 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952126 989118 36992 3.9
bss 126448 126480 32 0.0
rodata 107724 126492 18768 17.4
text 636072 654264 18192 2.9
p6 lock-app default (read/write) 2378648 2418560 39912 1.7
.bss 111888 111920 32 0.0
.text 1336912 1376824 39912 3.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ea4c3dd 88edb1c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 683351 683351 0 0.0
(read/write) 169840 169840 0 0.0
.bss 76176 76176 0 0.0
.data 3380 3380 0 0.0
.rodata 102975 102975 0 0.0
.text 579896 579896 0 0.0
lock-ftd LP_CC2652R7 (read only) 639823 676375 36552 5.7
(read/write) 151220 167776 16556 10.9
.bss 74152 74192 40 0.1
.data 3212 3212 0 0.0
.rodata 79951 98599 18648 23.3
.text 559380 577292 17912 3.2
lock-mtd LP_CC2652R7 (read only) 588567 625127 36560 6.2
(read/write) 146940 146980 40 0.0
.bss 69872 69912 40 0.1
.data 3212 3212 0 0.0
.rodata 79831 98479 18648 23.4
.text 508244 526156 17912 3.5
pump-app LP_CC2652R7 (read only) 648571 648571 0 0.0
(read/write) 152516 152516 0 0.0
.bss 74648 74648 0 0.0
.data 3244 3244 0 0.0
.rodata 75435 75435 0 0.0
.text 572648 572648 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641871 641871 0 0.0
(read/write) 152184 152184 0 0.0
.bss 74352 74352 0 0.0
.data 3208 3208 0 0.0
.rodata 78767 78767 0 0.0
.text 562616 562616 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618458 618458 0 0.0
.app_xip_area 525160 525160 0 0.0
.bss 75964 75964 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576058 612714 36656 6.4
.app_xip_area 484296 520920 36624 7.6
.bss 74460 74492 32 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565234 565234 0 0.0
.app_xip_area 463844 463844 0 0.0
.bss 83792 83792 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907396 907396 0 0.0
(read/write) 133152 133152 0 0.0
.bss 131112 131112 0 0.0
.data 2040 2040 0 0.0
.text 907388 907388 0 0.0
BRD4161A+rpc (read only) 941772 941772 0 0.0
(read/write) 149836 149836 0 0.0
.bss 147592 147592 0 0.0
.data 2244 2244 0 0.0
.text 941764 941764 0 0.0
window-app BRD4161A (read only) 844052 844052 0 0.0
(read/write) 131156 131156 0 0.0
.bss 129208 129208 0 0.0
.data 1948 1948 0 0.0
.text 844044 844044 0 0.0
esp32 all-clusters-app c3devkit (read only) 979666 979666 0 0.0
(read/write) 1397410 1397410 0 0.0
.dram0.bss 62632 62632 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201432 201432 0 0.0
.flash.text 979666 979666 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035075 1035075 0 0.0
(read/write) 465164 465164 0 0.0
.dram0.bss 68152 68152 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231024 231024 0 0.0
.flash.text 1029691 1029691 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 683976 683976 0 0.0
.bss 77952 77952 0 0.0
.data 1992 1992 0 0.0
.text 598232 598232 0 0.0
lock k32w061+release (read/write) 688204 724804 36600 5.3
.bss 78528 78560 32 0.0
.data 1952 1952 0 0.0
.text 601924 638492 36568 6.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10343140 10343140 0 0.0
(read/write) 492273 492273 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388840 388840 0 0.0
.dynamic 560 560 0 0.0
.got 57440 57440 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 513204 513204 0 0.0
.text 8726516 8726516 0 0.0
thermostat-no-ble arm64 (read only) 2353652 2353652 0 0.0
(read/write) 151137 151137 0 0.0
.bss 63169 63169 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78752 78752 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144612 144612 0 0.0
.text 1980384 1980384 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368820 2409364 40544 1.7
.bss 185244 185268 24 0.0
.data 5840 5840 0 0.0
.text 1331420 1371964 40544 3.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1162867 1162867 0 0.0
bss 136536 136536 0 0.0
rodata 147092 147092 0 0.0
text 800624 800624 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1149079 1149079 0 0.0
bss 140272 140272 0 0.0
rodata 122176 122176 0 0.0
text 808056 808056 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1113359 1113359 0 0.0
bss 140508 140508 0 0.0
rodata 113288 113288 0 0.0
text 780528 780528 0 0.0
nrf52840dongle_nrf52840 (read/write) 1057563 1057563 0 0.0
bss 147480 147480 0 0.0
rodata 92236 92236 0 0.0
text 736960 736960 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1051526 1051526 0 0.0
bss 136472 136472 0 0.0
rodata 114932 114932 0 0.0
text 718168 718168 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1049415 1086395 36980 3.5
bss 130216 130244 28 0.0
rodata 114920 133692 18772 16.3
text 725808 744012 18204 2.5
nrf5340dk_nrf5340_cpuapp (read/write) 952126 989118 36992 3.9
bss 126448 126480 32 0.0
rodata 107724 126492 18768 17.4
text 636072 654264 18192 2.9
pump-app nrf52840dk_nrf52840 (read/write) 1069235 1069235 0 0.0
bss 130224 130224 0 0.0
rodata 117604 117604 0 0.0
text 742800 742800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1050987 1050987 0 0.0
bss 129944 129944 0 0.0
rodata 113612 113612 0 0.0
text 728824 728824 0 0.0
p6 all-clusters-app default (read/write) 2514624 2514624 0 0.0
.bss 118648 118648 0 0.0
.data 2768 2768 0 0.0
.text 1472888 1472888 0 0.0
light-app default (read/write) 2415080 2415080 0 0.0
.bss 112144 112144 0 0.0
.data 2576 2576 0 0.0
.text 1373344 1373344 0 0.0
lock-app default (read/write) 2378648 2418560 39912 1.7
.bss 111888 111920 32 0.0
.data 2536 2536 0 0.0
.text 1336912 1376824 39912 3.0
telink lighting-app tlsr9518adk80d (read/write) 800852 800852 0 0.0
bss 69996 69996 0 0.0
noinit 40416 40416 0 0.0
text 569742 569742 0 0.0

@Damian-Nordic Damian-Nordic mentioned this pull request Apr 14, 2022
Closed
@Damian-Nordic Damian-Nordic merged commit 2e94d8b into project-chip:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
examples github review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NRFConnect Lock App is using the OnOff Cluster
5 participants
@krypton36 @kkasperczyk-no @Damian-Nordic @msandstedt @jmartinez-silabs