-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Keep resolving ips even when the first mdns result has been … #17246
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
vivien-apple:Darwin_KeepResolvingIps
Apr 11, 2022
Merged
[Darwin] Keep resolving ips even when the first mdns result has been … #17246
Damian-Nordic
merged 1 commit into
project-chip:master
from
vivien-apple:Darwin_KeepResolvingIps
Apr 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Apr 11, 2022
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
sagar-apple,
saurabhst,
selissia and
tecimovic
April 11, 2022 14:11
pullapprove
bot
requested review from
vijs,
wbschiller,
woody-apple and
xylophone21
April 11, 2022 14:11
PR #17246: Size comparison from 087163c to 3019030 Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Apr 11, 2022
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Apr 13, 2022
…as been received (project-chip#17246)" This reverts commit d125841.
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…as been received (project-chip#17246)" (project-chip#17358) This reverts commit d125841.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…received
Problem
Darwin code terminates early the mdns ip resolution process. But if there is stall mdns broadcast on the network from some previous interfaces it may result into the correct ip not beeing retrieved.
Change overview
Testing
It was tested locally with the help of the
interface-id
on top of a modified version of theall-clusters-app
that does not map the hostname to the hostname of the computer is it running onto .