You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Run ./out/debug/standalone/chip-tool pairing onnetwork 17 20202021
Expected results: Commissioning is fine.
Actual results: chip-tool crashes.
The problem is that we are ending up resolving the operational node on multiple interfaces (in my case loopback and my wifi interfaces) and after the change in #17246 we end up calling back into HandleNodeIdResolve multiple times. But the first time we call it we do proxy->Release() and after that proxy can be a dead object, and the second time we call into that code we try to make a virtual call on it, jump into lala-land (well, in my case can't even read the vtable) and crash.
Proposed Solution
Sort out what the actual invariants are supposed to be here and make sure they are not violated.
I assume CI does not hit this because we advertise loopback-only in CI.
Problem
Steps to reproduce:
chip-tool
andchip-all-clusters-app
:rm /tm/chip*
./out/debug/standalone/chip-all-clusters-app
./out/debug/standalone/chip-tool pairing onnetwork 17 20202021
Expected results: Commissioning is fine.
Actual results: chip-tool crashes.
The problem is that we are ending up resolving the operational node on multiple interfaces (in my case loopback and my wifi interfaces) and after the change in #17246 we end up calling back into
HandleNodeIdResolve
multiple times. But the first time we call it we doproxy->Release()
and after thatproxy
can be a dead object, and the second time we call into that code we try to make a virtual call on it, jump into lala-land (well, in my case can't even read the vtable) and crash.Proposed Solution
Sort out what the actual invariants are supposed to be here and make sure they are not violated.
I assume CI does not hit this because we advertise loopback-only in CI.
@vivien-apple @Damian-Nordic @andreilitvin
The text was updated successfully, but these errors were encountered: