Skip to content

Commit

Permalink
Revert "[Darwin] Keep resolving ips even when the first mdns result h…
Browse files Browse the repository at this point in the history
…as been received (project-chip#17246)" (project-chip#17358)

This reverts commit d125841.
  • Loading branch information
andy31415 authored and andrei-menzopol committed Apr 14, 2022
1 parent b4877ee commit 8b74176
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/platform/Darwin/DnssdImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -531,10 +531,9 @@ static void OnResolve(DNSServiceRef sdRef, DNSServiceFlags flags, uint32_t inter
GetAddrInfo(sdCtx->context, sdCtx->callback, interfaceId, sdCtx->addressType, sdCtx->name, hostname, ntohs(port), txtLen,
txtRecord);

if (!(flags & kDNSServiceFlagsMoreComing))
{
MdnsContexts::GetInstance().Remove(sdCtx);
}
// TODO: If flags & kDNSServiceFlagsMoreComing should we keep waiting to see
// what else we resolve instead of calling Remove() here?
MdnsContexts::GetInstance().Remove(sdCtx);
}

static CHIP_ERROR Resolve(void * context, DnssdResolveCallback callback, uint32_t interfaceId,
Expand Down

0 comments on commit 8b74176

Please sign in to comment.