Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mbed] Fix device commisioning - BLE adv and LWIP PKTINFO #13629

Merged
merged 4 commits into from
Jan 27, 2022
Merged

[Mbed] Fix device commisioning - BLE adv and LWIP PKTINFO #13629

merged 4 commits into from
Jan 27, 2022

Conversation

ATmobica
Copy link
Contributor

Problem

We need to fix some issues to improve the device commissioning process according to a new specification.

  1. Enable LWIP recvinfo feature - is necessary after Mbed-os update [Mbed] Mbed-os and mbed-tools update #13416
  2. Add start BLE advertising after push button
  3. Apps Cmake files refactor - use chip_configure_data_model to include generated files

Change overview

Add LWIP recvinfo flag to mbed application
Add chip_configure_data_model to lock-app and lighting-app cmake
Add start BLE advertising after push button
Update mbed documentation

Testing

Build and run Mbed examples, commissioning device with chip-device-controller

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation examples labels Jan 17, 2022
@github-actions
Copy link

github-actions bot commented Jan 17, 2022 •
edited
Loading

PR #13629: Size comparison from de454db to 4b835a0

Increases (4 builds for mbed)
platform target config section de454db 4b835a0 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2349856 2350112 256 0.0
.bss 189220 189412 192 0.1
.text 1312432 1312688 256 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 180760 180952 192 0.1
lock-app CY8CPROTO_062_4343W+release .bss 179768 179944 176 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2054464 2054656 192 0.0
.bss 156876 157068 192 0.1
.text 1017064 1017256 192 0.0
Decreases (2 builds for mbed)
platform target config section de454db 4b835a0 change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2334504 2333240 -1264 -0.1
.text 1297104 1295840 -1264 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2304848 2300936 -3912 -0.2
.data 5544 5528 -16 -0.3
.text 1267448 1263536 -3912 -0.3
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section de454db 4b835a0 change % change
efr32 lighting-app BRD4161A (read only) 834852 834852 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 834844 834844 0 0.0
BRD4161A+rpc (read only) 822232 822232 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 822224 822224 0 0.0
window-app BRD4161A (read only) 805424 805424 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805416 805416 0 0.0
esp32 all-clusters-app c3devkit (read only) 912094 912094 0 0.0
(read/write) 1316682 1316682 0 0.0
.dram0.bss 70520 70520 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178384 178384 0 0.0
.flash.text 912094 912094 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 960883 960883 0 0.0
(read/write) 448840 448840 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207672 207672 0 0.0
.flash.text 955499 955499 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659064 659064 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 574276 574276 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576692 576692 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8042100 8042100 0 0.0
(read/write) 370641 370641 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245856 245856 0 0.0
.dynamic 560 560 0 0.0
.got 64776 64776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419420 419420 0 0.0
.text 6833684 6833684 0 0.0
thermostat-no-ble arm64 (read only) 2042108 2042108 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697632 1697632 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349856 2350112 256 0.0
.bss 189220 189412 192 0.1
.data 5320 5320 0 0.0
.text 1312432 1312688 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334504 2333240 -1264 -0.1
.bss 180760 180952 192 0.1
.data 5568 5568 0 0.0
.text 1297104 1295840 -1264 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304848 2300936 -3912 -0.2
.bss 179768 179944 176 0.1
.data 5544 5528 -16 -0.3
.text 1267448 1263536 -3912 -0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054656 192 0.0
.bss 156876 157068 192 0.1
.data 4864 4864 0 0.0
.text 1017064 1017256 192 0.0
p6 all-clusters-app default (read/write) 2404744 2404744 0 0.0
.bss 117556 117556 0 0.0
.data 2600 2600 0 0.0
.text 1363008 1363008 0 0.0
light-app default (read/write) 2330048 2330048 0 0.0
.bss 106128 106128 0 0.0
.data 2392 2392 0 0.0
.text 1288312 1288312 0 0.0
lock-app default (read/write) 2299072 2299072 0 0.0
.bss 104976 104976 0 0.0
.data 2344 2344 0 0.0
.text 1257336 1257336 0 0.0
qpg lighting-app qpg6105+debug (read only) 565072 565072 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1048 1048 0 0.0
.text 559752 559752 0 0.0
lock-app qpg6105+debug (read only) 515484 515484 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510164 510164 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840778 840778 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587748 587748 0 0.0

@andy31415
Copy link
Contributor

/rebase

@andy31415
Copy link
Contributor

fast track: platform specific change.

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 4b835a0 to 28a69ba Compare January 18, 2022 16:02
@github-actions
Copy link

github-actions bot commented Jan 18, 2022 •
edited
Loading

PR #13629: Size comparison from be806bb to 28a69ba

Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section be806bb 28a69ba change % change
efr32 lighting-app BRD4161A (read only) 834948 834948 0 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834940 834940 0 0.0
BRD4161A+rpc (read only) 822352 822352 0 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822344 822344 0 0.0
window-app BRD4161A (read only) 805536 805536 0 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805528 805528 0 0.0
k32w light k32w061+release (read/write) 659156 659156 0 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574360 574360 0 0.0
lock k32w061+release (read/write) 661888 661888 0 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576776 576776 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8090660 8090660 0 0.0
(read/write) 373409 373409 0 0.0
.bss 55217 55217 0 0.0
.data 1112 1112 0 0.0
.data.rel.ro 248088 248088 0 0.0
.dynamic 560 560 0 0.0
.got 65296 65296 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 421100 421100 0 0.0
.text 6873764 6873764 0 0.0
thermostat-no-ble arm64 (read only) 2044156 2044156 0 0.0
(read/write) 145985 145985 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129932 129932 0 0.0
.text 1699616 1699616 0 0.0
p6 all-clusters-app default (read/write) 2405304 2405304 0 0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363568 1363568 0 0.0
light-app default (read/write) 2330160 2330160 0 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288424 1288424 0 0.0
lock-app default (read/write) 2299168 2299168 0 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257432 1257432 0 0.0
qpg lighting-app qpg6105+debug (read only) 565160 565160 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559840 559840 0 0.0
lock-app qpg6105+debug (read only) 515572 515572 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510252 510252 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840902 840902 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587854 587854 0 0.0

@ATmobica ATmobica mentioned this pull request Jan 18, 2022
Merged
2 tasks
@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 28a69ba to de1c32e Compare January 19, 2022 17:53
@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13629: Size comparison from fba51b9 to de1c32e

Increases (4 builds for mbed)
platform target config section fba51b9 de1c32e change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2350160 2350352 192 0.0
.bss 189220 189412 192 0.1
.text 1312736 1312928 192 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 180760 180952 192 0.1
lock-app CY8CPROTO_062_4343W+release .bss 179768 179944 176 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2054256 2054448 192 0.0
.bss 156876 157068 192 0.1
.text 1016856 1017048 192 0.0
Decreases (2 builds for mbed)
platform target config section fba51b9 de1c32e change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2334424 2333160 -1264 -0.1
.text 1297024 1295760 -1264 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2304768 2300792 -3976 -0.2
.data 5552 5536 -16 -0.3
.text 1267368 1263392 -3976 -0.3
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fba51b9 de1c32e change % change
efr32 lighting-app BRD4161A (read only) 834836 834836 0 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834828 834828 0 0.0
BRD4161A+rpc (read only) 822224 822224 0 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822216 822216 0 0.0
window-app BRD4161A (read only) 805408 805408 0 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805400 805400 0 0.0
esp32 all-clusters-app c3devkit (read only) 912466 912466 0 0.0
(read/write) 1316642 1316642 0 0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 178344 178344 0 0.0
.flash.text 912466 912466 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961247 961247 0 0.0
(read/write) 448800 448800 0 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207616 207616 0 0.0
.flash.text 955863 955863 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659060 659060 0 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574264 574264 0 0.0
lock k32w061+release (read/write) 661792 661792 0 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576680 576680 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8122444 8122444 0 0.0
(read/write) 374145 374145 0 0.0
.bss 55217 55217 0 0.0
.data 1112 1112 0 0.0
.data.rel.ro 248632 248632 0 0.0
.dynamic 560 560 0 0.0
.got 65488 65488 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 422212 422212 0 0.0
.text 6902804 6902804 0 0.0
thermostat-no-ble arm64 (read only) 2043580 2043580 0 0.0
(read/write) 145905 145905 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 72952 72952 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129916 129916 0 0.0
.text 1699296 1699296 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350160 2350352 192 0.0
.bss 189220 189412 192 0.1
.data 5328 5328 0 0.0
.text 1312736 1312928 192 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334424 2333160 -1264 -0.1
.bss 180760 180952 192 0.1
.data 5576 5576 0 0.0
.text 1297024 1295760 -1264 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304768 2300792 -3976 -0.2
.bss 179768 179944 176 0.1
.data 5552 5536 -16 -0.3
.text 1267368 1263392 -3976 -0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054448 192 0.0
.bss 156876 157068 192 0.1
.data 4864 4864 0 0.0
.text 1016856 1017048 192 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943347 943347 0 0.0
bss 119628 119628 0 0.0
rodata 108760 108760 0 0.0
text 637368 637368 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928831 928831 0 0.0
bss 116672 116672 0 0.0
rodata 101212 101212 0 0.0
text 632764 632764 0 0.0
nrf52840dongle_nrf52840 (read/write) 994027 994027 0 0.0
bss 122472 122472 0 0.0
rodata 113516 113516 0 0.0
text 669568 669568 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853174 853174 0 0.0
bss 116416 116416 0 0.0
rodata 101936 101936 0 0.0
text 554292 554292 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912707 912707 0 0.0
bss 118784 118784 0 0.0
rodata 103728 103728 0 0.0
text 612816 612816 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822778 822778 0 0.0
bss 115600 115600 0 0.0
rodata 96956 96956 0 0.0
text 529776 529776 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915559 915559 0 0.0
bss 118548 118548 0 0.0
rodata 104092 104092 0 0.0
text 615468 615468 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910643 910643 0 0.0
bss 118572 118572 0 0.0
rodata 103200 103200 0 0.0
text 611392 611392 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2405536 2405536 0 0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363800 1363800 0 0.0
light-app default (read/write) 2329976 2329976 0 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288240 1288240 0 0.0
lock-app default (read/write) 2299000 2299000 0 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257264 1257264 0 0.0
qpg lighting-app qpg6105+debug (read only) 565064 565064 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559744 559744 0 0.0
lock-app qpg6105+debug (read only) 515476 515476 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510156 510156 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840698 840698 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587724 587724 0 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from de1c32e to e9f557f Compare January 20, 2022 08:16
@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13629: Size comparison from b700fb8 to e9f557f

Increases (4 builds for mbed)
platform target config section b700fb8 e9f557f change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2347504 2347760 256 0.0
.bss 188732 188924 192 0.1
.text 1310080 1310336 256 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 180232 180424 192 0.1
lock-app CY8CPROTO_062_4343W+release .bss 179240 179416 176 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2054256 2054448 192 0.0
.bss 156876 157068 192 0.1
.text 1016856 1017048 192 0.0
Decreases (2 builds for mbed)
platform target config section b700fb8 e9f557f change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2331768 2330440 -1328 -0.1
.text 1294368 1293040 -1328 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2302120 2298144 -3976 -0.2
.data 5552 5536 -16 -0.3
.text 1264720 1260744 -3976 -0.3
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b700fb8 e9f557f change % change
efr32 lighting-app BRD4161A (read only) 832684 832684 0 0.0
(read/write) 127112 127112 0 0.0
.bss 125216 125216 0 0.0
.data 1896 1896 0 0.0
.text 832676 832676 0 0.0
BRD4161A+rpc (read only) 820080 820080 0 0.0
(read/write) 143776 143776 0 0.0
.bss 141776 141776 0 0.0
.data 1996 1996 0 0.0
.text 820072 820072 0 0.0
window-app BRD4161A (read only) 803268 803268 0 0.0
(read/write) 125800 125800 0 0.0
.bss 123952 123952 0 0.0
.data 1848 1848 0 0.0
.text 803260 803260 0 0.0
esp32 all-clusters-app c3devkit (read only) 910524 910524 0 0.0
(read/write) 1315850 1315850 0 0.0
.dram0.bss 70024 70024 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 178096 178096 0 0.0
.flash.text 910524 910524 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959535 959535 0 0.0
(read/write) 448008 448008 0 0.0
.dram0.bss 74480 74480 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 207368 207368 0 0.0
.flash.text 954151 954151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656696 656696 0 0.0
.bss 76608 76608 0 0.0
.data 1864 1864 0 0.0
.text 572424 572424 0 0.0
lock k32w061+release (read/write) 659400 659400 0 0.0
.bss 76904 76904 0 0.0
.data 1884 1884 0 0.0
.text 574812 574812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8155868 8155868 0 0.0
(read/write) 376481 376481 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 249928 249928 0 0.0
.dynamic 560 560 0 0.0
.got 65632 65632 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 423044 423044 0 0.0
.text 6928708 6928708 0 0.0
thermostat-no-ble arm64 (read only) 2033476 2033476 0 0.0
(read/write) 144417 144417 0 0.0
.bss 63841 63841 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72704 72704 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129508 129508 0 0.0
.text 1689952 1689952 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347504 2347760 256 0.0
.bss 188732 188924 192 0.1
.data 5296 5296 0 0.0
.text 1310080 1310336 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331768 2330440 -1328 -0.1
.bss 180232 180424 192 0.1
.data 5576 5576 0 0.0
.text 1294368 1293040 -1328 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302120 2298144 -3976 -0.2
.bss 179240 179416 176 0.1
.data 5552 5536 -16 -0.3
.text 1264720 1260744 -3976 -0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054448 192 0.0
.bss 156876 157068 192 0.1
.data 4864 4864 0 0.0
.text 1016856 1017048 192 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940967 940967 0 0.0
bss 119100 119100 0 0.0
rodata 108492 108492 0 0.0
text 635796 635796 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926463 926463 0 0.0
bss 116144 116144 0 0.0
rodata 100940 100940 0 0.0
text 631192 631192 0 0.0
nrf52840dongle_nrf52840 (read/write) 991643 991643 0 0.0
bss 121944 121944 0 0.0
rodata 113244 113244 0 0.0
text 667996 667996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850826 850826 0 0.0
bss 115888 115888 0 0.0
rodata 101668 101668 0 0.0
text 552720 552720 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910343 910343 0 0.0
bss 118256 118256 0 0.0
rodata 103460 103460 0 0.0
text 611244 611244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820378 820378 0 0.0
bss 115072 115072 0 0.0
rodata 96684 96684 0 0.0
text 528200 528200 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913215 913215 0 0.0
bss 118020 118020 0 0.0
rodata 103820 103820 0 0.0
text 613892 613892 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908263 908263 0 0.0
bss 118044 118044 0 0.0
rodata 102932 102932 0 0.0
text 609820 609820 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2403648 2403648 0 0.0
.bss 117068 117068 0 0.0
.data 2568 2568 0 0.0
.text 1361912 1361912 0 0.0
light-app default (read/write) 2327768 2327768 0 0.0
.bss 105600 105600 0 0.0
.data 2408 2408 0 0.0
.text 1286032 1286032 0 0.0
lock-app default (read/write) 2296792 2296792 0 0.0
.bss 104448 104448 0 0.0
.data 2352 2352 0 0.0
.text 1255056 1255056 0 0.0
qpg lighting-app qpg6105+debug (read only) 563480 563480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89696 89696 0 0.0
.data 1060 1060 0 0.0
.text 558160 558160 0 0.0
lock-app qpg6105+debug (read only) 513836 513836 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88320 88320 0 0.0
.data 984 984 0 0.0
.text 508516 508516 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838018 838018 0 0.0
bss 86772 86772 0 0.0
noinit 37160 37160 0 0.0
text 585862 585862 0 0.0

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from e9f557f to 65f47cb Compare January 20, 2022 14:51
@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13629: Size comparison from 786fdfa to 65f47cb

Increases (2 builds for mbed)
platform target config section 786fdfa 65f47cb change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2349632 2349888 256 0.0
.bss 189428 189620 192 0.1
.text 1312208 1312464 256 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054256 2054448 192 0.0
.bss 156876 157068 192 0.1
.text 1016856 1017048 192 0.0
Decreases (2 builds for mbed)
platform target config section 786fdfa 65f47cb change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2332328 2330504 -1824 -0.1
.bss 180936 180344 -592 -0.3
.text 1294928 1293104 -1824 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2302744 2298208 -4536 -0.2
.bss 179936 179336 -600 -0.3
.data 5560 5536 -24 -0.4
.text 1265344 1260808 -4536 -0.4
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 786fdfa 65f47cb change % change
efr32 lighting-app BRD4161A (read only) 832748 832748 0 0.0
(read/write) 127032 127032 0 0.0
.bss 125136 125136 0 0.0
.data 1896 1896 0 0.0
.text 832740 832740 0 0.0
BRD4161A+rpc (read only) 820128 820128 0 0.0
(read/write) 143696 143696 0 0.0
.bss 141696 141696 0 0.0
.data 1996 1996 0 0.0
.text 820120 820120 0 0.0
window-app BRD4161A (read only) 803316 803316 0 0.0
(read/write) 125720 125720 0 0.0
.bss 123872 123872 0 0.0
.data 1848 1848 0 0.0
.text 803308 803308 0 0.0
esp32 all-clusters-app c3devkit (read only) 916434 916434 0 0.0
(read/write) 1317506 1317506 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178952 178952 0 0.0
.flash.text 916434 916434 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965003 965003 0 0.0
(read/write) 449464 449464 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208120 208120 0 0.0
.flash.text 959619 959619 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 658572 658572 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574324 574324 0 0.0
lock k32w061+release (read/write) 659368 659368 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 574860 574860 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8156012 8156012 0 0.0
(read/write) 376481 376481 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 249928 249928 0 0.0
.dynamic 560 560 0 0.0
.got 65632 65632 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 423044 423044 0 0.0
.text 6928852 6928852 0 0.0
thermostat-no-ble arm64 (read only) 2040876 2040876 0 0.0
(read/write) 145393 145393 0 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72728 72728 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1696688 1696688 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349632 2349888 256 0.0
.bss 189428 189620 192 0.1
.data 5296 5296 0 0.0
.text 1312208 1312464 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332328 2330504 -1824 -0.1
.bss 180936 180344 -592 -0.3
.data 5576 5576 0 0.0
.text 1294928 1293104 -1824 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302744 2298208 -4536 -0.2
.bss 179936 179336 -600 -0.3
.data 5560 5536 -24 -0.4
.text 1265344 1260808 -4536 -0.4
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054448 192 0.0
.bss 156876 157068 192 0.1
.data 4864 4864 0 0.0
.text 1016856 1017048 192 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940935 940935 0 0.0
bss 119020 119020 0 0.0
rodata 108492 108492 0 0.0
text 635832 635832 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926415 926415 0 0.0
bss 116064 116064 0 0.0
rodata 100940 100940 0 0.0
text 631228 631228 0 0.0
nrf52840dongle_nrf52840 (read/write) 991611 991611 0 0.0
bss 121864 121864 0 0.0
rodata 113244 113244 0 0.0
text 668032 668032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850762 850762 0 0.0
bss 115808 115808 0 0.0
rodata 101668 101668 0 0.0
text 552756 552756 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910295 910295 0 0.0
bss 118176 118176 0 0.0
rodata 103460 103460 0 0.0
text 611280 611280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820346 820346 0 0.0
bss 114992 114992 0 0.0
rodata 96684 96684 0 0.0
text 528236 528236 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913151 913151 0 0.0
bss 117940 117940 0 0.0
rodata 103820 103820 0 0.0
text 613928 613928 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908231 908231 0 0.0
bss 117964 117964 0 0.0
rodata 102932 102932 0 0.0
text 609856 609856 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2406600 2406600 0 0.0
.bss 117764 117764 0 0.0
.data 2576 2576 0 0.0
.text 1364864 1364864 0 0.0
light-app default (read/write) 2327832 2327832 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286096 1286096 0 0.0
lock-app default (read/write) 2296840 2296840 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255104 1255104 0 0.0
qpg lighting-app qpg6105+debug (read only) 565376 565376 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89672 89672 0 0.0
.data 1060 1060 0 0.0
.text 560056 560056 0 0.0
lock-app qpg6105+debug (read only) 513868 513868 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88240 88240 0 0.0
.data 984 984 0 0.0
.text 508548 508548 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839398 839398 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586504 586504 0 0.0

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 65f47cb to 5751e35 Compare January 21, 2022 16:38
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13629: Size comparison from 6e1a741 to 5751e35

Increases (2 builds for mbed)
platform target config section 6e1a741 5751e35 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2351464 2351720 256 0.0
.bss 189412 189604 192 0.1
.text 1314040 1314296 256 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054256 2054512 256 0.0
.bss 156876 157068 192 0.1
.text 1016856 1017112 256 0.0
Decreases (2 builds for mbed)
platform target config section 6e1a741 5751e35 change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2334144 2332256 -1888 -0.1
.bss 180960 180368 -592 -0.3
.text 1296744 1294856 -1888 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2304496 2299960 -4536 -0.2
.bss 179960 179360 -600 -0.3
.data 5560 5544 -16 -0.3
.text 1267096 1262560 -4536 -0.4
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6e1a741 5751e35 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574238 574238 0 0.0
.app_xip_area 479252 479252 0 0.0
.bss 77724 77724 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835452 835452 0 0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 835444 835444 0 0.0
BRD4161A+rpc (read only) 822848 822848 0 0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 822840 822840 0 0.0
window-app BRD4161A (read only) 806004 806004 0 0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 805996 805996 0 0.0
esp32 all-clusters-app c3devkit (read only) 918262 918262 0 0.0
(read/write) 1383402 1383402 0 0.0
.dram0.bss 70704 70704 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 179312 179312 0 0.0
.flash.text 918262 918262 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 966615 966615 0 0.0
(read/write) 449804 449804 0 0.0
.dram0.bss 75168 75168 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208476 208476 0 0.0
.flash.text 961231 961231 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660332 660332 0 0.0
.bss 76608 76608 0 0.0
.data 1868 1868 0 0.0
.text 576056 576056 0 0.0
lock k32w061+release (read/write) 661148 661148 0 0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576612 576612 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8472892 8472892 0 0.0
(read/write) 390081 390081 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260440 260440 0 0.0
.dynamic 560 560 0 0.0
.got 68720 68720 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435236 435236 0 0.0
.text 7200932 7200932 0 0.0
thermostat-no-ble arm64 (read only) 2049644 2049644 0 0.0
(read/write) 145697 145697 0 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130492 130492 0 0.0
.text 1704656 1704656 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351464 2351720 256 0.0
.bss 189412 189604 192 0.1
.data 5304 5304 0 0.0
.text 1314040 1314296 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334144 2332256 -1888 -0.1
.bss 180960 180368 -592 -0.3
.data 5584 5584 0 0.0
.text 1296744 1294856 -1888 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304496 2299960 -4536 -0.2
.bss 179960 179360 -600 -0.3
.data 5560 5544 -16 -0.3
.text 1267096 1262560 -4536 -0.4
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054512 256 0.0
.bss 156876 157068 192 0.1
.data 4864 4864 0 0.0
.text 1016856 1017112 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942715 942715 0 0.0
bss 119044 119044 0 0.0
rodata 108896 108896 0 0.0
text 637168 637168 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928183 928183 0 0.0
bss 116088 116088 0 0.0
rodata 101348 101348 0 0.0
text 632564 632564 0 0.0
nrf52840dongle_nrf52840 (read/write) 993359 993359 0 0.0
bss 121884 121884 0 0.0
rodata 113648 113648 0 0.0
text 669368 669368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852542 852542 0 0.0
bss 115828 115828 0 0.0
rodata 102072 102072 0 0.0
text 554088 554088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912059 912059 0 0.0
bss 118196 118196 0 0.0
rodata 103864 103864 0 0.0
text 612608 612608 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822130 822130 0 0.0
bss 115016 115016 0 0.0
rodata 97092 97092 0 0.0
text 529564 529564 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914915 914915 0 0.0
bss 117960 117960 0 0.0
rodata 104224 104224 0 0.0
text 615256 615256 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910103 910103 0 0.0
bss 117984 117984 0 0.0
rodata 103380 103380 0 0.0
text 611280 611280 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798527 798527 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533928 533928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711342 711342 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451608 451608 0 0.0
p6 all-clusters-app default (read/write) 2409552 2409552 0 0.0
.bss 117756 117756 0 0.0
.data 2584 2584 0 0.0
.text 1367816 1367816 0 0.0
light-app default (read/write) 2330536 2330536 0 0.0
.bss 105544 105544 0 0.0
.data 2408 2408 0 0.0
.text 1288800 1288800 0 0.0
lock-app default (read/write) 2299528 2299528 0 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257792 1257792 0 0.0
qpg lighting-app qpg6105+debug (read only) 567240 567240 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89688 89688 0 0.0
.data 1064 1064 0 0.0
.text 561920 561920 0 0.0
lock-app qpg6105+debug (read only) 515752 515752 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510432 510432 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841514 841514 0 0.0
bss 87492 87492 0 0.0
noinit 37160 37160 0 0.0
text 588162 588162 0 0.0

@ATmobica
Copy link
Contributor Author

@andy31415 @bzbarsky-apple Can we merge this PR?

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 5751e35 to 67d6061 Compare January 24, 2022 17:09
@github-actions
Copy link

github-actions bot commented Jan 24, 2022 •
edited
Loading

PR #13629: Size comparison from 1b49aee to 67d6061

Increases (2 builds for mbed)
platform target config section 1b49aee 67d6061 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2352184 2352440 256 0.0
.bss 189428 189620 192 0.1
.text 1314760 1315016 256 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054256 2054512 256 0.0
.bss 156876 157068 192 0.1
.text 1016856 1017112 256 0.0
Decreases (2 builds for mbed)
platform target config section 1b49aee 67d6061 change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2334408 2332584 -1824 -0.1
.bss 180960 180368 -592 -0.3
.text 1297008 1295184 -1824 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2304760 2300224 -4536 -0.2
.bss 179960 179360 -600 -0.3
.data 5560 5544 -16 -0.3
.text 1267360 1262824 -4536 -0.4
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1b49aee 67d6061 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574390 574390 0 0.0
.app_xip_area 479404 479404 0 0.0
.bss 77724 77724 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835916 835916 0 0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 835908 835908 0 0.0
BRD4161A+rpc (read only) 823336 823336 0 0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 823328 823328 0 0.0
window-app BRD4161A (read only) 806476 806476 0 0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 806468 806468 0 0.0
esp32 all-clusters-app c3devkit (read only) 919076 919076 0 0.0
(read/write) 1383466 1383466 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 179376 179376 0 0.0
.flash.text 919076 919076 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967519 967519 0 0.0
(read/write) 449884 449884 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208540 208540 0 0.0
.flash.text 962135 962135 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660588 660588 0 0.0
.bss 76608 76608 0 0.0
.data 1868 1868 0 0.0
.text 576312 576312 0 0.0
lock k32w061+release (read/write) 661312 661312 0 0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576776 576776 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8536964 8536964 0 0.0
(read/write) 391009 391009 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261032 261032 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 436908 436908 0 0.0
.text 7261028 7261028 0 0.0
thermostat-no-ble arm64 (read only) 2051916 2051916 0 0.0
(read/write) 145697 145697 0 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130700 130700 0 0.0
.text 1706720 1706720 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352184 2352440 256 0.0
.bss 189428 189620 192 0.1
.data 5304 5304 0 0.0
.text 1314760 1315016 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334408 2332584 -1824 -0.1
.bss 180960 180368 -592 -0.3
.data 5584 5584 0 0.0
.text 1297008 1295184 -1824 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304760 2300224 -4536 -0.2
.bss 179960 179360 -600 -0.3
.data 5560 5544 -16 -0.3
.text 1267360 1262824 -4536 -0.4
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054512 256 0.0
.bss 156876 157068 192 0.1
.data 4864 4864 0 0.0
.text 1016856 1017112 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942879 942879 0 0.0
bss 119044 119044 0 0.0
rodata 108916 108916 0 0.0
text 637312 637312 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928347 928347 0 0.0
bss 116088 116088 0 0.0
rodata 101368 101368 0 0.0
text 632708 632708 0 0.0
nrf52840dongle_nrf52840 (read/write) 993527 993527 0 0.0
bss 121884 121884 0 0.0
rodata 113672 113672 0 0.0
text 669512 669512 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852706 852706 0 0.0
bss 115828 115828 0 0.0
rodata 102092 102092 0 0.0
text 554232 554232 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912223 912223 0 0.0
bss 118196 118196 0 0.0
rodata 103884 103884 0 0.0
text 612756 612756 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822294 822294 0 0.0
bss 115016 115016 0 0.0
rodata 97112 97112 0 0.0
text 529712 529712 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915083 915083 0 0.0
bss 117960 117960 0 0.0
rodata 104248 104248 0 0.0
text 615404 615404 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910267 910267 0 0.0
bss 117984 117984 0 0.0
rodata 103400 103400 0 0.0
text 611428 611428 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798527 798527 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533928 533928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711342 711342 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451608 451608 0 0.0
p6 all-clusters-app default (read/write) 2410664 2410664 0 0.0
.bss 117772 117772 0 0.0
.data 2584 2584 0 0.0
.text 1368928 1368928 0 0.0
light-app default (read/write) 2330736 2330736 0 0.0
.bss 105544 105544 0 0.0
.data 2408 2408 0 0.0
.text 1289000 1289000 0 0.0
lock-app default (read/write) 2299752 2299752 0 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1258016 1258016 0 0.0
qpg lighting-app qpg6105+debug (read only) 567476 567476 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89688 89688 0 0.0
.data 1064 1064 0 0.0
.text 562156 562156 0 0.0
lock-app qpg6105+debug (read only) 515904 515904 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510584 510584 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841718 841718 0 0.0
bss 87492 87492 0 0.0
noinit 37160 37160 0 0.0
text 588346 588346 0 0.0

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 67d6061 to 49ae19d Compare January 25, 2022 08:20
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13629: Size comparison from e169fcf to 49ae19d

Increases (2 builds for mbed)
platform target config section e169fcf 49ae19d change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348784 2349040 256 0.0
.bss 186084 186276 192 0.1
.text 1311360 1311616 256 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2053896 2054152 256 0.0
.bss 156876 157068 192 0.1
.text 1016496 1016752 256 0.0
Decreases (2 builds for mbed)
platform target config section e169fcf 49ae19d change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2333984 2332160 -1824 -0.1
.bss 180688 180088 -600 -0.3
.text 1296584 1294760 -1824 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2304568 2300032 -4536 -0.2
.bss 180592 180000 -592 -0.3
.data 5568 5544 -24 -0.4
.text 1267168 1262632 -4536 -0.4
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e169fcf 49ae19d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573714 0 0.0
.app_xip_area 479016 479016 0 0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835484 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835476 0 0.0
BRD4161A+rpc (read only) 822864 822864 0 0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 822856 0 0.0
window-app BRD4161A (read only) 806324 806324 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806316 0 0.0
esp32 all-clusters-app c3devkit (read only) 919202 919202 0 0.0
(read/write) 1376810 1376810 0 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176064 176064 0 0.0
.flash.text 919202 919202 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967535 967535 0 0.0
(read/write) 443240 443240 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205224 205224 0 0.0
.flash.text 962151 962151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660864 660864 0 0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575972 575972 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576616 576616 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8639540 8639540 0 0.0
(read/write) 390961 390961 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260976 260976 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532716 532716 0 0.0
.text 7267860 7267860 0 0.0
thermostat-no-ble arm64 (read only) 2050428 2050428 0 0.0
(read/write) 145969 145969 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73160 73160 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706080 1706080 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348784 2349040 256 0.0
.bss 186084 186276 192 0.1
.data 5296 5296 0 0.0
.text 1311360 1311616 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333984 2332160 -1824 -0.1
.bss 180688 180088 -600 -0.3
.data 5576 5576 0 0.0
.text 1296584 1294760 -1824 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304568 2300032 -4536 -0.2
.bss 180592 180000 -592 -0.3
.data 5568 5544 -24 -0.4
.text 1267168 1262632 -4536 -0.4
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2054152 256 0.0
.bss 156876 157068 192 0.1
.data 4864 4864 0 0.0
.text 1016496 1016752 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942175 942175 0 0.0
bss 118776 118776 0 0.0
rodata 108708 108708 0 0.0
text 637104 637104 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 927675 927675 0 0.0
bss 115820 115820 0 0.0
rodata 101160 101160 0 0.0
text 632500 632500 0 0.0
nrf52840dongle_nrf52840 (read/write) 992855 992855 0 0.0
bss 121616 121616 0 0.0
rodata 113464 113464 0 0.0
text 669304 669304 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852034 852034 0 0.0
bss 115564 115564 0 0.0
rodata 101884 101884 0 0.0
text 554024 554024 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912683 912683 0 0.0
bss 118828 118828 0 0.0
rodata 103768 103768 0 0.0
text 612680 612680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822702 822702 0 0.0
bss 115648 115648 0 0.0
rodata 96992 96992 0 0.0
text 529636 529636 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915339 915339 0 0.0
bss 118576 118576 0 0.0
rodata 104152 104152 0 0.0
text 615148 615148 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910523 910523 0 0.0
bss 118600 118600 0 0.0
rodata 103256 103256 0 0.0
text 611176 611176 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533644 533644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451320 451320 0 0.0
p6 all-clusters-app default (read/write) 2407448 2407448 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1365712 1365712 0 0.0
light-app default (read/write) 2330256 2330256 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288520 1288520 0 0.0
lock-app default (read/write) 2299664 2299664 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257928 1257928 0 0.0
qpg lighting-app qpg6105+debug (read only) 567092 567092 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561772 561772 0 0.0
lock-app qpg6105+debug (read only) 515752 515752 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510432 510432 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841062 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588184 588184 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@bzbarsky-apple
Copy link
Contributor

@ATmobica I can't merge it because Github thinks it has conflicts?

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 49ae19d to 487b33b Compare January 26, 2022 08:00
@ATmobica
Copy link
Contributor Author

ATmobica commented Jan 26, 2022 •
edited
Loading

@bzbarsky-apple Conflicts resolved

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #13629: Size comparison from 02631e5 to 487b33b

Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 02631e5 487b33b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 579910 579910 0 0.0
.app_xip_area 484832 484832 0 0.0
.bss 77824 77824 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842596 842596 0 0.0
(read/write) 127364 127364 0 0.0
.bss 125464 125464 0 0.0
.data 1900 1900 0 0.0
.text 842588 842588 0 0.0
BRD4161A+rpc (read only) 829952 829952 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142024 142024 0 0.0
.data 2000 2000 0 0.0
.text 829944 829944 0 0.0
window-app BRD4161A (read only) 815228 815228 0 0.0
(read/write) 126020 126020 0 0.0
.bss 124164 124164 0 0.0
.data 1856 1856 0 0.0
.text 815220 815220 0 0.0
k32w light k32w061+release (read/write) 664644 664644 0 0.0
.bss 77596 77596 0 0.0
.data 1868 1868 0 0.0
.text 579380 579380 0 0.0
lock k32w061+release (read/write) 665696 665696 0 0.0
.bss 77860 77860 0 0.0
.data 1892 1892 0 0.0
.text 580144 580144 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8728948 8728948 0 0.0
(read/write) 392273 392273 0 0.0
.bss 56241 56241 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261872 261872 0 0.0
.dynamic 560 560 0 0.0
.got 69280 69280 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534444 534444 0 0.0
.text 7352756 7352756 0 0.0
thermostat-no-ble arm64 (read only) 2058404 2058404 0 0.0
(read/write) 147457 147457 0 0.0
.bss 65857 65857 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131396 0 0.0
.text 1711248 1711248 0 0.0
p6 all-clusters-app default (read/write) 2414704 2414704 0 0.0
.bss 117892 117892 0 0.0
.data 2584 2584 0 0.0
.text 1372968 1372968 0 0.0
light-app default (read/write) 2338168 2338168 0 0.0
.bss 105652 105652 0 0.0
.data 2408 2408 0 0.0
.text 1296432 1296432 0 0.0
lock-app default (read/write) 2303720 2303720 0 0.0
.bss 105396 105396 0 0.0
.data 2360 2360 0 0.0
.text 1261984 1261984 0 0.0
qpg lighting-app qpg6105+debug (read only) 571484 571484 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89808 89808 0 0.0
.data 1060 1060 0 0.0
.text 566164 566164 0 0.0
lock-app qpg6105+debug (read only) 517724 517724 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89280 89280 0 0.0
.data 992 992 0 0.0
.text 512404 512404 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 847718 847718 0 0.0
bss 87608 87608 0 0.0
noinit 37160 37160 0 0.0
text 592560 592560 0 0.0

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 487b33b to 57bdb23 Compare January 27, 2022 08:14
@ATmobica
Copy link
Contributor Author

@andy31415 @bzbarsky-apple @woody-apple
Can we finally merge this PR? I had to rebase and resolve conflicts due to the changes in the clusters many times. With these changes no more CmakeList files changes will be required.

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jan 27, 2022 •
edited
Loading

Needs to be rebased on top of #14384 once that lands to fix CI. :(

I'm really sorry about the pain here....

@ATmobica
Copy link
Contributor Author

Needs to be rebased on top of #14384 once that lands to fix CI. :(

I'm really sorry about the pain here....

@bzbarsky-apple Ok, I'm waiting to merge this fix.

@github-actions
Copy link

PR #13629: Size comparison from c62489b to 57bdb23

Full report (11 builds for k32w, linux, p6, qpg, telink)
platform target config section c62489b 57bdb23 change % change
k32w light k32w061+release (read/write) 665224 665224 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579928 579928 0 0.0
lock k32w061+release (read/write) 666192 666192 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580608 580608 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8935692 8935692 0 0.0
(read/write) 394801 394801 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264512 264512 0 0.0
.dynamic 560 560 0 0.0
.got 70024 70024 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544356 544356 0 0.0
.text 7541700 7541700 0 0.0
thermostat-no-ble arm64 (read only) 2082804 2082804 0 0.0
(read/write) 150977 150977 0 0.0
.bss 68689 68689 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74208 74208 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1733616 0 0.0
p6 all-clusters-app default (read/write) 2418240 2418240 0 0.0
.bss 117932 117932 0 0.0
.data 2592 2592 0 0.0
.text 1376504 1376504 0 0.0
light-app default (read/write) 2339064 2339064 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297328 1297328 0 0.0
lock-app default (read/write) 2304584 2304584 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262848 1262848 0 0.0
qpg lighting-app qpg6105+debug (read only) 572036 572036 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566716 566716 0 0.0
lock-app qpg6105+debug (read only) 518164 518164 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512844 512844 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848810 848810 0 0.0
bss 87164 87164 0 0.0
noinit 37160 37160 0 0.0
text 594022 594022 0 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 57bdb23 to 56c6452 Compare January 27, 2022 08:59
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #13629: Size comparison from ba45194 to 56c6452

Increases (1 build for mbed)
platform target config section ba45194 56c6452 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2357384 2357640 256 0.0
.bss 189588 189780 192 0.1
.text 1319984 1320240 256 0.0
Decreases (2 builds for mbed)
platform target config section ba45194 56c6452 change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2341088 2339328 -1760 -0.1
.bss 181104 180504 -600 -0.3
.text 1303688 1301928 -1760 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2307840 2303304 -4536 -0.2
.bss 181000 180408 -592 -0.3
.data 5568 5552 -16 -0.3
.text 1270440 1265904 -4536 -0.4
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ba45194 56c6452 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 580442 0 0.0
.app_xip_area 485336 485336 0 0.0
.bss 77852 77852 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538446 538446 0 0.0
.app_xip_area 444884 444884 0 0.0
.bss 76348 76348 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843492 843492 0 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843484 843484 0 0.0
BRD4161A+rpc (read only) 830864 830864 0 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830856 830856 0 0.0
window-app BRD4161A (read only) 816108 816108 0 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 816100 816100 0 0.0
esp32 all-clusters-app c3devkit (read only) 923298 923298 0 0.0
(read/write) 1384986 1384986 0 0.0
.dram0.bss 70880 70880 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 180936 180936 0 0.0
.flash.text 923298 923298 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972227 972227 0 0.0
(read/write) 452016 452016 0 0.0
.dram0.bss 75624 75624 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 210232 210232 0 0.0
.flash.text 966843 966843 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665224 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579928 579928 0 0.0
lock k32w061+release (read/write) 666192 666192 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580608 580608 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8935692 8935692 0 0.0
(read/write) 394801 394801 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264512 264512 0 0.0
.dynamic 560 560 0 0.0
.got 70024 70024 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544356 544356 0 0.0
.text 7541700 7541700 0 0.0
thermostat-no-ble arm64 (read only) 2082804 2082804 0 0.0
(read/write) 151873 151873 0 0.0
.bss 69585 69585 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74208 74208 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1733616 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357384 2357640 256 0.0
.bss 189588 189780 192 0.1
.data 5296 5296 0 0.0
.text 1319984 1320240 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2339328 -1760 -0.1
.bss 181104 180504 -600 -0.3
.data 5584 5584 0 0.0
.text 1303688 1301928 -1760 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307840 2303304 -4536 -0.2
.bss 181000 180408 -592 -0.3
.data 5568 5552 -16 -0.3
.text 1270440 1265904 -4536 -0.4
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294044 2294044 0 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256616 1256616 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 983707 0 0.0
bss 120860 120860 0 0.0
rodata 116480 116480 0 0.0
text 668576 668576 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 967571 0 0.0
bss 117904 117904 0 0.0
rodata 108016 108016 0 0.0
text 663248 663248 0 0.0
nrf52840dongle_nrf52840 (read/write) 999827 999827 0 0.0
bss 122032 122032 0 0.0
rodata 115332 115332 0 0.0
text 674004 674004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 892930 0 0.0
bss 117648 117648 0 0.0
rodata 109780 109780 0 0.0
text 584756 584756 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916323 916323 0 0.0
bss 119240 119240 0 0.0
rodata 105120 105120 0 0.0
text 614560 614560 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826358 0 0.0
bss 116056 116056 0 0.0
rodata 98344 98344 0 0.0
text 531512 531512 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919187 0 0.0
bss 118992 118992 0 0.0
rodata 105632 105632 0 0.0
text 617096 617096 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914371 0 0.0
bss 119016 119016 0 0.0
rodata 104736 104736 0 0.0
text 613132 613132 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2418240 2418240 0 0.0
.bss 117932 117932 0 0.0
.data 2592 2592 0 0.0
.text 1376504 1376504 0 0.0
light-app default (read/write) 2339064 2339064 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297328 1297328 0 0.0
lock-app default (read/write) 2304584 2304584 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262848 1262848 0 0.0
qpg lighting-app qpg6105+debug (read only) 572036 572036 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566716 566716 0 0.0
lock-app qpg6105+debug (read only) 518164 518164 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512844 512844 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848158 848158 0 0.0
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592932 592932 0 0.0

@ATmobica ATmobica force-pushed the mbed-commisioning-fix branch from 56c6452 to 360e938 Compare January 27, 2022 12:51
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #13629: Size comparison from 40cc421 to 360e938

Increases (1 build for mbed)
platform target config section 40cc421 360e938 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2357384 2357640 256 0.0
.bss 189588 189780 192 0.1
.text 1319984 1320240 256 0.0
Decreases (2 builds for mbed)
platform target config section 40cc421 360e938 change % change
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2341088 2339328 -1760 -0.1
.bss 181104 180504 -600 -0.3
.text 1303688 1301928 -1760 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2307840 2303304 -4536 -0.2
.bss 181000 180408 -592 -0.3
.data 5568 5552 -16 -0.3
.text 1270440 1265904 -4536 -0.4
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 40cc421 360e938 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 580442 0 0.0
.app_xip_area 485336 485336 0 0.0
.bss 77852 77852 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538446 538446 0 0.0
.app_xip_area 444884 444884 0 0.0
.bss 76348 76348 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843492 843492 0 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843484 843484 0 0.0
BRD4161A+rpc (read only) 830864 830864 0 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830856 830856 0 0.0
window-app BRD4161A (read only) 816108 816108 0 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 816100 816100 0 0.0
esp32 all-clusters-app c3devkit (read only) 923298 923298 0 0.0
(read/write) 1384986 1384986 0 0.0
.dram0.bss 70880 70880 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 180936 180936 0 0.0
.flash.text 923298 923298 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972227 972227 0 0.0
(read/write) 452016 452016 0 0.0
.dram0.bss 75624 75624 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 210232 210232 0 0.0
.flash.text 966843 966843 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665224 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579928 579928 0 0.0
lock k32w061+release (read/write) 666192 666192 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580608 580608 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6537388 6537388 0 0.0
(read/write) 275153 275153 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 174424 174424 0 0.0
.dynamic 560 560 0 0.0
.got 40472 40472 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 377140 377140 0 0.0
.text 5598724 5598724 0 0.0
thermostat-no-ble arm64 (read only) 2082804 2082804 0 0.0
(read/write) 151873 151873 0 0.0
.bss 69585 69585 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74208 74208 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1733616 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357384 2357640 256 0.0
.bss 189588 189780 192 0.1
.data 5296 5296 0 0.0
.text 1319984 1320240 256 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2339328 -1760 -0.1
.bss 181104 180504 -600 -0.3
.data 5584 5584 0 0.0
.text 1303688 1301928 -1760 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307840 2303304 -4536 -0.2
.bss 181000 180408 -592 -0.3
.data 5568 5552 -16 -0.3
.text 1270440 1265904 -4536 -0.4
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294044 2294044 0 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256616 1256616 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 983707 0 0.0
bss 120860 120860 0 0.0
rodata 116480 116480 0 0.0
text 668576 668576 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 967571 0 0.0
bss 117904 117904 0 0.0
rodata 108016 108016 0 0.0
text 663248 663248 0 0.0
nrf52840dongle_nrf52840 (read/write) 999827 999827 0 0.0
bss 122032 122032 0 0.0
rodata 115332 115332 0 0.0
text 674004 674004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 892930 0 0.0
bss 117648 117648 0 0.0
rodata 109780 109780 0 0.0
text 584756 584756 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916323 916323 0 0.0
bss 119240 119240 0 0.0
rodata 105120 105120 0 0.0
text 614560 614560 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826358 0 0.0
bss 116056 116056 0 0.0
rodata 98344 98344 0 0.0
text 531512 531512 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919187 0 0.0
bss 118992 118992 0 0.0
rodata 105632 105632 0 0.0
text 617096 617096 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914371 0 0.0
bss 119016 119016 0 0.0
rodata 104736 104736 0 0.0
text 613132 613132 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2418240 2418240 0 0.0
.bss 117932 117932 0 0.0
.data 2592 2592 0 0.0
.text 1376504 1376504 0 0.0
light-app default (read/write) 2339064 2339064 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297328 1297328 0 0.0
lock-app default (read/write) 2304584 2304584 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262848 1262848 0 0.0
qpg lighting-app qpg6105+debug (read only) 572036 572036 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566716 566716 0 0.0
lock-app qpg6105+debug (read only) 518164 518164 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512844 512844 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848158 848158 0 0.0
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592932 592932 0 0.0

@woody-apple woody-apple merged commit fe6adc3 into project-chip:master Jan 27, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@ATmobica @selissia
[Mbed] Fix device commisioning - BLE adv and LWIP PKTINFO (project-ch…
81ea0a5 
…ip#13629)

* Add LWIP recvinfo flag to mbed application

* Add chip_configure_data_model to lock-app and lighting-app cmake

* Add start BLE advertising after push button
Remove unnecessary code in AppTask.cpp files

* Update mbed docs
@ATmobica ATmobica deleted the mbed-commisioning-fix branch February 1, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@pan- pan- pan- approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples fast track
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ATmobica @andy31415 @bzbarsky-apple @woody-apple @pan- @Damian-Nordic