-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mbed] Add OTA-requestor-app and DFU support #12616
Conversation
DFU image processing initconnectedhomeip/src/lib/shell/commands/DFUManager_mbed.h Lines 87 to 97 in 0f4cdda
This comment was generated by todo based on a
|
Write imageconnectedhomeip/src/lib/shell/commands/DFUManager_mbed.h Lines 97 to 107 in 0f4cdda
This comment was generated by todo based on a
|
PR #12616: Size comparison from bfdbd45 to 0f4cdda Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
@woody-apple @holbrookt @carol-apple |
@woody-apple @holbrookt @carol-apple |
PR #12616: Size comparison from bfdbd45 to a19fb29 Increases above 0.2%:
Increases (11 builds for efr32, linux)
Decreases (27 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, platform maintainer, adding platform code.
@ATmobica awesome news, thank you! @carol-apple @franck-apple |
a19fb29
to
e884c32
Compare
PR #12616: Size comparison from f647393 to e884c32 Full report (29 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
e884c32
to
9910ff8
Compare
PR #12616: Size comparison from f18d8b7 to 9910ff8 Full report (29 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
9910ff8
to
712b44f
Compare
PR #12616: Size comparison from 41700bd to 712b44f Full report (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
PR #12616: Size comparison from 41700bd to d9fe34e Increases above 0.2%:
Increases (8 builds for efr32, esp32, linux, nrfconnect)
Decreases (23 builds for efr32, esp32, mbed, nrfconnect, p6, qpg, telink)
Full report (29 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
87790f7
to
21a6695
Compare
PR #12616: Size comparison from d24eff1 to 21a6695 Decreases (4 builds for mbed)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
@ATmobica Need to fix style? And is this supposed to still be draft? |
@bzbarsky-apple Sure, we restyle changes and the end of implementation. Yes, it's still a draft we wait to merge some necessary changes in Mbed-os implementation. The DFU service for the Mbed platform is also in progress. I hope we will finish this week. |
21a6695
to
daae1d3
Compare
PR #12616: Size comparison from bf7feea to 8384f53 Decreases (4 builds for mbed)
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #12616: Size comparison from fba51b9 to eeb4dc3 Increases (4 builds for mbed)
Decreases (2 builds for mbed)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
eeb4dc3
to
c6521e2
Compare
PR #12616: Size comparison from b700fb8 to c6521e2 Full report (25 builds for efr32, k32w, linux, nrfconnect, p6, qpg, telink)
|
c6521e2
to
7fa3ff8
Compare
PR #12616: Size comparison from 786fdfa to 7fa3ff8 Increases above 0.2%:
Increases (4 builds for mbed)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
6b9d181
to
113896f
Compare
PR #12616: Size comparison from 6e1a741 to 113896f Increases above 0.2%:
Increases (4 builds for mbed)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
113896f
to
ca73f97
Compare
PR #12616: Size comparison from e25a501 to ca73f97 Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
ca73f97
to
30a8e28
Compare
PR #12616: Size comparison from 1b49aee to 30a8e28 Increases above 0.2%:
Increases (4 builds for mbed)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #12616: Size comparison from 1b49aee to 2b66fa5 Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
2b66fa5
to
a5500d4
Compare
Add Mbed MCUboot to third_party Add Mbed bootloader application Add build applicaiton with bootloader option to mbed_example.sh script Improve mbed launch tasks in launch.json Move capsense lib including to common cmake file Update mbed-os-posix-socket module
a5500d4
to
d82c41e
Compare
d82c41e
to
beb91d0
Compare
PR #12616: Size comparison from f1808b7 to beb91d0 Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
Fast tracking, given > 3 days for review and platform changes. |
* Add Mbed OTA requestor app Add Mbed MCUboot to third_party Add Mbed bootloader application Add build applicaiton with bootloader option to mbed_example.sh script Improve mbed launch tasks in launch.json Move capsense lib including to common cmake file Update mbed-os-posix-socket module * Add debug Mbed bootloader option to launch.json * Mbed MCUboot update
The changes in project-chip#14013 probably did not mean to roll back the submodule update from project-chip#12616.
Problem
Adding OTA Requestor application for Mbed platform
Change overview
Add OTA requestor app - simply commissioning with AnnounceOtaProvider event handling
Implement Mbed version of OTARequestor, OTADownloader, OTAImageProcessor (only stub)
Testing
Tested manually
Run OTA provider Linux app and commissioned using Python device controller.
Flashed requestor on Mbed supported board and commissioned using Python device controller.
Fired a ZCL command AnnounceOtaProvider to start and apply for data transfer
Required changes: