-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clusters] Fix scheduled actions in clusters #10001
[clusters] Fix scheduled actions in clusters #10001
Conversation
FYI @mkardous-silabs |
PR project-chip#9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
deb3dba
to
4966a3e
Compare
Might be worth while to update level-control to use the updated version EventControlHandler instead adding back the old code that use depracted event management through generated code that isn't generated anymore. |
@mkardous-silabs Yes, but there are more clusters that need to be updated, so I would prefer to fix the regression and later start transitioning subsequent clusters. |
@Damian-Nordic Fair enough, but if you have the time, it seems like an opportune moment to update the level-control cluster at the same time to the updated implementation. |
Size increase report for "gn_qpg-example-build" from 3e86fbb
Full report output
|
Size increase report for "nrfconnect-example-build" from 3e86fbb
Full report output
|
Size increase report for "esp32-example-build" from 3e86fbb
Full report output
|
PR #9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
Cherrypicked with request/approval from Chaitanya |
PR project-chip#9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
Problem
PR #9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken.
Change overview
Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another.
Also, add a cirque test for LevelControl.MoveToLevel.
Testing
Tested by Cirque and using nRF Connect lighting-app.