-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multi-endpoint for the color control server #9469
Support for multi-endpoint for the color control server #9469
Conversation
1f06c9e
to
55bffd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a solution that does not utilize STL maps.
Have been discussing with @bzbarsky-apple strategies for how we could solve the problem in this PR. |
I agree that a conversation might be useful just to agree on cluster design since dynamic clusters make everything slightly more complicated. |
Had a discussion with @mkardous-silabs and discussed a pathway to proceed for now given the lack of true support for dynamic endpoints in the code today. For now, he'll pivot the PR to just supporting fixed endpoints, and at a later time, we'll tackle dynamic. |
Size increase report for "gn_qpg-example-build" from 84e6e1a
Full report output
|
Size increase report for "nrfconnect-example-build" from 84e6e1a
Full report output
|
Size increase report for "esp32-example-build" from 84e6e1a
Full report output
|
…#9469) * Color Control server refactor to use accessors functions for attributes * Added support for static multi-end point for color-control * Refactor color-control-server to c++ standards * Ember event refactor * Removed includes that were moved to another directory * Removed static attributes * Removed unordered map
PR project-chip#9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
PR project-chip#9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
PR #9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
PR #9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
PR project-chip#9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
PR project-chip#9469 changed the implementation of EventControlHandler function from af-event.cpp, but only updated Color Control Cluster code to use the new approach. As a result, all other clusters using scheduled actions, such as LevelControl.MoveToLevel, got broken. Make sure both methods of initializing cluster events are supported until all clusters are aligned one way or another. Also, add a cirque test for LevelControl.MoveToLevel.
Problem
Change overview
Testing