Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestFailsafeContext crashes when running fake platform tests (host tests are ok) #20089

Closed
andy31415 opened this issue Jun 29, 2022 · 6 comments · Fixed by #20091
Closed

TestFailsafeContext crashes when running fake platform tests (host tests are ok) #20089

andy31415 opened this issue Jun 29, 2022 · 6 comments · Fixed by #20091

Comments

@andy31415
Copy link
Contributor

Problem

After merging #20010 master branch seems to consistently crash on linux test (2 crashes in a row, 0 crashes in several previous builds):

INFO    INF Test 1/1: [ RUN] TestFailSafeContext
1508
INFO    ERR ../../third_party/pigweed/repo/targets/host/run_test exited with status 134
1509
INFO    OUT [63884]
1510
INFO    Aborted (core dumped)
1511
INFO    INF Test 1/1: [FAIL] TestFailSafeContext

See https://github.com/project-chip/connectedhomeip/runs/7103687029?check_suite_focus=true

Proposed Solution

Figure out the reason.
@andy31415
Copy link
Contributor Author

Tried to reproduce locally and could not.

@andy31415
Copy link
Contributor Author

failed 7 minutes ago in 1h 30m 14s ... could this be a 90 minute timeout?

@andy31415
Copy link
Contributor Author

https://github.com/project-chip/connectedhomeip/runs/7103752299?check_suite_focus=true finished in 1:16, so likely not a timeout issue.

tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jun 29, 2022
@tcarmelveilleux
Temporarily disable flaky TestFailSafeContext
5b90833 
- TestFailSafeContext is now crashy, even though it was just
  only recently moved in project-chip#20010 and no functional changes were
  done.
- This may be related to other flakiness seen recently on
  random tests.

This PR disables tests that are mostly covered by other
test cases and for trivial logic that we won't touch tomorrow.

Issue project-chip#20089
@andy31415
Copy link
Contributor Author

Just reproduced. It is not the x64 tests, but the fake tests. Run linux-fake-tests with build_examples.py

@andy31415
Copy link
Contributor Author 

'#0:','FailSafeContext tests'
'#2:','Setup                                  ','PASSED'
'#3:','Test PlatformMgr::Init                 ','PASSED'
../../src/app/tests/TestFailSafeContext.cpp:64: assertion failed: "err == CHIP_NO_ERROR"
../../src/app/tests/TestFailSafeContext.cpp:65: assertion failed: "failSafeContext.IsFailSafeArmed() == true"
Aborted (core dumped)

@andy31415 andy31415 changed the title TestFailsafeContext crashes TestFailsafeContext crashes when running fake platform tests (host tests are ok) Jun 29, 2022
@andy31415
Copy link
Contributor Author

ArmFailsafe seems to fail on startTimer, where LayerImplSelect::mLayerState is Uninitialized. Unsure what must initialize things.

tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jun 29, 2022
@tcarmelveilleux
Temporarily disable flaky TestFailSafeContext
1213330 
- TestFailSafeContext is now crashy, even though it was just
  only recently moved in project-chip#20010 and no functional changes were
  done.
- This may be related to other flakiness seen recently on
  random tests.

This PR disables tests that are mostly covered by other
test cases and for trivial logic that we won't touch tomorrow.

Issue project-chip#20089
@tcarmelveilleux tcarmelveilleux mentioned this issue Jun 29, 2022
Closed
@andy31415 andy31415 mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fake platform argument to running fake tests, exclude TestFailsaf… andy31415/connectedhomeip
1 participant
@andy31415