Skip to content

Commit

Permalink
Temporarily disable flaky TestFailSafeContext
Browse files Browse the repository at this point in the history
- TestFailSafeContext is now crashy, even though it was just
  only recently moved in project-chip#20010 and no functional changes were
  done.
- This may be related to other flakiness seen recently on
  random tests.

This PR disables tests that are mostly covered by other
test cases and for trivial logic that we won't touch tomorrow.

Issue project-chip#20089
  • Loading branch information
tcarmelveilleux committed Jun 29, 2022
1 parent b9068aa commit 5b90833
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/app/tests/TestFailSafeContext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,17 @@ constexpr FabricIndex kTestAccessingFabricIndex2 = 2;

static void TestPlatformMgr_Init(nlTestSuite * inSuite, void * inContext)
{
// TODO(#20089): Bring-back after we figure-out what crashes
#if 0
CHIP_ERROR err = PlatformMgr().InitChipStack();
NL_TEST_ASSERT(inSuite, err == CHIP_NO_ERROR);
#endif
}

static void TestFailSafeContext_ArmFailSafe(nlTestSuite * inSuite, void * inContext)
{
// TODO(#20089): Bring-back after we figure-out what crashes
#if 0
CHIP_ERROR err = CHIP_NO_ERROR;

chip::app::FailSafeContext failSafeContext;
Expand All @@ -69,10 +74,13 @@ static void TestFailSafeContext_ArmFailSafe(nlTestSuite * inSuite, void * inCont

failSafeContext.DisarmFailSafe();
NL_TEST_ASSERT(inSuite, failSafeContext.IsFailSafeArmed() == false);
#endif
}

static void TestFailSafeContext_NocCommandInvoked(nlTestSuite * inSuite, void * inContext)
{
// TODO(#20089): Bring-back after we figure-out what crashes
#if 0
CHIP_ERROR err = CHIP_NO_ERROR;

chip::app::FailSafeContext failSafeContext;
Expand All @@ -91,6 +99,7 @@ static void TestFailSafeContext_NocCommandInvoked(nlTestSuite * inSuite, void *
NL_TEST_ASSERT(inSuite, failSafeContext.UpdateNocCommandHasBeenInvoked() == true);

failSafeContext.DisarmFailSafe();
#endif
}

/**
Expand Down

0 comments on commit 5b90833

Please sign in to comment.