-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable flaky TestFailSafeContext #20090
Closed
tcarmelveilleux
wants to merge
1
commit into
project-chip:master
from
tcarmelveilleux:disable-fail-safe-test
Closed
Temporarily disable flaky TestFailSafeContext #20090
tcarmelveilleux
wants to merge
1
commit into
project-chip:master
from
tcarmelveilleux:disable-fail-safe-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TestFailSafeContext is now crashy, even though it was just only recently moved in project-chip#20010 and no functional changes were done. - This may be related to other flakiness seen recently on random tests. This PR disables tests that are mostly covered by other test cases and for trivial logic that we won't touch tomorrow. Issue project-chip#20089
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
June 29, 2022 02:49
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 29, 2022 02:49
PR #20090: Size comparison from b9068aa to 1213330 Increases (1 build for cc13x2_26x2)
Decreases (3 builds for cc13x2_26x2, esp32, k32w)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
only recently moved in Properly handle crashes/reboots during FabricTable commit #20010 and no functional changes were
done.
random tests.
Issue #20089
Change overview
This PR disables tests that are mostly covered by other
test cases and for trivial logic that we won't touch tomorrow.
Testing