-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using buttons on m5stack all-clusters-app calls into Matter stack in a thread-unsafe way #15065
Comments
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Feb 11, 2022
This was referenced Feb 11, 2022
bzbarsky-apple
added a commit
that referenced
this issue
Feb 11, 2022
mspang
pushed a commit
to mspang/connectedhomeip
that referenced
this issue
Feb 16, 2022
…roject-chip#15066) Fixes project-chip#15065 (cherry picked from commit 379d144)
mspang
added a commit
that referenced
this issue
Feb 16, 2022
…15066) (#15234) Fixes #15065 (cherry picked from commit 379d144) Co-authored-by: Boris Zbarsky <[email protected]>
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this issue
Feb 17, 2022
Fixes project-chip#15065 (cherry picked from commit 379d144) Co-authored-by: Boris Zbarsky <[email protected]>
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this issue
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Pushing the buttons on the m5stack running all-clusters-app to affect its state (e.g. Device->Light Bulb->Endpoint: 1->Cluster: OnOff -> Attribute: OnOff -> Toggle) can end up calling into the Matter stack (in this case calling
emberAfWriteServerAttribute
).But it does this on the m5stack's UI thread, not on the Matter thread. So we can get racy behavior of the sort observed in #14596
Specifically, if I log
pcTaskGetName(xTaskGetCurrentTaskHandle())
inMatterPostAttributeChangeCallback
when I do the above toggle, I get "main". If I use an over-the-wire toggle command I get "CHIP".Proposed Solution
Fix all-clusters-app to queue all of its Matter interaction to the Matter thread.
The text was updated successfully, but these errors were encountered: