Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[esp] Add status screen to all-clusters-app on M5Stack #14986

Merged
merged 7 commits into from
Feb 10, 2022
Merged

[esp] Add status screen to all-clusters-app on M5Stack #14986

merged 7 commits into from
Feb 10, 2022

Conversation

turon
Copy link
Contributor

@turon turon commented Feb 9, 2022 •
edited
Loading

Problem

It can be difficult to glean basic information about a physical Matter node.

Change overview

Add a "Status" screen to ESP / M5Stack platform.
This screen displays whether the device is commissioned or not, and if it is shows info about the first fabric in the table:

  • Fabric Index
  • Fabric ID
  • Node ID
  • UDP Port
  • IPv4 address
  • IPv6 Link Local address
  • IPv6 ULA address

Testing

Tested manually on desk:

  1. Erase/flash.
    Verify Fabric : none
    Verify IP : none
  2. Commission over BLE.
    Verify Fabric : 1
    Verify IP : [live address]
  3. Factory reset.
    Verify Fabric : none
    Verify IP : none
  4. Recommission over BLE.
    Verify Fabric : 1
    Verify IP : [live address]

CI should cover the rest.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14986: Size comparison from 14bab88 to e8764af

Increases (2 builds for esp32, linux)
platform target config section 14bab88 e8764af change % change
esp32 all-clusters-app m5stack (read only) 989271 991723 2452 0.2
(read/write) 463352 463768 416 0.1
.flash.rodata 225784 226200 416 0.2
.flash.text 983887 986339 2452 0.2
linux chip-tool-ipv6only arm64 .rodata 401876 402004 128 0.0
Decreases (1 build for linux)
platform target config section 14bab88 e8764af change % change
linux chip-tool-ipv6only arm64 (read only) 7436332 7435820 -512 -0.0
.text 6395284 6394644 -640 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 14bab88 e8764af change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600590 600590 0 0.0
.app_xip_area 506172 506172 0 0.0
.bss 77116 77116 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557278 557278 0 0.0
.app_xip_area 464420 464420 0 0.0
.bss 75588 75588 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578178 578178 0 0.0
.app_xip_area 476072 476072 0 0.0
.bss 84508 84508 0 0.0
.data 556 556 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 904648 904648 0 0.0
(read/write) 127224 127224 0 0.0
.bss 125184 125184 0 0.0
.data 2036 2036 0 0.0
.text 904640 904640 0 0.0
BRD4161A+rpc (read only) 892108 892108 0 0.0
(read/write) 143880 143880 0 0.0
.bss 141744 141744 0 0.0
.data 2136 2136 0 0.0
.text 892100 892100 0 0.0
window-app BRD4161A (read only) 840048 840048 0 0.0
(read/write) 125288 125288 0 0.0
.bss 123384 123384 0 0.0
.data 1904 1904 0 0.0
.text 840040 840040 0 0.0
esp32 all-clusters-app c3devkit (read only) 941264 941264 0 0.0
(read/write) 1398354 1398354 0 0.0
.dram0.bss 66248 66248 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 198952 198952 0 0.0
.flash.text 941264 941264 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 989271 991723 2452 0.2
(read/write) 463352 463768 416 0.1
.dram0.bss 71392 71392 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 225784 226200 416 0.2
.flash.text 983887 986339 2452 0.2
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 680060 680060 0 0.0
.bss 76488 76488 0 0.0
.data 1908 1908 0 0.0
.text 595864 595864 0 0.0
lock k32w061+release (read/write) 684940 684940 0 0.0
.bss 76888 76888 0 0.0
.data 1952 1952 0 0.0
.text 600300 600300 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7436332 7435820 -512 -0.0
(read/write) 301809 301809 0 0.0
.bss 50513 50513 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 199240 199240 0 0.0
.dynamic 560 560 0 0.0
.got 47040 47040 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 401876 402004 128 0.0
.text 6395284 6394644 -640 -0.0
thermostat-no-ble arm64 (read only) 2133644 2133644 0 0.0
(read/write) 140529 140529 0 0.0
.bss 57537 57537 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74840 74840 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132684 132684 0 0.0
.text 1782912 1782912 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2394032 2394032 0 0.0
.bss 188316 188316 0 0.0
.data 5304 5304 0 0.0
.text 1356632 1356632 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2356176 2356176 0 0.0
.bss 180928 180928 0 0.0
.data 5632 5632 0 0.0
.text 1318776 1318776 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319896 2319896 0 0.0
.bss 180816 180816 0 0.0
.data 5608 5608 0 0.0
.text 1282496 1282496 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305836 2305836 0 0.0
.bss 178068 178068 0 0.0
.data 5424 5424 0 0.0
.text 1268408 1268408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1011763 1011763 0 0.0
bss 121244 121244 0 0.0
rodata 119336 119336 0 0.0
text 692176 692176 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 980591 980591 0 0.0
bss 118432 118432 0 0.0
rodata 110708 110708 0 0.0
text 671788 671788 0 0.0
nrf52840dongle_nrf52840 (read/write) 1027651 1027651 0 0.0
bss 122640 122640 0 0.0
rodata 118204 118204 0 0.0
text 696844 696844 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 918374 918374 0 0.0
bss 117808 117808 0 0.0
rodata 112576 112576 0 0.0
text 607200 607200 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 941675 941675 0 0.0
bss 119624 119624 0 0.0
rodata 108080 108080 0 0.0
text 635408 635408 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849170 849170 0 0.0
bss 116216 116216 0 0.0
rodata 101252 101252 0 0.0
text 551208 551208 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 941099 941099 0 0.0
bss 119344 119344 0 0.0
rodata 107440 107440 0 0.0
text 635672 635672 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 936439 936439 0 0.0
bss 119348 119348 0 0.0
rodata 106732 106732 0 0.0
text 631704 631704 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803903 803903 0 0.0
bss 111208 111208 0 0.0
rodata 78820 78820 0 0.0
text 536280 536280 0 0.0
p6 all-clusters-app default (read/write) 2479568 2479568 0 0.0
.bss 117576 117576 0 0.0
.data 2656 2656 0 0.0
.text 1437832 1437832 0 0.0
light-app default (read/write) 2386520 2386520 0 0.0
.bss 107224 107224 0 0.0
.data 2528 2528 0 0.0
.text 1344784 1344784 0 0.0
lock-app default (read/write) 2350136 2350136 0 0.0
.bss 106944 106944 0 0.0
.data 2488 2488 0 0.0
.text 1308400 1308400 0 0.0
qpg lighting-app qpg6105+debug (read only) 591164 591164 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88800 88800 0 0.0
.data 1112 1112 0 0.0
.text 585844 585844 0 0.0
lock-app qpg6105+debug (read only) 557056 557056 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88784 88784 0 0.0
.data 1064 1064 0 0.0
.text 551736 551736 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 870530 870530 0 0.0
bss 88576 88576 0 0.0
noinit 37160 37160 0 0.0
text 611140 611140 0 0.0

@pullapprove pullapprove bot requested a review from lazarkov February 9, 2022 23:09
@turon turon changed the title M5/status screen [esp] Add status screen to all-clusters-app on M5Stack Feb 9, 2022
cecille
cecille approved these changes Feb 10, 2022
View reviewed changes
examples/all-clusters-app/esp32/main/StatusScreen.cpp Outdated Show resolved Hide resolved
src/credentials/FabricTable.h Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14986: Size comparison from 14bab88 to 4794e53

Increases above 0.2%:

platform target config section 14bab88 4794e53 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600590 606682 6092 1.0
.app_xip_area 506172 508112 1940 0.4
.bss 77116 81268 4152 5.4
lock cyw930739m2evb_01 (read/write) 557278 563158 5880 1.1
.app_xip_area 464420 466148 1728 0.4
.bss 75588 79740 4152 5.5
ota-requestor cyw930739m2evb_01 (read/write) 578178 584170 5992 1.0
.app_xip_area 476072 477912 1840 0.4
.bss 84508 88660 4152 4.9
efr32 lighting-app BRD4161A (read/write) 127224 129000 1776 1.4
.bss 125184 126960 1776 1.4
BRD4161A+rpc (read/write) 143880 145656 1776 1.2
.bss 141744 143520 1776 1.3
window-app BRD4161A (read/write) 125288 127064 1776 1.4
.bss 123384 125160 1776 1.4
esp32 all-clusters-app c3devkit .dram0.bss 66248 68024 1776 2.7
m5stack (read only) 989271 993419 4148 0.4
(read/write) 463352 465504 2152 0.5
.dram0.bss 71392 73168 1776 2.5
.flash.text 983887 988035 4148 0.4
k32w light k32w061+release (read/write) 680060 683544 3484 0.5
.bss 76488 78264 1776 2.3
.text 595864 597572 1708 0.3
lock k32w061+release (read/write) 684940 688408 3468 0.5
.bss 76888 78664 1776 2.3
.text 600300 601992 1692 0.3
linux all-clusters-app debug (read only) 2337313 2345665 8352 0.4
(read/write) 139936 141696 1760 1.3
.bss 54560 56224 1664 3.0
.data 1216 1312 96 7.9
.text 1969650 1977746 8096 0.4
bridge-app debug+rpc (read only) 1708205 1713293 5088 0.3
(read/write) 84200 85864 1664 2.0
.bss 38960 40624 1664 4.3
.rodata 141132 141420 288 0.2
.text 1450549 1455349 4800 0.3
chip-tool debug (read only) 7517893 7571909 54016 0.7
(read/write) 197048 198520 1472 0.7
.bss 32232 33512 1280 4.0
.rodata 419701 421397 1696 0.4
.text 6697781 6749621 51840 0.8
chip-tool-ipv6only arm64 (read only) 7436332 7478116 41784 0.6
(read/write) 301809 303409 1600 0.5
.bss 50513 51777 1264 2.5
.rodata 401876 403020 1144 0.3
.text 6395284 6435220 39936 0.6
door-lock-app debug (read only) 1912881 1918513 5632 0.3
(read/write) 110520 112184 1664 1.5
.bss 42032 43696 1664 4.0
.text 1591762 1597138 5376 0.3
lighting-app debug+rpc (read only) 2035169 2042817 7648 0.4
(read/write) 115768 117464 1696 1.5
.bss 43008 44672 1664 3.9
.data 1432 1464 32 2.2
.rodata 164977 166385 1408 0.9
.text 1715378 1721618 6240 0.4
ota-provider-app debug (read only) 1716865 1858169 141304 8.2
(read/write) 81176 107928 26752 33.0
.bss 40992 43648 2656 6.5
.data.rel.ro 33464 57448 23984 71.7
.got 4240 4368 128 3.0
.rodata 152678 158430 5752 3.8
.text 1445506 1549170 103664 7.2
ota-requestor-app debug (read only) 1711537 1852849 141312 8.3
(read/write) 83096 109048 25952 31.2
.bss 42112 43936 1824 4.3
.data.rel.ro 34520 58504 23984 69.5
.got 4040 4176 136 3.4
.rodata 146295 151823 5528 3.8
.text 1448370 1552178 103808 7.2
shell debug (read only) 2310769 2319425 8656 0.4
(read/write) 141392 144720 3328 2.4
.bss 61824 65120 3296 5.3
.data 816 848 32 3.9
.rodata 206130 206674 544 0.3
.text 1948194 1956306 8112 0.4
thermostat-no-ble arm64 (read only) 2133644 2139804 6160 0.3
(read/write) 140529 142273 1744 1.2
.bss 57537 59201 1664 2.9
.data 1032 1040 8 0.8
.text 1782912 1788736 5824 0.3
tv-app debug (read only) 2508193 2515289 7096 0.3
(read/write) 139384 141056 1672 1.2
.bss 57184 58848 1664 2.9
.init_array 880 888 8 0.9
.rodata 197100 197676 576 0.3
.text 2138178 2144674 6496 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 188316 190092 1776 0.9
.data 5304 5320 16 0.3
lighting-app CY8CPROTO_062_4343W+release .bss 180928 182704 1776 1.0
lock-app CY8CPROTO_062_4343W+release .bss 180816 182592 1776 1.0
shell CY8CPROTO_062_4343W+release .bss 178068 179844 1776 1.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1011763 1015363 3600 0.4
bss 121244 123020 1776 1.5
text 692176 693908 1732 0.3
nrf52840dk_nrf52840+rpc (read/write) 980591 984183 3592 0.4
bss 118432 120208 1776 1.5
text 671788 673520 1732 0.3
nrf52840dongle_nrf52840 (read/write) 1027651 1031067 3416 0.3
bss 122640 124416 1776 1.4
nrf5340dk_nrf5340_cpuapp (read/write) 918374 921958 3584 0.4
bss 117808 119584 1776 1.5
text 607200 608944 1744 0.3
lock-app nrf52840dk_nrf52840 (read/write) 941675 945083 3408 0.4
bss 119624 121400 1776 1.5
nrf5340dk_nrf5340_cpuapp (read/write) 849170 852594 3424 0.4
bss 116216 117992 1776 1.5
text 551208 552756 1548 0.3
pump-app nrf52840dk_nrf52840 (read/write) 941099 944507 3408 0.4
bss 119344 121120 1776 1.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 936439 939847 3408 0.4
bss 119348 121124 1776 1.5
shell nrf52840dk_nrf52840 (read/write) 803903 805927 2024 0.3
bss 111208 112400 1192 1.1
p6 all-clusters-app default .bss 117576 119704 2128 1.8
.data 2656 2672 16 0.6
light-app default .bss 107224 109352 2128 2.0
lock-app default .bss 106944 109072 2128 2.0
qpg lighting-app qpg6105+debug (read only) 591164 592956 1792 0.3
.bss 88800 90536 1736 2.0
.text 585844 587636 1792 0.3
lock-app qpg6105+debug (read only) 557056 558708 1652 0.3
.bss 88784 90520 1736 2.0
.text 551736 553388 1652 0.3
telink lighting-app tlsr9518adk80d (read/write) 870530 874334 3804 0.4
bss 88576 90352 1776 2.0
text 611140 613082 1942 0.3
Increases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 14bab88 4794e53 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600590 606682 6092 1.0
.app_xip_area 506172 508112 1940 0.4
.bss 77116 81268 4152 5.4
lock cyw930739m2evb_01 (read/write) 557278 563158 5880 1.1
.app_xip_area 464420 466148 1728 0.4
.bss 75588 79740 4152 5.5
ota-requestor cyw930739m2evb_01 (read/write) 578178 584170 5992 1.0
.app_xip_area 476072 477912 1840 0.4
.bss 84508 88660 4152 4.9
efr32 lighting-app BRD4161A (read only) 904648 906792 2144 0.2
(read/write) 127224 129000 1776 1.4
.bss 125184 126960 1776 1.4
.text 904640 906784 2144 0.2
BRD4161A+rpc (read only) 892108 894236 2128 0.2
(read/write) 143880 145656 1776 1.2
.bss 141744 143520 1776 1.3
.text 892100 894228 2128 0.2
window-app BRD4161A (read only) 840048 841920 1872 0.2
(read/write) 125288 127064 1776 1.4
.bss 123384 125160 1776 1.4
.text 840040 841912 1872 0.2
esp32 all-clusters-app c3devkit (read only) 941264 943304 2040 0.2
(read/write) 1398354 1400250 1896 0.1
.dram0.bss 66248 68024 1776 2.7
.dram0.data 14252 14276 24 0.2
.flash.rodata 198952 199040 88 0.0
.flash.text 941264 943304 2040 0.2
m5stack (read only) 989271 993419 4148 0.4
(read/write) 463352 465504 2152 0.5
.dram0.bss 71392 73168 1776 2.5
.dram0.data 34048 34072 24 0.1
.flash.rodata 225784 226136 352 0.2
.flash.text 983887 988035 4148 0.4
k32w light k32w061+release (read/write) 680060 683544 3484 0.5
.bss 76488 78264 1776 2.3
.text 595864 597572 1708 0.3
lock k32w061+release (read/write) 684940 688408 3468 0.5
.bss 76888 78664 1776 2.3
.text 600300 601992 1692 0.3
linux all-clusters-app debug (read only) 2337313 2345665 8352 0.4
(read/write) 139936 141696 1760 1.3
.bss 54560 56224 1664 3.0
.data 1216 1312 96 7.9
.rodata 205413 205669 256 0.1
.text 1969650 1977746 8096 0.4
bridge-app debug+rpc (read only) 1708205 1713293 5088 0.3
(read/write) 84200 85864 1664 2.0
.bss 38960 40624 1664 4.3
.rodata 141132 141420 288 0.2
.text 1450549 1455349 4800 0.3
chip-tool debug (read only) 7517893 7571909 54016 0.7
(read/write) 197048 198520 1472 0.7
.bss 32232 33512 1280 4.0
.data.rel.ro 157560 157768 208 0.1
.rodata 419701 421397 1696 0.4
.text 6697781 6749621 51840 0.8
chip-tool-ipv6only arm64 (read only) 7436332 7478116 41784 0.6
(read/write) 301809 303409 1600 0.5
.bss 50513 51777 1264 2.5
.data.rel.ro 199240 199520 280 0.1
.got 47040 47088 48 0.1
.rodata 401876 403020 1144 0.3
.text 6395284 6435220 39936 0.6
door-lock-app debug (read only) 1912881 1918513 5632 0.3
(read/write) 110520 112184 1664 1.5
.bss 42032 43696 1664 4.0
.rodata 172626 172882 256 0.1
.text 1591762 1597138 5376 0.3
lighting-app debug+rpc (read only) 2035169 2042817 7648 0.4
(read/write) 115768 117464 1696 1.5
.bss 43008 44672 1664 3.9
.data 1432 1464 32 2.2
.rodata 164977 166385 1408 0.9
.text 1715378 1721618 6240 0.4
ota-provider-app debug (read only) 1716865 1858169 141304 8.2
(read/write) 81176 107928 26752 33.0
.bss 40992 43648 2656 6.5
.data.rel.ro 33464 57448 23984 71.7
.got 4240 4368 128 3.0
.rodata 152678 158430 5752 3.8
.text 1445506 1549170 103664 7.2
ota-requestor-app debug (read only) 1711537 1852849 141312 8.3
(read/write) 83096 109048 25952 31.2
.bss 42112 43936 1824 4.3
.data.rel.ro 34520 58504 23984 69.5
.got 4040 4176 136 3.4
.rodata 146295 151823 5528 3.8
.text 1448370 1552178 103808 7.2
shell debug (read only) 2310769 2319425 8656 0.4
(read/write) 141392 144720 3328 2.4
.bss 61824 65120 3296 5.3
.data 816 848 32 3.9
.rodata 206130 206674 544 0.3
.text 1948194 1956306 8112 0.4
thermostat-no-ble arm64 (read only) 2133644 2139804 6160 0.3
(read/write) 140529 142273 1744 1.2
.bss 57537 59201 1664 2.9
.data 1032 1040 8 0.8
.data.rel.ro 74840 74912 72 0.1
.rodata 132684 132956 272 0.2
.text 1782912 1788736 5824 0.3
tv-app debug (read only) 2508193 2515289 7096 0.3
(read/write) 139384 141056 1672 1.2
.bss 57184 58848 1664 2.9
.init_array 880 888 8 0.9
.rodata 197100 197676 576 0.3
.text 2138178 2144674 6496 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2394032 2396072 2040 0.1
.bss 188316 190092 1776 0.9
.data 5304 5320 16 0.3
.text 1356632 1358672 2040 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2356176 2357760 1584 0.1
.bss 180928 182704 1776 1.0
.text 1318776 1320360 1584 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2319896 2321288 1392 0.1
.bss 180816 182592 1776 1.0
.text 1282496 1283888 1392 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2305836 2307292 1456 0.1
.bss 178068 179844 1776 1.0
.text 1268408 1269864 1456 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1011763 1015363 3600 0.4
bss 121244 123020 1776 1.5
rodata 119336 119416 80 0.1
text 692176 693908 1732 0.3
nrf52840dk_nrf52840+rpc (read/write) 980591 984183 3592 0.4
bss 118432 120208 1776 1.5
rodata 110708 110780 72 0.1
text 671788 673520 1732 0.3
nrf52840dongle_nrf52840 (read/write) 1027651 1031067 3416 0.3
bss 122640 124416 1776 1.4
rodata 118204 118276 72 0.1
text 696844 698528 1684 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 918374 921958 3584 0.4
bss 117808 119584 1776 1.5
rodata 112576 112656 80 0.1
text 607200 608944 1744 0.3
lock-app nrf52840dk_nrf52840 (read/write) 941675 945083 3408 0.4
bss 119624 121400 1776 1.5
rodata 108080 108160 80 0.1
text 635408 636948 1540 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 849170 852594 3424 0.4
bss 116216 117992 1776 1.5
rodata 101252 101332 80 0.1
text 551208 552756 1548 0.3
pump-app nrf52840dk_nrf52840 (read/write) 941099 944507 3408 0.4
bss 119344 121120 1776 1.5
rodata 107440 107520 80 0.1
text 635672 637208 1536 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 936439 939847 3408 0.4
bss 119348 121124 1776 1.5
rodata 106732 106812 80 0.1
text 631704 633244 1540 0.2
shell nrf52840dk_nrf52840 (read/write) 803903 805927 2024 0.3
bss 111208 112400 1192 1.1
text 536280 537036 756 0.1
p6 all-clusters-app default (read/write) 2479568 2482304 2736 0.1
.bss 117576 119704 2128 1.8
.data 2656 2672 16 0.6
.text 1437832 1440568 2736 0.2
light-app default (read/write) 2386520 2388648 2128 0.1
.bss 107224 109352 2128 2.0
.text 1344784 1346912 2128 0.2
lock-app default (read/write) 2350136 2352104 1968 0.1
.bss 106944 109072 2128 2.0
.text 1308400 1310368 1968 0.2
qpg lighting-app qpg6105+debug (read only) 591164 592956 1792 0.3
.bss 88800 90536 1736 2.0
.text 585844 587636 1792 0.3
lock-app qpg6105+debug (read only) 557056 558708 1652 0.3
.bss 88784 90520 1736 2.0
.text 551736 553388 1652 0.3
telink lighting-app tlsr9518adk80d (read/write) 870530 874334 3804 0.4
bss 88576 90352 1776 2.0
text 611140 613082 1942 0.3
Decreases (1 build for nrfconnect)
platform target config section 14bab88 4794e53 change % change
nrfconnect shell nrf52840dk_nrf52840 rodata 78820 78812 -8 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 14bab88 4794e53 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600590 606682 6092 1.0
.app_xip_area 506172 508112 1940 0.4
.bss 77116 81268 4152 5.4
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557278 563158 5880 1.1
.app_xip_area 464420 466148 1728 0.4
.bss 75588 79740 4152 5.5
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578178 584170 5992 1.0
.app_xip_area 476072 477912 1840 0.4
.bss 84508 88660 4152 4.9
.data 556 556 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 904648 906792 2144 0.2
(read/write) 127224 129000 1776 1.4
.bss 125184 126960 1776 1.4
.data 2036 2036 0 0.0
.text 904640 906784 2144 0.2
BRD4161A+rpc (read only) 892108 894236 2128 0.2
(read/write) 143880 145656 1776 1.2
.bss 141744 143520 1776 1.3
.data 2136 2136 0 0.0
.text 892100 894228 2128 0.2
window-app BRD4161A (read only) 840048 841920 1872 0.2
(read/write) 125288 127064 1776 1.4
.bss 123384 125160 1776 1.4
.data 1904 1904 0 0.0
.text 840040 841912 1872 0.2
esp32 all-clusters-app c3devkit (read only) 941264 943304 2040 0.2
(read/write) 1398354 1400250 1896 0.1
.dram0.bss 66248 68024 1776 2.7
.dram0.data 14252 14276 24 0.2
.flash.rodata 198952 199040 88 0.0
.flash.text 941264 943304 2040 0.2
.iram0.text 62056 62056 0 0.0
m5stack (read only) 989271 993419 4148 0.4
(read/write) 463352 465504 2152 0.5
.dram0.bss 71392 73168 1776 2.5
.dram0.data 34048 34072 24 0.1
.flash.rodata 225784 226136 352 0.2
.flash.text 983887 988035 4148 0.4
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 680060 683544 3484 0.5
.bss 76488 78264 1776 2.3
.data 1908 1908 0 0.0
.text 595864 597572 1708 0.3
lock k32w061+release (read/write) 684940 688408 3468 0.5
.bss 76888 78664 1776 2.3
.data 1952 1952 0 0.0
.text 600300 601992 1692 0.3
linux all-clusters-app debug (read only) 2337313 2345665 8352 0.4
(read/write) 139936 141696 1760 1.3
.bss 54560 56224 1664 3.0
.data 1216 1312 96 7.9
.data.rel.ro 78488 78488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205413 205669 256 0.1
.text 1969650 1977746 8096 0.4
bridge-app debug+rpc (read only) 1708205 1713293 5088 0.3
(read/write) 84200 85864 1664 2.0
.bss 38960 40624 1664 4.3
.data 2034 2034 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141132 141420 288 0.2
.text 1450549 1455349 4800 0.3
chip-tool debug (read only) 7517893 7571909 54016 0.7
(read/write) 197048 198520 1472 0.7
.bss 32232 33512 1280 4.0
.data 1200 1200 0 0.0
.data.rel.ro 157560 157768 208 0.1
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 419701 421397 1696 0.4
.text 6697781 6749621 51840 0.8
chip-tool-ipv6only arm64 (read only) 7436332 7478116 41784 0.6
(read/write) 301809 303409 1600 0.5
.bss 50513 51777 1264 2.5
.data 1224 1224 0 0.0
.data.rel.ro 199240 199520 280 0.1
.dynamic 560 560 0 0.0
.got 47040 47088 48 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 401876 403020 1144 0.3
.text 6395284 6435220 39936 0.6
door-lock-app debug (read only) 1912881 1918513 5632 0.3
(read/write) 110520 112184 1664 1.5
.bss 42032 43696 1664 4.0
.data 1010 1010 0 0.0
.data.rel.ro 62064 62064 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172626 172882 256 0.1
.text 1591762 1597138 5376 0.3
lighting-app debug+rpc (read only) 2035169 2042817 7648 0.4
(read/write) 115768 117464 1696 1.5
.bss 43008 44672 1664 3.9
.data 1432 1464 32 2.2
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 164977 166385 1408 0.9
.text 1715378 1721618 6240 0.4
ota-provider-app debug (read only) 1716865 1858169 141304 8.2
(read/write) 81176 107928 26752 33.0
.bss 40992 43648 2656 6.5
.data 1192 1192 0 0.0
.data.rel.ro 33464 57448 23984 71.7
.dynamic 608 608 0 0.0
.got 4240 4368 128 3.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152678 158430 5752 3.8
.text 1445506 1549170 103664 7.2
ota-requestor-app debug (read only) 1711537 1852849 141312 8.3
(read/write) 83096 109048 25952 31.2
.bss 42112 43936 1824 4.3
.data 1160 1160 0 0.0
.data.rel.ro 34520 58504 23984 69.5
.dynamic 592 592 0 0.0
.got 4040 4176 136 3.4
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 146295 151823 5528 3.8
.text 1448370 1552178 103808 7.2
shell debug (read only) 2310769 2319425 8656 0.4
(read/write) 141392 144720 3328 2.4
.bss 61824 65120 3296 5.3
.data 816 848 32 3.9
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206130 206674 544 0.3
.text 1948194 1956306 8112 0.4
thermostat-no-ble arm64 (read only) 2133644 2139804 6160 0.3
(read/write) 140529 142273 1744 1.2
.bss 57537 59201 1664 2.9
.data 1032 1040 8 0.8
.data.rel.ro 74840 74912 72 0.1
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132684 132956 272 0.2
.text 1782912 1788736 5824 0.3
tv-app debug (read only) 2508193 2515289 7096 0.3
(read/write) 139384 141056 1672 1.2
.bss 57184 58848 1664 2.9
.data 3200 3200 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 888 8 0.9
.rodata 197100 197676 576 0.3
.text 2138178 2144674 6496 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2394032 2396072 2040 0.1
.bss 188316 190092 1776 0.9
.data 5304 5320 16 0.3
.text 1356632 1358672 2040 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2356176 2357760 1584 0.1
.bss 180928 182704 1776 1.0
.data 5632 5632 0 0.0
.text 1318776 1320360 1584 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319896 2321288 1392 0.1
.bss 180816 182592 1776 1.0
.data 5608 5608 0 0.0
.text 1282496 1283888 1392 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305836 2307292 1456 0.1
.bss 178068 179844 1776 1.0
.data 5424 5424 0 0.0
.text 1268408 1269864 1456 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1011763 1015363 3600 0.4
bss 121244 123020 1776 1.5
rodata 119336 119416 80 0.1
text 692176 693908 1732 0.3
nrf52840dk_nrf52840+rpc (read/write) 980591 984183 3592 0.4
bss 118432 120208 1776 1.5
rodata 110708 110780 72 0.1
text 671788 673520 1732 0.3
nrf52840dongle_nrf52840 (read/write) 1027651 1031067 3416 0.3
bss 122640 124416 1776 1.4
rodata 118204 118276 72 0.1
text 696844 698528 1684 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 918374 921958 3584 0.4
bss 117808 119584 1776 1.5
rodata 112576 112656 80 0.1
text 607200 608944 1744 0.3
lock-app nrf52840dk_nrf52840 (read/write) 941675 945083 3408 0.4
bss 119624 121400 1776 1.5
rodata 108080 108160 80 0.1
text 635408 636948 1540 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 849170 852594 3424 0.4
bss 116216 117992 1776 1.5
rodata 101252 101332 80 0.1
text 551208 552756 1548 0.3
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 941099 944507 3408 0.4
bss 119344 121120 1776 1.5
rodata 107440 107520 80 0.1
text 635672 637208 1536 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 936439 939847 3408 0.4
bss 119348 121124 1776 1.5
rodata 106732 106812 80 0.1
text 631704 633244 1540 0.2
shell nrf52840dk_nrf52840 (read/write) 803903 805927 2024 0.3
bss 111208 112400 1192 1.1
rodata 78820 78812 -8 -0.0
text 536280 537036 756 0.1
p6 all-clusters-app default (read/write) 2479568 2482304 2736 0.1
.bss 117576 119704 2128 1.8
.data 2656 2672 16 0.6
.text 1437832 1440568 2736 0.2
light-app default (read/write) 2386520 2388648 2128 0.1
.bss 107224 109352 2128 2.0
.data 2528 2528 0 0.0
.text 1344784 1346912 2128 0.2
lock-app default (read/write) 2350136 2352104 1968 0.1
.bss 106944 109072 2128 2.0
.data 2488 2488 0 0.0
.text 1308400 1310368 1968 0.2
qpg lighting-app qpg6105+debug (read only) 591164 592956 1792 0.3
(read/write) 146940 146940 0 0.0
.bss 88800 90536 1736 2.0
.data 1112 1112 0 0.0
.text 585844 587636 1792 0.3
lock-app qpg6105+debug (read only) 557056 558708 1652 0.3
(read/write) 146940 146940 0 0.0
.bss 88784 90520 1736 2.0
.data 1064 1064 0 0.0
.text 551736 553388 1652 0.3
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 870530 874334 3804 0.4
bss 88576 90352 1776 2.0
noinit 37160 37160 0 0.0
text 611140 613082 1942 0.3

bzbarsky-apple
bzbarsky-apple approved these changes Feb 10, 2022
View reviewed changes
examples/all-clusters-app/esp32/main/StatusScreen.cpp Outdated Show resolved Hide resolved
examples/all-clusters-app/esp32/main/StatusScreen.cpp Outdated Show resolved Hide resolved
examples/all-clusters-app/esp32/main/StatusScreen.cpp Outdated Show resolved Hide resolved
src/credentials/FabricTable.h Show resolved Hide resolved
@andy31415
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14986: Size comparison from a08613b to d63c1a5

Increases above 0.2%:

platform target config section a08613be d63c1a5 change % change
esp32 all-clusters-app m5stack (read only) 990967 993419 2452 0.2
.flash.text 985583 988035 2452 0.2
Increases (1 build for esp32)
platform target config section a08613be d63c1a5 change % change
esp32 all-clusters-app m5stack (read only) 990967 993419 2452 0.2
(read/write) 465080 465504 424 0.1
.flash.rodata 225712 226136 424 0.2
.flash.text 985583 988035 2452 0.2
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a08613be d63c1a5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 606702 0 0.0
.app_xip_area 508132 508132 0 0.0
.bss 81268 81268 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563174 563174 0 0.0
.app_xip_area 466164 466164 0 0.0
.bss 79740 79740 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584190 584190 0 0.0
.app_xip_area 477932 477932 0 0.0
.bss 88660 88660 0 0.0
.data 556 556 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906824 906824 0 0.0
(read/write) 129000 129000 0 0.0
.bss 126960 126960 0 0.0
.data 2036 2036 0 0.0
.text 906816 906816 0 0.0
BRD4161A+rpc (read only) 894268 894268 0 0.0
(read/write) 145656 145656 0 0.0
.bss 143520 143520 0 0.0
.data 2136 2136 0 0.0
.text 894260 894260 0 0.0
window-app BRD4161A (read only) 841936 841936 0 0.0
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1904 1904 0 0.0
.text 841928 841928 0 0.0
esp32 all-clusters-app c3devkit (read only) 943304 943304 0 0.0
(read/write) 1400250 1400250 0 0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 199040 199040 0 0.0
.flash.text 943304 943304 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 993419 2452 0.2
(read/write) 465080 465504 424 0.1
.dram0.bss 73168 73168 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 225712 226136 424 0.2
.flash.text 985583 988035 2452 0.2
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683560 683560 0 0.0
.bss 78264 78264 0 0.0
.data 1908 1908 0 0.0
.text 597588 597588 0 0.0
lock k32w061+release (read/write) 688440 688440 0 0.0
.bss 78664 78664 0 0.0
.data 1952 1952 0 0.0
.text 602024 602024 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7478108 7478108 0 0.0
(read/write) 303409 303409 0 0.0
.bss 51777 51777 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 199520 199520 0 0.0
.dynamic 560 560 0 0.0
.got 47088 47088 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403012 403012 0 0.0
.text 6435220 6435220 0 0.0
thermostat-no-ble arm64 (read only) 2139804 2139804 0 0.0
(read/write) 142273 142273 0 0.0
.bss 59201 59201 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 74912 74912 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132956 0 0.0
.text 1788736 1788736 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396136 2396136 0 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1358736 1358736 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2357760 0 0.0
.bss 182704 182704 0 0.0
.data 5632 5632 0 0.0
.text 1320360 1320360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321288 0 0.0
.bss 182592 182592 0 0.0
.data 5608 5608 0 0.0
.text 1283888 1283888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307292 0 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1269864 1269864 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015395 1015395 0 0.0
bss 123020 123020 0 0.0
rodata 119416 119416 0 0.0
text 693940 693940 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 984215 984215 0 0.0
bss 120208 120208 0 0.0
rodata 110780 110780 0 0.0
text 673552 673552 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031099 1031099 0 0.0
bss 124416 124416 0 0.0
rodata 118276 118276 0 0.0
text 698556 698556 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 921990 921990 0 0.0
bss 119584 119584 0 0.0
rodata 112656 112656 0 0.0
text 608976 608976 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945099 945099 0 0.0
bss 121400 121400 0 0.0
rodata 108160 108160 0 0.0
text 636968 636968 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852610 852610 0 0.0
bss 117992 117992 0 0.0
rodata 101332 101332 0 0.0
text 552776 552776 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944539 944539 0 0.0
bss 121120 121120 0 0.0
rodata 107520 107520 0 0.0
text 637228 637228 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 939863 939863 0 0.0
bss 121124 121124 0 0.0
rodata 106812 106812 0 0.0
text 633264 633264 0 0.0
shell nrf52840dk_nrf52840 (read/write) 805927 805927 0 0.0
bss 112400 112400 0 0.0
rodata 78812 78812 0 0.0
text 537036 537036 0 0.0
p6 all-clusters-app default (read/write) 2482336 2482336 0 0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440600 1440600 0 0.0
light-app default (read/write) 2388664 2388664 0 0.0
.bss 109352 109352 0 0.0
.data 2528 2528 0 0.0
.text 1346928 1346928 0 0.0
lock-app default (read/write) 2352120 2352120 0 0.0
.bss 109072 109072 0 0.0
.data 2488 2488 0 0.0
.text 1310384 1310384 0 0.0
qpg lighting-app qpg6105+debug (read only) 592980 592980 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90536 90536 0 0.0
.data 1112 1112 0 0.0
.text 587660 587660 0 0.0
lock-app qpg6105+debug (read only) 558732 558732 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90520 90520 0 0.0
.data 1064 1064 0 0.0
.text 553412 553412 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874334 0 0.0
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613082 613082 0 0.0

@turon turon mentioned this pull request Feb 10, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14986: Size comparison from a08613b to 5681964

Increases above 0.2%:

platform target config section a08613be 5681964 change % change
esp32 all-clusters-app m5stack (read only) 990967 993607 2640 0.3
.flash.text 985583 988223 2640 0.3
linux chip-tool-ipv6only arm64 (read only) 7478108 8053036 574928 7.7
(read/write) 303409 339473 36064 11.9
.data.rel.ro 199520 233784 34264 17.2
.got 47088 48904 1816 3.9
.rodata 403012 433156 30144 7.5
.text 6435220 6894308 459088 7.1
Increases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, qpg, telink)
platform target config section a08613be 5681964 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607102 400 0.1
.app_xip_area 508132 508532 400 0.1
lock cyw930739m2evb_01 (read/write) 563174 563806 632 0.1
.app_xip_area 466164 466804 640 0.1
ota-requestor cyw930739m2evb_01 (read/write) 584190 584582 392 0.1
.app_xip_area 477932 478332 400 0.1
efr32 lighting-app BRD4161A (read only) 906824 907520 696 0.1
.text 906816 907512 696 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943846 542 0.1
.flash.text 943304 943846 542 0.1
m5stack (read only) 990967 993607 2640 0.3
.flash.text 985583 988223 2640 0.3
k32w light k32w061+release (read/write) 683560 684216 656 0.1
.text 597588 598248 660 0.1
lock k32w061+release (read/write) 688440 689080 640 0.1
.text 602024 602668 644 0.1
linux chip-tool-ipv6only arm64 (read only) 7478108 8053036 574928 7.7
(read/write) 303409 339473 36064 11.9
.data.rel.ro 199520 233784 34264 17.2
.got 47088 48904 1816 3.9
.rodata 403012 433156 30144 7.5
.text 6435220 6894308 459088 7.1
thermostat-no-ble arm64 (read only) 2139804 2140044 240 0.0
(read/write) 142273 142305 32 0.0
.data.rel.ro 74912 74960 48 0.1
.text 1788736 1789472 736 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2396136 2396768 632 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2357760 2358456 696 0.0
.text 1320360 1321056 696 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2321288 2321984 696 0.0
.text 1283888 1284584 696 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2307292 2307988 696 0.0
.text 1269864 1270560 696 0.1
qpg lighting-app qpg6105+debug (read only) 592980 593632 652 0.1
.text 587660 588312 652 0.1
lock-app qpg6105+debug (read only) 558732 559384 652 0.1
.text 553412 554064 652 0.1
telink lighting-app tlsr9518adk80d (read/write) 874334 874830 496 0.1
text 613082 613464 382 0.1
Decreases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section a08613be 5681964 change % change
cyw30739 light cyw930739m2evb_01 .data 648 644 -4 -0.6
lock cyw930739m2evb_01 .data 612 608 -4 -0.7
ota-requestor cyw930739m2evb_01 .data 556 552 -4 -0.7
efr32 lighting-app BRD4161A (read/write) 129000 128992 -8 -0.0
.data 2036 2032 -4 -0.2
BRD4161A+rpc (read/write) 145656 145652 -4 -0.0
.data 2136 2132 -4 -0.2
window-app BRD4161A .data 1904 1900 -4 -0.2
esp32 all-clusters-app c3devkit (read/write) 1400250 1399770 -480 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
m5stack (read/write) 465080 465032 -48 -0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225672 -40 -0.0
k32w light k32w061+release .data 1908 1904 -4 -0.2
lock k32w061+release .data 1952 1948 -4 -0.2
linux chip-tool-ipv6only arm64 .data 1224 1216 -8 -0.7
thermostat-no-ble arm64 .data 1040 1032 -8 -0.8
.got 4152 4144 -8 -0.2
.rodata 132956 132460 -496 -0.4
mbed lighting-app CY8CPROTO_062_4343W+release .data 5632 5624 -8 -0.1
lock-app CY8CPROTO_062_4343W+release .data 5608 5600 -8 -0.1
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388632 -32 -0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346896 -32 -0.0
lock-app default (read/write) 2352120 2352072 -48 -0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310336 -48 -0.0
qpg lighting-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1112 1108 -4 -0.4
lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1064 1060 -4 -0.4
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section a08613be 5681964 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607102 400 0.1
.app_xip_area 508132 508532 400 0.1
.bss 81268 81268 0 0.0
.data 648 644 -4 -0.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563174 563806 632 0.1
.app_xip_area 466164 466804 640 0.1
.bss 79740 79740 0 0.0
.data 612 608 -4 -0.7
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584190 584582 392 0.1
.app_xip_area 477932 478332 400 0.1
.bss 88660 88660 0 0.0
.data 556 552 -4 -0.7
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906824 907520 696 0.1
(read/write) 129000 128992 -8 -0.0
.bss 126960 126960 0 0.0
.data 2036 2032 -4 -0.2
.text 906816 907512 696 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
(read/write) 145656 145652 -4 -0.0
.bss 143520 143520 0 0.0
.data 2136 2132 -4 -0.2
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1904 1900 -4 -0.2
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943846 542 0.1
(read/write) 1400250 1399770 -480 -0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
.flash.text 943304 943846 542 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 993607 2640 0.3
(read/write) 465080 465032 -48 -0.0
.dram0.bss 73168 73168 0 0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225672 -40 -0.0
.flash.text 985583 988223 2640 0.3
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683560 684216 656 0.1
.bss 78264 78264 0 0.0
.data 1908 1904 -4 -0.2
.text 597588 598248 660 0.1
lock k32w061+release (read/write) 688440 689080 640 0.1
.bss 78664 78664 0 0.0
.data 1952 1948 -4 -0.2
.text 602024 602668 644 0.1
linux chip-tool-ipv6only arm64 (read only) 7478108 8053036 574928 7.7
(read/write) 303409 339473 36064 11.9
.bss 51777 51777 0 0.0
.data 1224 1216 -8 -0.7
.data.rel.ro 199520 233784 34264 17.2
.dynamic 560 560 0 0.0
.got 47088 48904 1816 3.9
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403012 433156 30144 7.5
.text 6435220 6894308 459088 7.1
thermostat-no-ble arm64 (read only) 2139804 2140044 240 0.0
(read/write) 142273 142305 32 0.0
.bss 59201 59201 0 0.0
.data 1040 1032 -8 -0.8
.data.rel.ro 74912 74960 48 0.1
.dynamic 560 560 0 0.0
.got 4152 4144 -8 -0.2
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132460 -496 -0.4
.text 1788736 1789472 736 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396136 2396768 632 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2358456 696 0.0
.bss 182704 182704 0 0.0
.data 5632 5624 -8 -0.1
.text 1320360 1321056 696 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321984 696 0.0
.bss 182592 182592 0 0.0
.data 5608 5600 -8 -0.1
.text 1283888 1284584 696 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307988 696 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1269864 1270560 696 0.1
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388632 -32 -0.0
.bss 109352 109352 0 0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346896 -32 -0.0
lock-app default (read/write) 2352120 2352072 -48 -0.0
.bss 109072 109072 0 0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310336 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 592980 593632 652 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90536 90536 0 0.0
.data 1112 1108 -4 -0.4
.text 587660 588312 652 0.1
lock-app qpg6105+debug (read only) 558732 559384 652 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90520 90520 0 0.0
.data 1064 1060 -4 -0.4
.text 553412 554064 652 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874830 496 0.1
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613082 613464 382 0.1

@turon @bzbarsky-apple
Apply suggestions from code review
1626d5c 
Use simplified call to `IPAddress::ToString()`.

Co-authored-by: Boris Zbarsky <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14986: Size comparison from a08613b to 1626d5c

Increases above 0.2%:

platform target config section a08613be 1626d5c change % change
esp32 all-clusters-app m5stack (read only) 990967 993607 2640 0.3
.flash.text 985583 988223 2640 0.3
Increases (18 builds for efr32, esp32, mbed, nrfconnect)
platform target config section a08613be 1626d5c change % change
efr32 lighting-app BRD4161A (read only) 906824 907520 696 0.1
.text 906816 907512 696 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943846 542 0.1
.flash.text 943304 943846 542 0.1
m5stack (read only) 990967 993607 2640 0.3
.flash.text 985583 988223 2640 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2396136 2396768 632 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2357760 2358456 696 0.0
.text 1320360 1321056 696 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2321288 2321984 696 0.0
.text 1283888 1284584 696 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2307292 2307988 696 0.0
.text 1269864 1270560 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015395 1016043 648 0.1
rodata 119416 119528 112 0.1
text 693940 694484 544 0.1
nrf52840dk_nrf52840+rpc (read/write) 984215 984875 660 0.1
rodata 110780 110896 116 0.1
text 673552 674096 544 0.1
nrf52840dongle_nrf52840 (read/write) 1031099 1031759 660 0.1
rodata 118276 118392 116 0.1
text 698556 699100 544 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 921990 922642 652 0.1
rodata 112656 112772 116 0.1
text 608976 609520 544 0.1
lock-app nrf52840dk_nrf52840 (read/write) 945099 945759 660 0.1
rodata 108160 108276 116 0.1
text 636968 637512 544 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 852610 853266 656 0.1
rodata 101332 101444 112 0.1
text 552776 553320 544 0.1
pump-app nrf52840dk_nrf52840 (read/write) 944539 945187 648 0.1
rodata 107520 107632 112 0.1
text 637228 637772 544 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 939863 940519 656 0.1
rodata 106812 106924 112 0.1
text 633264 633808 544 0.1
shell nrf52840dk_nrf52840 (read/write) 805927 806335 408 0.1
rodata 78812 78948 136 0.2
text 537036 537308 272 0.1
Decreases (7 builds for efr32, esp32, mbed)
platform target config section a08613be 1626d5c change % change
efr32 lighting-app BRD4161A (read/write) 129000 128992 -8 -0.0
.data 2036 2032 -4 -0.2
BRD4161A+rpc (read/write) 145656 145652 -4 -0.0
.data 2136 2132 -4 -0.2
window-app BRD4161A .data 1904 1900 -4 -0.2
esp32 all-clusters-app c3devkit (read/write) 1400250 1399770 -480 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
m5stack (read/write) 465080 465032 -48 -0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225672 -40 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release .data 5632 5624 -8 -0.1
lock-app CY8CPROTO_062_4343W+release .data 5608 5600 -8 -0.1
Full report (20 builds for efr32, esp32, mbed, nrfconnect)
platform target config section a08613be 1626d5c change % change
efr32 lighting-app BRD4161A (read only) 906824 907520 696 0.1
(read/write) 129000 128992 -8 -0.0
.bss 126960 126960 0 0.0
.data 2036 2032 -4 -0.2
.text 906816 907512 696 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
(read/write) 145656 145652 -4 -0.0
.bss 143520 143520 0 0.0
.data 2136 2132 -4 -0.2
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1904 1900 -4 -0.2
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943846 542 0.1
(read/write) 1400250 1399770 -480 -0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
.flash.text 943304 943846 542 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 993607 2640 0.3
(read/write) 465080 465032 -48 -0.0
.dram0.bss 73168 73168 0 0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225672 -40 -0.0
.flash.text 985583 988223 2640 0.3
.iram0.text 123399 123399 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396136 2396768 632 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2358456 696 0.0
.bss 182704 182704 0 0.0
.data 5632 5624 -8 -0.1
.text 1320360 1321056 696 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321984 696 0.0
.bss 182592 182592 0 0.0
.data 5608 5600 -8 -0.1
.text 1283888 1284584 696 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307988 696 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1269864 1270560 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015395 1016043 648 0.1
bss 123020 123020 0 0.0
rodata 119416 119528 112 0.1
text 693940 694484 544 0.1
nrf52840dk_nrf52840+rpc (read/write) 984215 984875 660 0.1
bss 120208 120208 0 0.0
rodata 110780 110896 116 0.1
text 673552 674096 544 0.1
nrf52840dongle_nrf52840 (read/write) 1031099 1031759 660 0.1
bss 124416 124416 0 0.0
rodata 118276 118392 116 0.1
text 698556 699100 544 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 921990 922642 652 0.1
bss 119584 119584 0 0.0
rodata 112656 112772 116 0.1
text 608976 609520 544 0.1
lock-app nrf52840dk_nrf52840 (read/write) 945099 945759 660 0.1
bss 121400 121400 0 0.0
rodata 108160 108276 116 0.1
text 636968 637512 544 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 852610 853266 656 0.1
bss 117992 117992 0 0.0
rodata 101332 101444 112 0.1
text 552776 553320 544 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944539 945187 648 0.1
bss 121120 121120 0 0.0
rodata 107520 107632 112 0.1
text 637228 637772 544 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 939863 940519 656 0.1
bss 121124 121124 0 0.0
rodata 106812 106924 112 0.1
text 633264 633808 544 0.1
shell nrf52840dk_nrf52840 (read/write) 805927 806335 408 0.1
bss 112400 112400 0 0.0
rodata 78812 78948 136 0.2
text 537036 537308 272 0.1

@andy31415 andy31415 merged commit d0e88bb into project-chip:master Feb 10, 2022
bzbarsky-apple
bzbarsky-apple reviewed Feb 11, 2022
View reviewed changes
examples/all-clusters-app/esp32/main/StatusScreen.cpp
switch (i)
{
case kStatusItemFabricIndex: {
for (const auto & fb : Server::GetInstance().GetFabricTable())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turon For what it's worth, this has issues similar to #15065

We should probably really queue this stuff over to the Matter thread and then block until it runs or something....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@cecille cecille cecille approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turon @andy31415 @cecille @bzbarsky-apple