Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to queue m5stack actions to the Matter thread as needed. (#… #15234

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Make sure to queue m5stack actions to the Matter thread as needed. (#… #15234

merged 1 commit into from
Feb 16, 2022

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Feb 16, 2022

…15066)

Fixes #15065

(cherry picked from commit 379d144)

@mspang mspang merged commit f3f994e into project-chip:interop_testing_2022_01_18 Feb 16, 2022
@mspang mspang deleted the for-chip/backport-queue branch February 16, 2022 02:11
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #15234: Size comparison from da7c5ce to ef1aee2

Increases (2 builds for esp32)
platform target config section da7c5ce ef1aee2 change % change
esp32 all-clusters-app c3devkit (read only) 912484 912562 78 0.0
(read/write) 1316714 1316786 72 0.0
.flash.rodata 178384 178456 72 0.0
.flash.text 912484 912562 78 0.0
m5stack (read only) 961391 961515 124 0.0
(read/write) 448860 448932 72 0.0
.flash.rodata 207668 207740 72 0.0
.flash.text 956007 956131 124 0.0
Full report (41 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section da7c5ce ef1aee2 change % change
efr32 lighting-app BRD4161A (read only) 834756 834756 0 0.0
(read/write) 127616 127616 0 0.0
.bss 125728 125728 0 0.0
.data 1888 1888 0 0.0
.text 834748 834748 0 0.0
BRD4161A+rpc (read only) 822136 822136 0 0.0
(read/write) 144280 144280 0 0.0
.bss 142288 142288 0 0.0
.data 1988 1988 0 0.0
.text 822128 822128 0 0.0
window-app BRD4161A (read only) 805520 805520 0 0.0
(read/write) 126328 126328 0 0.0
.bss 124488 124488 0 0.0
.data 1840 1840 0 0.0
.text 805512 805512 0 0.0
esp32 all-clusters-app c3devkit (read only) 912484 912562 78 0.0
(read/write) 1316714 1316786 72 0.0
.dram0.bss 70536 70536 0 0.0
.dram0.data 14292 14292 0 0.0
.flash.rodata 178384 178456 72 0.0
.flash.text 912484 912562 78 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961391 961515 124 0.0
(read/write) 448860 448932 72 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207668 207740 72 0.0
.flash.text 956007 956131 124 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659304 659304 0 0.0
.bss 77136 77136 0 0.0
.data 1856 1856 0 0.0
.text 574512 574512 0 0.0
lock k32w061+release (read/write) 662140 662140 0 0.0
.bss 77440 77440 0 0.0
.data 1876 1876 0 0.0
.text 577024 577024 0 0.0
linux all-clusters-app debug (read only) 2159449 2159449 0 0.0
(read/write) 145632 145632 0 0.0
.bss 63192 63192 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 75600 75600 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 179381 179381 0 0.0
.text 1821394 1821394 0 0.0
bridge-app debug+rpc (read only) 1611061 1611061 0 0.0
(read/write) 88696 88696 0 0.0
.bss 45664 45664 0 0.0
.data 1792 1792 0 0.0
.data.rel.ro 36120 36120 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 136276 136276 0 0.0
.text 1360869 1360869 0 0.0
chip-tool debug (read only) 8182021 8182021 0 0.0
(read/write) 248328 248328 0 0.0
.bss 38808 38808 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 202664 202664 0 0.0
.dynamic 592 592 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 584 584 0 0.0
.rodata 409393 409393 0 0.0
.text 7270837 7270837 0 0.0
chip-tool-ipv6only arm64 (read only) 8090644 8090644 0 0.0
(read/write) 373409 373409 0 0.0
.bss 55217 55217 0 0.0
.data 1112 1112 0 0.0
.data.rel.ro 248088 248088 0 0.0
.dynamic 560 560 0 0.0
.got 65304 65304 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 421100 421100 0 0.0
.text 6873748 6873748 0 0.0
door-lock-app debug (read only) 1695913 1695913 0 0.0
(read/write) 115008 115008 0 0.0
.bss 48704 48704 0 0.0
.data 928 928 0 0.0
.data.rel.ro 60008 60008 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 145468 145468 0 0.0
.text 1404882 1404882 0 0.0
lighting-app debug+rpc (read only) 1890833 1890833 0 0.0
(read/write) 120944 120944 0 0.0
.bss 50560 50560 0 0.0
.data 1312 1312 0 0.0
.data.rel.ro 63608 63608 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 157809 157809 0 0.0
.text 1581474 1581474 0 0.0
ota-provider-app debug (read only) 1514425 1514425 0 0.0
(read/write) 84384 84384 0 0.0
.bss 47200 47200 0 0.0
.data 936 936 0 0.0
.data.rel.ro 31000 31000 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 135694 135694 0 0.0
.text 1267810 1267810 0 0.0
ota-requestor-app debug (read only) 1601081 1601081 0 0.0
(read/write) 88040 88040 0 0.0
.bss 48960 48960 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 32776 32776 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 141239 141239 0 0.0
.text 1345874 1345874 0 0.0
shell debug (read only) 2168241 2168241 0 0.0
(read/write) 146248 146248 0 0.0
.bss 69408 69408 0 0.0
.data 848 848 0 0.0
.data.rel.ro 70320 70320 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 180850 180850 0 0.0
.text 1833826 1833826 0 0.0
thermostat-no-ble arm64 (read only) 2044300 2044300 0 0.0
(read/write) 145985 145985 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 129932 129932 0 0.0
.text 1699760 1699760 0 0.0
tv-app debug (read only) 2203337 2203337 0 0.0
(read/write) 373256 373256 0 0.0
.bss 294592 294592 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 69776 69776 0 0.0
.dynamic 592 592 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 186076 186076 0 0.0
.text 1851410 1851410 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350376 2350376 0 0.0
.bss 189220 189220 0 0.0
.data 5320 5320 0 0.0
.text 1312952 1312952 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334504 2334504 0 0.0
.bss 180744 180744 0 0.0
.data 5568 5568 0 0.0
.text 1297104 1297104 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305176 2305176 0 0.0
.bss 179776 179776 0 0.0
.data 5552 5552 0 0.0
.text 1267776 1267776 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054568 2054568 0 0.0
.bss 156884 156884 0 0.0
.data 4864 4864 0 0.0
.text 1017168 1017168 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943355 943355 0 0.0
bss 119612 119612 0 0.0
rodata 108752 108752 0 0.0
text 637428 637428 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928871 928871 0 0.0
bss 116656 116656 0 0.0
rodata 101204 101204 0 0.0
text 632820 632820 0 0.0
nrf52840dongle_nrf52840 (read/write) 994035 994035 0 0.0
bss 122452 122452 0 0.0
rodata 113508 113508 0 0.0
text 669624 669624 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853230 853230 0 0.0
bss 116396 116396 0 0.0
rodata 101944 101944 0 0.0
text 554340 554340 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913047 913047 0 0.0
bss 118788 118788 0 0.0
rodata 103860 103860 0 0.0
text 613008 613008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823086 823086 0 0.0
bss 115604 115604 0 0.0
rodata 97088 97088 0 0.0
text 529964 529964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915883 915883 0 0.0
bss 118552 118552 0 0.0
rodata 104224 104224 0 0.0
text 615660 615660 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910967 910967 0 0.0
bss 118576 118576 0 0.0
rodata 103332 103332 0 0.0
text 611584 611584 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798739 798739 0 0.0
bss 109780 109780 0 0.0
rodata 78424 78424 0 0.0
text 534040 534040 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711538 711538 0 0.0
bss 107668 107668 0 0.0
rodata 72724 72724 0 0.0
text 451712 451712 0 0.0
p6 all-clusters-app default (read/write) 2405272 2405272 0 0.0
.bss 117564 117564 0 0.0
.data 2608 2608 0 0.0
.text 1363536 1363536 0 0.0
light-app default (read/write) 2329968 2329968 0 0.0
.bss 106112 106112 0 0.0
.data 2400 2400 0 0.0
.text 1288232 1288232 0 0.0
lock-app default (read/write) 2299152 2299152 0 0.0
.bss 104976 104976 0 0.0
.data 2344 2344 0 0.0
.text 1257416 1257416 0 0.0
qpg lighting-app qpg6105+debug (read only) 565036 565036 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89944 89944 0 0.0
.data 1052 1052 0 0.0
.text 559716 559716 0 0.0
lock-app qpg6105+debug (read only) 515716 515716 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88592 88592 0 0.0
.data 976 976 0 0.0
.text 510396 510396 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840782 840782 0 0.0
bss 87304 87304 0 0.0
noinit 37160 37160 0 0.0
text 587812 587812 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Feb 16, 2022
View reviewed changes
examples/all-clusters-app/esp32/main/CHIPDeviceManager.cpp
@@ -99,6 +99,13 @@ CHIP_ERROR CHIPDeviceManager::Init(CHIPDeviceManagerCallbacks * cb)
void MatterPostAttributeChangeCallback(const chip::app::ConcreteAttributePath & path, uint8_t mask, uint8_t type, uint16_t size,
uint8_t * value)
{
TaskHandle_t task = xTaskGetCurrentTaskHandle();
const char * name = pcTaskGetName(task);
if (!strcmp(name, "CHIP"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this test is backwards; you may want to cherry-pick the fix for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mspang @bzbarsky-apple