Access control clean up #14449
Comments
andy31415
added
v1_triage_split_11
V1.0
acl
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this issue
Apr 13, 2022
- When bringing-up an AccessControl::Delegate, extra policy verbose logging is helpful. However, extra verbose logging is currently always enabled, which takes a lot of logging buffer space when complex transactions (long paths, wildcards) are used, to just emit debug data. - Current method to turn it down is to turn off all progress logging, but progress logging may have a lot of important details. This PR introduces a logging verbosity control for Access Control, using the `chip_access_control_policy_logging_verbosity` build config variable. High verbosity is maintained in linux/Darwin *-app, but turned down by default elsewhere. Issue project-chip#14449 Testing done: - unit tests still pass - integration tests still pass - logs are less on m5stack - logs are fully verbose on linux
bzbarsky-apple
pushed a commit
that referenced
this issue
Apr 14, 2022
* Introduce ACL logging verbosity control - When bringing-up an AccessControl::Delegate, extra policy verbose logging is helpful. However, extra verbose logging is currently always enabled, which takes a lot of logging buffer space when complex transactions (long paths, wildcards) are used, to just emit debug data. - Current method to turn it down is to turn off all progress logging, but progress logging may have a lot of important details. This PR introduces a logging verbosity control for Access Control, using the `chip_access_control_policy_logging_verbosity` build config variable. High verbosity is maintained in linux/Darwin *-app, but turned down by default elsewhere. Issue #14449 Testing done: - unit tests still pass - integration tests still pass - logs are less on m5stack - logs are fully verbose on linux * Restyled by clang-format * Restyled by gn * Fix CI Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this issue
Apr 14, 2022
* Introduce ACL logging verbosity control - When bringing-up an AccessControl::Delegate, extra policy verbose logging is helpful. However, extra verbose logging is currently always enabled, which takes a lot of logging buffer space when complex transactions (long paths, wildcards) are used, to just emit debug data. - Current method to turn it down is to turn off all progress logging, but progress logging may have a lot of important details. This PR introduces a logging verbosity control for Access Control, using the `chip_access_control_policy_logging_verbosity` build config variable. High verbosity is maintained in linux/Darwin *-app, but turned down by default elsewhere. Issue project-chip#14449 Testing done: - unit tests still pass - integration tests still pass - logs are less on m5stack - logs are fully verbose on linux * Restyled by clang-format * Restyled by gn * Fix CI Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Access control was developed with an eye toward delivering features, and needs an opportunity to perform some clean up refactoring if necessary.
The text was updated successfully, but these errors were encountered: